Keep report in same place in LHN after deleting last comment #28431
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt is the last one
Li357
changed the title
Li357
changed the title
|
@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@robertKozik I can't get Android to work. For some reason API requests just fail, so I can't upload videos for those. In console, I see: Any tips/have you seen this before? If not, could you test on Android and verify? |
Closed
6 tasks
|
I didn't encounter such an error before, will try to test & verify on my end 👌🏼 |
0xmiros
reviewed
Oct 12, 2023
Deploying with
|
| Latest commit: |
5b9c564
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a2afc38d.helpdot.pages.dev |
| Branch Preview URL: | https://andrewli-fixlhn.helpdot.pages.dev |
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
|
@robertKozik Can we keep this moving? |
|
Yeah, sorry, I'll end it today 🙇🏼 |
|
Hey @Li357, one more time, sorry for the delay 🙇🏼 While testing, I encountered a problem: the task position was reset, and after a while, it was restored to the proper position (I'm attaching a video). It seems like we need to wait for a backend response before the item gets its proper position. Can you confirm if you're experiencing the same, or if it's possibly a cache issue on my end? problemo.mov |
6 tasks
|
hi @robertKozik and @0xmiroslav could you check and see if this deploy blocker is a regression from this PR? |
|
This PR is not merged yet @Christinadobrzyn |
|
@robertKozik Apologies for the delays here. This should not be the case, the backend should respond by not resetting the position, perhaps there was an internal regression. I'm currently unable to test backend code, but I'll check on this. |
|
@robertKozik We are ready to test this. Can you point App to staging and test out these changes locally? |
|
@MonilBhavsar I don't think I'll be able to get this tested by C+ by EOD. Could you handle getting a new C+ assigned if we don't get a response in the next day since you have the context from https://github.com/Expensify/Web-Expensify/pull/39653#issuecomment-1834260048? That would be awesome 🙏 |
|
I am available to review right now. |
|
@situchan please go ahead as I am done for the day |
situchan
reviewed
Nov 30, 2023
There was a problem hiding this comment.
@Li357 I just tested pointing to staging backend but order still changes
test.mov
I'd like to confirm the expected behavior:
(Condition: both reports are not pinned, not have any green/red dot)
- report A's last message X is newer than report B's last message Y (LHN order: A > B)
- send new message Z in report B (LHN order: B > A)
- delete message Z in report B (LHN order: A > B)
Is it expected or bug?
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
@situchan The expected behavior should be that it does not change position if we remove the last message in a chat report. |
|
ok so it's bug and still not fixed yet both in frontend and backend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Right now the LHN position resets after deleting the last comment in a report. Let's keep it where it is. Web-E PR here: https://github.com/Expensify/Web-Expensify/pull/39028
Fixed Issues
$ #26479
Tests
See QA steps
Offline tests
Same as QA steps, since these changes unify optimistic behavior as well.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
Mobile Web - Safari
Simulator.Screen.Recording.-.iPhone.14.16.1.-.2023-10-11.at.22.44.33.mp4
Desktop
desktop.mov
iOS
Simulator.Screen.Recording.-.iPhone.14.16.1.-.2023-10-11.at.22.43.38.mp4
Android