[Simple AA in NewDot] [HIGH] Improve how we handle auto-submission in NewDot

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.33-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tylerkaraszewski
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706118036323349

Action Performed:

Prerequisites:
use a collect policy
has scheduled submit enabled
has access to the isPolicyExpenseChatEnabled beta.

1. Request money from the collect workspace
2. Wait until the report is auto-submitted (i.e end of the day if set to Daily)
3. Observe the Submit button is still present on the report preview for the submitter, despite it being submitted.
4. Observe the submitted $x.xx via Scheduled Submit reportAction is not added to the expense report
5. Sign-in as the approver
6. Observe the workspace chat is not unread for the approver, the LHN does not contain a GBR green dot and the preview component doesn't contain an approve button.

Expected Result:

• On auto-submission, the the submit button should be removed.
• The NewDot reportAction for autoSubmission should be added to the chat from the submitter, the OldDot one from Concierge should not appear in NewDot.
• On auto-submission of the report, the workspace chat should be unread for the approver, the LHN chat row should have a GBR green dot and an approve button should be in the preview component.

Actual Result:

• The submit button is visible and clickable
• The NewDot reportAction is not added to the report, just the OldDot one.
• The approver isn't notified (chat is not unread, no GBR applied, no approve button on the preview)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?
All

Screenshots/Videos

Add any screenshot/video evidence

Submit button still visible:
https://github.com/Expensify/App/assets/43996225/f09c69e2-434c-4205-9949-1457cfee28fa

OldDot reportAction appearing not the NewDot one

Chat not unread, no GBR on the chat row in the LHN
To be added

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa9178aa3b2044ea
• Upwork Job ID: 1760318902746746880
• Last Price Increase: 2024-02-21

Issue Owner

Current Issue Owner: @Beamanator

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[trjExpensify]

Asking a few Qs: https://expensify.slack.com/archives/C049HHMV9SM/p1706123412357589?thread_ts=1706118036.323349&cid=C049HHMV9SM

[trjExpensify]

Tyler couldn't reproduce this issue. He did run into a different bug with not being able to delete an expense off a processing report, but that's totally different and being figured out over here.

[luacmartins]

I think the issue involves auto-submission. I've noticed that when the report has already been auto-submitted and then I try to submit again. @tylerkaraszewski, do you see any system messages when clicking into the report preview?

[trjExpensify]

Discussion for ref.

[trjExpensify]

Spruced this up in-line with the thread discussion. @mountiny are you taking this one?

[mountiny]

Yes, taking this! Seems like we do send the updates when this comes from harvesting too, will have to dig more

[trjExpensify]

The plot thickens.. Thanks!

[mountiny]

focusing on wave8 critical issue

[mountiny]

still focusing on ideal nav

[mountiny]

Still focusing on the ideal nav over this one, hopefully I can make progress on this one this week

[melvin-bot]

@trjExpensify @mountiny this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mountiny]

Still focusing on managing issues in wave8 and fire today

[melvin-bot]

@trjExpensify, @mountiny Eep! 4 days overdue now. Issues have feelings too...

[mountiny]

working at limited capacity - ill

[Beamanator]

PR for "Automatically submitted <amount> via delayed submission" created & ready for review ^ 👍

For auto-reimbursed, I see we use a report action "REIMBURSED" but that isn't used in NewDot yet 🤔 I see there's multiple ways we can create that action (the Reimburse flow in OldDot can lead to multiple variations of messages showing in OldDot).

Anyone know if we're supporting that report action elsewhere or if this is the first place we'll be supporting it? If this is the first place we're supporting it, I wonder if we should also consider how we show that report action in NewDot when manual reimbursement happens in OldDot 🤔

Edit: Asked in slack: https://expensify.slack.com/archives/C06ML6X0W9L/p1726005551948299

[trjExpensify]

For auto-reimbursed, I see we use a report action "REIMBURSED"

Are you saying on OldDot there's no distinct report action for a report paid via automation? 🤔

[Beamanator]

Are you saying on OldDot there's no distinct report action for a report paid via automation? 🤔

Bingo - same with auto-submitted - we reuse report actions that are for the same "action" but we just store specific data in the report actions indicating if the actions were taken manually or automatically - i can link some code if you're interested to see it 🙏

[Beamanator]

Ok so little status update on the auto-reimbursement side of things:

1. Auto reimbursing in NewDot currently goes through 3 different flows:
   1. Control policy on advanced approvals
      • For this, we had to update the auth token used for auto-reimbursing here
   2. Policies on instant submit
   3. All others
2. For control policy on advanced approvals, we should be good to go to start modifying the report action 👍
3. For Policies on Instant Submit we currently call PayMoneyRequest to do auto-payments
   • This command adds the NewDot-needed report action showing the report payments 👍
4. For "all other auto-submitting" we currently call ReimburseReport to do the auto-payments
   • Sadly, this command does NOT add the NewDot-needed "IOU -> Pay" report action, instead we only add the Reimbursed report action which we plan NOT to support in NewDot - so I need to figure out how to get the "IOU -> Pay" report action added in that flow.

Another point: How do we want to update the Report Preview here, when the report was paid automatically?

• AFAIK this is what it currently looks like after a report is reimbursed - are we ok with keeping this or do we want to try to make it clear that the report was paid automatically?:

[trjExpensify]

AFAIK this is what it currently looks like after a report is reimbursed - are we ok with keeping this or do we want to try to make it clear that the report was paid automatically?:

No change. 👍

[Beamanator]

That makes my life easy <3

[Beamanator]

Web-E & Auth PRs for auto-reimbursed copy in review ^

[Beamanator]

Web-E & Auth PRs are merged 👍 Two App PRs left:

1. Update "submitted by harvesting" report action copy #48939 - fixing some lint errors & waiting for C+ to finish testing (hard b/c it needs a report to be harvested)
2. Update "automatically paid" report action copy #49187 - getting close, but waiting for Web-E PR to get to staging/prod

[Beamanator]

Ooh @trjExpensify - @mollfpr had a good question: Should we also update the "Submit & Close" report action to read like this?

Shawn Borton
automatically submitted and closed $15.00 via delayed submission

Right now, I believe we don't even show that action in NewDot 😬 which seems like an oversight

Also, I just realized I haven't touched "auto approval" report actions yet, that will come after the above action updates

[trjExpensify]

Ooh @trjExpensify - @mollfpr had a good question: Should we also update the "Submit & Close" report action to read like this?

Hm, how does the OldDot one read? I'm not sure if we need to differentiate really, we don't call it "closed" in NewDot.

[Beamanator]

Hm, how does the OldDot one read?

We currently just add the "(automatically closed due to submit-only policy)" part in OldDot signifying it's submit & closed

• Report ID: 5885071015761121
• Report Owner: test.luthfi.002+48939+member@gmail.com (in case you want to see it yourself in supportal)

[trjExpensify]

Yeah, interesting. We don't use "closed" terminology, so it would be strange to randomly chuck that in here as it's a foreign concept to a NewDot user. I vote for just using this one for now:

automatically submitted $50.00 via delayed submission

The nextSteps illustrates that it's finished and there's nothing more to be done.

[JmillsExpensify]

100% agree with Tom.

[Beamanator]

Giggidy 👍 I 100.5% agree with Tom 👍

[Beamanator]

Okkkkkkkk little update:

1. Submitted via delayed submission should be in staging ✅
   • Oops i think i have 1 follow-up to do here
   • Maaybe here too in the same PR
   • Fixing both of ^ in Update "automatically approved" report action copy #49909
2. Paid via workspace rules is very slow to get reviewed 🟡
3. Submitted and closed (showing same as "Submitted via delayed submission") has PRs in review 🟡
   • 2nd PR in review: https://github.com/Expensify/Auth/pull/12645 ✅
4. Approved via workspace rules new & In Review 🟡
5. Same ^ for Forwarding needs a bit of work
   • Web-E & Auth PRs for auth token updates 🟡
   • Then PRs for updating the copy for Forwarded report action (added to this one) 🟡

[Beamanator]

Okkk another question about auto-approval 😬

• In OldDot, report action looks like: Concierge final approved this report on behalf of zz@gmail.com
• In NewDot, we'll make this read automatically approved $1.00 via workspace rules (detailed here)
• In NewDot, the Report Preview component (in a workspace chat) currently looks like:
  • 
  • Question: Do we want this to remain the same? Or include automatic / auto-approved somehow?

Oh and Question 2: Do we need to "optimistically" handle auto-approval & payment in this issue or can we do that in a new one / later? :D