-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "automatically paid" report action copy #49187
Conversation
…omaticallyPaidRACopy
…omaticallyPaidRACopy
…omaticallyPaidRACopy
Web-E PR is still not even on staging |
…omaticallyPaidRACopy
@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
FYI if contribs can easily set up bank accounts, this could be a good one to get C+ to review 🤷 |
…omaticallyPaidRACopy
Your New Help changes have been deployed to https://02b0e5cc.newhelp.pages.dev ⚡️ |
Ready for review |
🚀Deployed to NewHelp production! 🚀 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.0.43-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.0.43-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.43-6 🚀
|
Details
This PR helps us identify report actions where "payment" happened automatically (via workspace rules) vs manually by a human
Fixed Issues
$ Related to #35091
Tests
Manually approve all expenses over:
to$0.01
Direct
and check theManual Reimbursement
section - you should see thatReports above $100.00 are not reimbursed unless manually initiated.
Offline tests
N/A - auto-reimbursement requires being online
QA Steps
Same as above 👍
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop