Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "automatically paid" report action copy #49187

Merged
merged 14 commits into from
Sep 30, 2024

Conversation

Beamanator
Copy link
Contributor

@Beamanator Beamanator commented Sep 13, 2024

Details

This PR helps us identify report actions where "payment" happened automatically (via workspace rules) vs manually by a human

Fixed Issues

$ Related to #35091

Tests

  1. Create a Collect policy, on Instant submit, with Submit & Approve enabled
  2. In OldDot, in the workspace Members tab, set Manually approve all expenses over: to $0.01
  3. In OldDot, in the workspace Reimbursement tab, set reimbursement to Direct and check the Manual Reimbursement section - you should see that Reports above $100.00 are not reimbursed unless manually initiated.
  4. Create a withdrawal-ready bank account for the workspace
  5. Create a deposit-ready bank account for the workspace owner (personal bank account shouldn't be linked to the workspace
  6. In OldDot, as the workspace owner, create a report & add an expense of $1, then approve the report
  7. Now open that report in NewDot and verify you see the new "automatically paid" report action copy:
    • Screenshot 2024-09-25 at 5 21 53 PM
  8. Now in NewDot, go to the workspace, submit an expense, then approve that report
  9. Verify that report also gets auto-reimbursed & shows the new report action copy:
    • Screenshot 2024-09-25 at 5 23 17 PM
  • Verify that no errors appear in the JS console

Offline tests

N/A - auto-reimbursement requires being online

QA Steps

Same as above 👍

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari Screenshot 2024-09-25 at 5 23 17 PM Screenshot 2024-09-25 at 5 21 53 PM
MacOS: Desktop

@Beamanator
Copy link
Contributor Author

Web-E PR is still not even on staging

@Beamanator Beamanator marked this pull request as ready for review September 25, 2024 23:24
@Beamanator Beamanator requested a review from a team as a code owner September 25, 2024 23:24
@melvin-bot melvin-bot bot requested review from tylerkaraszewski and removed request for a team September 25, 2024 23:25
Copy link

melvin-bot bot commented Sep 25, 2024

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Beamanator
Copy link
Contributor Author

FYI if contribs can easily set up bank accounts, this could be a good one to get C+ to review 🤷

Copy link

cloudflare-workers-and-pages bot commented Sep 28, 2024

Deploying newhelp with  Cloudflare Pages  Cloudflare Pages

Latest commit: c88fcb6
Status:🚫  Build failed.

View logs

Copy link
Contributor

github-actions bot commented Sep 28, 2024

Your New Help changes have been deployed to https://02b0e5cc.newhelp.pages.dev ⚡️

help/index.markdown Outdated Show resolved Hide resolved
@Beamanator
Copy link
Contributor Author

Ready for review

@tylerkaraszewski tylerkaraszewski merged commit 98ac9ac into main Sep 30, 2024
16 of 17 checks passed
@tylerkaraszewski tylerkaraszewski deleted the beaman-updateAutomaticallyPaidRACopy branch September 30, 2024 22:47
Copy link
Contributor

🚀Deployed to NewHelp production! 🚀

(View deploy workflow run)

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.0.43-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

1 similar comment
Copy link
Contributor

github-actions bot commented Oct 2, 2024

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.0.43-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Copy link
Contributor

github-actions bot commented Oct 3, 2024

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.43-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants