Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-07] [HOLD for payment 2024-02-07] Send Money - Send option doesn't work, can't choose a receiver, an error in the console #35337

Closed
6 tasks done
kbecciv opened this issue Jan 29, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Jan 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.33-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in with any account
  3. Go to FAB button -> Send money -> Enter an amount -> Next
  4. Choose any user

Expected Result:

The user is selected and you can continue the process

Actual Result:

Can't choose any user for sending money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6360160_1706566661615.bandicam_2024-01-29_23-11-50-980.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 29, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 29, 2024

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Jan 29, 2024

We think that this bug might be related to #vip-bills
CC @davidcardoza

@paultsimura
Copy link
Contributor

This is a regression from #34947
The ROUTES.MONEY_REQUEST_CONFIRMATION no longer exists:

Navigation.navigate(ROUTES.MONEY_REQUEST_CONFIRMATION.getRoute(moneyRequestType, reportID));

@francoisl
Copy link
Contributor

Huh yeah weird.

I still see at least 13 occurrences of ROUTES.MONEY_REQUEST_CONFIRMATION on main at the moment. @DylanDylann @NikkiWines can you confirm if this is on purpose or an oversight?

@francoisl
Copy link
Contributor

There might be a new route we can use instead, but we'd need to retest everything, so for now it might be quicker to revert #34947 - just submitted a PR.

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Jan 30, 2024
@DylanDylann
Copy link
Contributor

DylanDylann commented Jan 30, 2024

@francoisl This crash is only temporary because we haven't migrated the rest of this refactor cleanup yet. I will create a new PR to temporarily fix those places to use the new route

@francoisl francoisl added Daily KSv2 and removed Hourly KSv2 labels Jan 30, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jan 31, 2024
@melvin-bot melvin-bot bot changed the title Send Money - Send option doesn't work, can't choose a receiver, an error in the console [HOLD for payment 2024-02-07] Send Money - Send option doesn't work, can't choose a receiver, an error in the console Jan 31, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024
Copy link

melvin-bot bot commented Jan 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-07. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 31, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-02-07] Send Money - Send option doesn't work, can't choose a receiver, an error in the console [HOLD for payment 2024-02-07] [HOLD for payment 2024-02-07] Send Money - Send option doesn't work, can't choose a receiver, an error in the console Jan 31, 2024
Copy link

melvin-bot bot commented Jan 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-07. 🎊

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Feb 6, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot removed the Overdue label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants