Remove MoneyRequestConfirmPage #34947

DylanDylann · 2024-01-23T06:59:01Z

Details

Remove MoneyRequestConfirmPage as a part of #29107

Fixed Issues

$ #34615
PROPOSAL: #34615 (comment)

Tests

Create a new request
Verify that the request confirmation page works well

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a new request
Verify that the request confirmation page works well

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

a3.mp4

Android: mWeb Chrome

c.mp4

iOS: Native

i3.mp4

iOS: mWeb Safari

s.mp4

MacOS: Chrome / Safari

w.mp4

MacOS: Desktop

d.mp4

melvin-bot · 2024-01-23T06:59:06Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-01-23T07:00:53Z

src/ROUTES.ts

-    MONEY_REQUEST_CONFIRMATION: {
-        route: ':iouType/new/confirmation/:reportID?',
-        getRoute: (iouType: string, reportID = '') => `${iouType}/new/confirmation/${reportID}` as const,
-    },
    MONEY_REQUEST_DATE: {


This Route still be used in many places like MoneyRequestCategoryPage, MoneyRequestTagPage,... But all these places will be removed in this epic. So that I removed this route in this PR

I see. We should change all of these places to navigate to the new route.

OK so we are not using those components and they will be removed as well. We are good here.

This caused a regression. The Send money flow still uses this route.

Screen.Recording.2024-01-29.at.12.39.40.AM.mov

This crash is only temporary because we haven't migrated the rest of this refactor cleanup yet. I will create a new PR to temporarily fix those places to use the new route

DylanDylann · 2024-01-23T07:02:24Z

we also don't need to update the route for new component: IOURequestStepConfirmation as point 2 in my proposal because with the confirmation page we only can create and can't edit

DylanDylann · 2024-01-23T07:03:49Z

Just a note: Before I created this PR, the new component: IOURequestStepConfirmation was already used in our App instead of MoneyRequestConfirmationPage

DylanDylann · 2024-01-23T07:04:45Z

src/pages/iou/request/step/IOURequestStepConfirmation.js

@@ -86,6 +81,7 @@ function IOURequestStepConfirmation({
    const {translate} = useLocalize();
    const {windowWidth} = useWindowDimensions();
    const {isOffline} = useNetwork();
+    const personalDetails = usePersonalDetails() || CONST.EMPTY_OBJECT;


All changes in this file come from #31076 (follow guideline: Replace all uses of the Old Component with the New Component)

parasharrajat · 2024-01-24T14:59:56Z

Screenshots

🔲 iOS / native

Screen.Recording.2024-01-25.at.1.19.25.PM.mov

🔲 iOS / Safari

Screen.Recording.2024-01-24.at.8.39.43.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2024-01-24.at.8.36.53.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2024-01-24.at.8.30.46.PM.mov

🔲 Android / Chrome

Screen.Recording.2024-01-24.at.8.34.52.PM.mov

🔲 Android / native

Screen.Recording.2024-01-25.at.1.47.34.PM.mov

parasharrajat · 2024-01-24T16:19:42Z

@DylanDylann Can you please merge main? I am facing Android build issues. Also, attach Android and iOS videos.

DylanDylann · 2024-01-24T17:28:34Z

It maybe take a bit time to run IOS/Android on my local machine. Sorry for my missing

DylanDylann · 2024-01-25T06:07:40Z

@parasharrajat I cleared all node modules and re-installed everything 😄. It worked for me and added full videos

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

NikkiWines

👍

VickyStash · 2024-01-26T11:32:46Z

Hello @DylanDylann @parasharrajat, I'm working on TS migration of IOU.js file, and after merging the latest main I have TS error cause MONEY_REQUEST_CONFIRMATION doesn't exist in ROUTES. First case, second case, maybe you have any recommendations on what can I do? Or maybe you know if I can remove this parts from the code or when will it be totally removed?

DylanDylann · 2024-01-26T11:36:45Z

@VickyStash navigateToNextPage function only be used in NewRequestAmountPage and NewDistanceRequestPage. But NewDistanceRequestPage will be removed in here #34610, NewRequestAmountPage will be removed in here #34614
It means that navigateToNextPage function is no longer used.

VickyStash · 2024-01-26T11:43:03Z

@DylanDylann So how do you think is it okay to remove navigateToNextPage function and its usage during the TS migration of IOU file or should I put it on hold till NewRequestAmountPage and NewDistanceRequestPage will be removed?

DylanDylann · 2024-01-26T11:46:26Z

@VickyStash NewRequestAmountPage and NewDistanceRequestPage will be removed soon. I think you should ask an internal engineer for the final decision

VickyStash · 2024-01-26T11:57:35Z

@NikkiWines, Could you please provide your opinion on this one?
To sum up the context: I'm working on TS migration of IOU.js file, and after merging the latest main I have TS error cause MONEY_REQUEST_CONFIRMATION doesn't exist in ROUTES. The problem appears in the navigateToNextPage function, which is used only in NewRequestAmountPage and NewDistanceRequestPage pages, which are going to be removed soon. How do you think is it okay to remove navigateToNextPage function and its usage during the TS migration of IOU file or should I put it on hold till NewRequestAmountPage and NewDistanceRequestPage will be removed?

parasharrajat · 2024-01-26T14:03:23Z

Hey @VickyStash Could you please raise this on Slack?

OSBotify · 2024-01-29T19:25:21Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2024-01-31T02:32:12Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Remove MoneyRequestConfirmPage

b97e348

DylanDylann requested a review from a team as a code owner January 23, 2024 06:59

melvin-bot bot requested review from parasharrajat and removed request for a team January 23, 2024 06:59

DylanDylann commented Jan 23, 2024

View reviewed changes

DylanDylann force-pushed the fix/34615 branch from f3fdc50 to b97e348 Compare January 23, 2024 07:48

This comment was marked as outdated.

Sign in to view

DylanDylann mentioned this pull request Jan 23, 2024

[HOLD for payment 2024-04-15] [$250] Remove MoneyRequestConfirmPage.js and copy any changes since Nov 27 into IOURequestStepConfirmation.js #34615

Closed

merge main

3cb3b9a

parasharrajat approved these changes Jan 25, 2024

View reviewed changes

melvin-bot bot requested a review from NikkiWines January 25, 2024 07:51

NikkiWines approved these changes Jan 25, 2024

View reviewed changes

NikkiWines merged commit 0d2f01c into Expensify:main Jan 26, 2024
17 checks passed

github-actions bot mentioned this pull request Jan 29, 2024

Deploy Checklist: New Expensify 2024-01-29 #35328

Closed

paultsimura mentioned this pull request Jan 29, 2024

[HOLD for payment 2024-02-07] [HOLD for payment 2024-02-07] Send Money - Send option doesn't work, can't choose a receiver, an error in the console #35337

Closed

6 tasks

francoisl mentioned this pull request Jan 30, 2024

[CP Staging] Revert "Remove MoneyRequestConfirmPage" #35348

Merged

48 tasks

DylanDylann mentioned this pull request Jan 30, 2024

Fix/34609: Remove old description page #35137

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove MoneyRequestConfirmPage #34947

Remove MoneyRequestConfirmPage #34947

DylanDylann commented Jan 23, 2024 •

edited

Loading

melvin-bot bot commented Jan 23, 2024

DylanDylann Jan 23, 2024

parasharrajat Jan 24, 2024

parasharrajat Jan 24, 2024

s77rt Jan 28, 2024 •

edited

Loading

DylanDylann Jan 29, 2024

DylanDylann commented Jan 23, 2024

DylanDylann commented Jan 23, 2024

DylanDylann Jan 23, 2024

This comment was marked as outdated.

parasharrajat commented Jan 24, 2024 •

edited

Loading

parasharrajat commented Jan 24, 2024 •

edited

Loading

DylanDylann commented Jan 24, 2024

DylanDylann commented Jan 25, 2024 •

edited

Loading

parasharrajat left a comment

NikkiWines left a comment

VickyStash commented Jan 26, 2024

DylanDylann commented Jan 26, 2024

VickyStash commented Jan 26, 2024

DylanDylann commented Jan 26, 2024

VickyStash commented Jan 26, 2024

parasharrajat commented Jan 26, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 31, 2024

Remove MoneyRequestConfirmPage #34947

Remove MoneyRequestConfirmPage #34947

Conversation

DylanDylann commented Jan 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 23, 2024

DylanDylann Jan 23, 2024

Choose a reason for hiding this comment

parasharrajat Jan 24, 2024

Choose a reason for hiding this comment

parasharrajat Jan 24, 2024

Choose a reason for hiding this comment

s77rt Jan 28, 2024 • edited Loading

Choose a reason for hiding this comment

DylanDylann Jan 29, 2024

Choose a reason for hiding this comment

DylanDylann commented Jan 23, 2024

DylanDylann commented Jan 23, 2024

DylanDylann Jan 23, 2024

Choose a reason for hiding this comment

This comment was marked as outdated.

parasharrajat commented Jan 24, 2024 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat commented Jan 24, 2024 • edited Loading

DylanDylann commented Jan 24, 2024

DylanDylann commented Jan 25, 2024 • edited Loading

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

NikkiWines left a comment

Choose a reason for hiding this comment

VickyStash commented Jan 26, 2024

DylanDylann commented Jan 26, 2024

VickyStash commented Jan 26, 2024

DylanDylann commented Jan 26, 2024

VickyStash commented Jan 26, 2024

parasharrajat commented Jan 26, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 31, 2024

DylanDylann commented Jan 23, 2024 •

edited

Loading

s77rt Jan 28, 2024 •

edited

Loading

parasharrajat commented Jan 24, 2024 •

edited

Loading

parasharrajat commented Jan 24, 2024 •

edited

Loading

DylanDylann commented Jan 25, 2024 •

edited

Loading