[HOLD for payment 2024-03-07] [$500] IOU - Keyboard comes out from right to left on participant screen

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app and log in
2. Tap the FAB > Request money
3. Select any option
4. Enter the amount if it is a manual request
5. Proceed to the participant screen

Expected Result:

The keyboard comes out from bottom to top

Actual Result:

The keyboard comes out from the right to the left. In other areas, for example, in search or start chat it appears from bottom to top

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393521_1709000900338.IMG_5387.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012f111bd2927acf29
• Upwork Job ID: 1762307582490816512
• Last Price Increase: 2024-02-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012f111bd2927acf29

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[lanitochka17]

Production:

IMG_5373.MP4

[youssef-lr]

I think it might be coming from here, cc @mountiny @hannojg

[bi-kash]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The current issue revolves around the animation of the keyboard, which is currently sliding in from the right instead of the desired bottom sliding motion.

What is the root cause of that problem?

The root cause of the problem lies in the existing animation code located in src/libs/Navigation/AppNavigator/modalStackNavigatorOptions/index.native.ts. The animation property is set to 'slide_from_right', causing the keyboard to slide in from the right.

const defaultSubRouteOptions: NativeStackNavigationOptions = {
    headerShown: false,
    animation: 'slide_from_right',
};

What changes do you think we should make in order to solve the problem?

To rectify the issue, a correction in the animation property is needed. The animation should be adjusted to 'slide_from_bottom' to ensure the keyboard slides in from the bottom.

const defaultSubRouteOptions: NativeStackNavigationOptions = {
    headerShown: false,
    animation: 'slide_from_bottom',
};

What alternative solutions did you explore? (Optional)

NA

[youssef-lr]

Thanks for the proposal, let's wait to hear from @hannojg if this is intended or not. I think this can be fixed by the original author as it's not technically a bug, just a choice we made.

[ghost]

I don't think it is a bug, it is more like a preference.

[puneetlath]

Thanks for the proposal, let's wait to hear from @hannojg if this is intended or not. I think this can be fixed by the original author as it's not technically a bug, just a choice we made.

Going to remove the deploy blocker label, given this comment.

[DylanDylann]

@youssef-lr @MonilBhavsar The offending PR is reverted and I can't reproduce this issue on the latest main

Screen.Recording.2024-02-28.at.14.07.44.mov

Let's close this one

[MonilBhavsar]

Yes, This is resolved now. So closing

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• revert: native stack #37305

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment (Needs manual offer from BZ)