Migrate E/App to use PlatformStackNavigation

[chrispader]

@mountiny @ishpaul777 @chiragsalian

Details

This PR migrates the App to use PlatformStackNavigation types and navigator components implemented in #37891

Fixed Issues

$ #37891
PROPOSAL: #37891 (comment)

Tests

• Open app

• press on search filed

• be sure that:

  • screen transition is from left to right (Android/iOS/mWeb)
  • drawer tranistion is from left to right + content behind drawer is still visible (web)
  • screen search can be loaded (i. e. it's not infinite loading) -> [HOLD for payment 2024-03-07] [Android] infinite loading search screen #37156

• close screen

  • on iOS test that it can be dismissed via gesture from right to left [HOLD for payment 2024-03-14] Gesture to hide the search page should be right to left  #37354 and back button
  • on mWeb iOS it can be dismissed via gesture from left to right and back button
  • on Android can be closed via system gestures and back button
  • on web can be closed via back button

• open any chat

• tap on composer

• go to previous screen

  • on iOS/mWeb iOS do it via gesture from left to right and back button
  • on Android/web do it via back button

• be sure there is no keyboard jumps on previous screen -> [HOLD for payment 2024-10-17] [HOLD for payment 2024-06-06] [HOLD #37891] Keyboard jumps around when swiping back from chat to LHN with gesture  #37923

• open chat again

• tap on task

• tap on Assignee

• be sure there is no infinite loading for the screen -> [HOLD for payment 2024-03-07] Android - Task-Tapping assignee shows infinite loading page #37252

• go back to task

• tap on Title

• be sure keyboard is opened automatically -> [HOLD for payment 2024-03-07] [$500] Android - Task - Keyboard does not open after selecting task title #37273

• go back to main page

• tap on user avatar (to open Account settings)

• tap on wallet, tap on "Add bank account"

• tap on "Debit card"

• be sure keyboard gets opened automatically -> [HOLD for payment 2024-03-07] [$500] Android - Wallet - The keyboard does not open automatically when the debit card is opened #37325

• go back to main page

• press "+" in TabBar

• tap Request Money

• enter any amount

• press "Next"

• be sure that on participant screen keyboard appears from the bottom -> [HOLD for payment 2024-03-07] [$500] IOU - Keyboard comes out from right to left on participant screen #37257

• Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[srikarparsi]

Re-assigning to @chiragsalian and @mountiny for review since it looks like they have more context.

[chrispader]

@mountiny or @chiragsalian please from now on create ad-hoc builds from here. I fixed all remaining reported errors yesterday, so we can probably trigger a new build already.

[chrispader]

The ad-hoc iOS build fail is also going to be related to the patch from #49936

[ishpaul777]

@mountiny Please run adhoc builds here when you have a moment, i plan to work on testing this fully today

[mountiny]

Running

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	https://49937.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

---

👀 View the workflow run that generated this build 👀

[chrispader]

@mountiny Please run adhoc builds here when you have a moment, i plan to work on testing this fully today

The PR didn't have the changes to the react-native-vision-camera patches up until now. Please trigger another set of ad-hoc builds :)

[mountiny]

https://github.com/Expensify/App/actions/runs/11179336829

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49937/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49937/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49937/NewExpensify.dmg	https://49937.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[mountiny]

Bug on the workspace page

[mountiny]

@chrispader Looking great! I think there are two things I have noticed:

1. There is a noticeable delay of idk 0.5s after clicking on the chat row for the animation to start
2. The chat finder modal is opening from the bottom, we want to keep the same animation we have now in main - animating from left

[ishpaul777]

commenting so this shows on my k2 for easy access

[chrispader]

Bug on the workspace page

@chrispader Looking great! I think there are two things I have noticed:

1. There is a noticeable delay of idk 0.5s after clicking on the chat row for the animation to start
2. The chat finder modal is opening from the bottom, we want to keep the same animation we have now in main - animating from left

@mountiny Both bugs are fixed!

I couldn't really see a difference between Stack navigator and Native-Stack while testing in this PR: (you meant when clicking on an item in the Sidebar right?)

Stack

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-06.at.17.38.30.mp4

Native Stack

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-06.at.20.09.51.mp4

[chrispader]

I will be OOO the next week, but i will hand this over to one of our other Margelo engineers. If there are any urgent issues i can also help with that, but i'm not gonna be on my Macbook unfortunately

[ishpaul777]

I am now available for around ~2 hours i'll pull and start testing this locally

[github-actions]

🚧 @mountiny has triggered a test build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49937/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49937/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49937/NewExpensify.dmg	https://49937.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[chrispader]

@chrispader web is just stuck on loading screen for me

Cannot reproduce this. On iOS mWeb and macOS web the last ad-hoc builds load just fine for me

(maybe this was caused by the staging server being down recently?)

[ishpaul777]

Checked with latest build, it works fine now 👍

[ishpaul777]

Opening threads from specific room chat( https://49937.pr-testing.expensify.com/r/6776919265133947) seems to be crashing the app

Screen.Recording.2024-11-21.at.10.53.15.PM.mov

[mountiny]

Can you merge main for a new build? might be coming from that. also can you start checking the Prettier and ESLint checks (unless its the useOnyx migration) so we can have this ready to merge

[ishpaul777]

@mountiny can you trigger build again please

[ishpaul777]

with this build #49937 (comment), Ios App is also crashing randomly, No specific steps just happened 2 times while using the app after clear cache and restart.

Edit: i got this crash on Staging App also, so not related to this PR

[chrispader]

Can you merge main for a new build? might be coming from that. also can you start checking the Prettier and ESLint checks (unless its the useOnyx migration) so we can have this ready to merge

Merged main! We still rely on the changes from #52392 to fix the "Android screen cut off" issue, so i guess we should better hold for that PR?

ESLint and Prettier workflows look good!

[github-actions]

🚧 @mountiny has triggered a test build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49937/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49937/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49937/NewExpensify.dmg	https://49937.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[ishpaul777]

Sadly this is producable for me again #49937 (comment)

screen is half cut off when navigating to details page when keyboard is open

Also similar issue was producable once just on a different screen (setting > Wallet > Enable Wallet) but i could not record it happening

Screen.Recording.2024-11-22.at.8.04.56.PM.mov

Other than this i played around the app everything looks and feels good to me 👌

[chrispader]

Sadly this is producable for me again #49937 (comment)

screen is half cut off when navigating to details page when keyboard is open

I reverted the merge of the Android edge-to-edge PR, so this is expected atm. I'm currently investigating whether we just need a part of the changes from the PR or if we should hold on the PR to get merged first. We definitely don't want all the changes from the other PR being added here.

@ishpaul777 if you didn't find any other bugs, we might have fixed all current problems for now. I will try to get the "Android issue screen cut-off issue" sorted out in the next hour or so

[ishpaul777]

Also please check if you can reproduce #49937 (comment), because this is also consistently reprocable for me.

[chrispader]

Ok, i can confirm that #52392 fixes the problem on Android. @mountiny do you also think we should therefore HOLD for that PR?

[github-actions]

🚧 @mountiny has triggered a test build. You can view the workflow run here.

[chrispader]

Just merged the changes from main with the Android edge-to-edge changes into this PR, so the Android issue should be fixed.

The last issue (that i know of) that i'm currently working on is this: #49937 (comment)

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49937/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49937/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49937/NewExpensify.dmg	https://49937.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[mountiny]

@ishpaul777 can you please retest the keyboard issue on android?

[ishpaul777]

On it 👀

[ishpaul777]

@mountiny @chrispader Issue is fixed 🎉

[mountiny]

yay