[HOLD for payment 2024-05-03] [Guided Setup Stage 2] Use new CompleteGuidedSetup API to create tasks and messages (Phase 1)

[francoisl]

Part of the "wave-collect – Build Stage 2 of Guided Setup" project

Main issue: https://github.com/Expensify/Expensify/issues/356685
Doc section: https://docs.google.com/document/d/10bhCv6XtzzqEZQ9tzxFwAz4lowgjOhsFqz13BMq6Iu4/edit#heading=h.f1df48czr1vu
Project: https://github.com/orgs/Expensify/projects/129

Feature Description

• Use the new API command CompleteGuidedSetup and pass new tasks and message's optimistic data, on behalf of Concierge
• Redirect user to root screen (doc section)

cc @barttom

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b15d65c2978eba6c
• Upwork Job ID: 1770904809640124416
• Last Price Increase: 2024-03-21

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b15d65c2978eba6c

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @alitoshmatov (Internal)

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[barttom]

Hello! I'm Bartek from Callstack, an expert contributor group, and I would like to work on this issue.

[joekaufmanexpensify]

@barttom is there an ETA for the PR here?

[barttom]

@barttom is there an ETA for the PR here?

@joekaufmanexpensify
There is no set date for that, however I need 5-6 days to finish that.

to start working on that I need merged stage 1 (in review) and new API command (in progress)

[joekaufmanexpensify]

Sounds good. TY!

[joekaufmanexpensify]

Looks like PR is now WIP

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[rezkiy37]

Updates:

1. Minor fixes of onboarding messages and text.
2. Integrated a CompleteGuidedSetupParams type for the API command.
3. Integrated a setDisplayName function to update the user's names locally without sending a request to the backend.
4. Updated a couple of functions in ReportUtils.ts to support new passed arguments.
5. Improved the completeOnboarding function to:
   a. Pass all necessary optimistic data.
   b. Hide tasks in LHN.
   c. Generate a top-mention comment to highlight the Concierge chat.
   d. Other changes.

Note: All changes have been pushed to the PR.

Plans for tomorrow:

1. Fix the ordering of actions in the Concierge chat.
2. Fix a mention message preview to exclude an email domain.

Details

Flow.1.mp4

[rezkiy37]

Updates:

1. Fixed the ordering of actions in the Concierge chat.
2. Fixed a mention message preview to exclude an email domain.
3. Changed the ordering of the pages.
4. Added task replies optimistically.
5. Fixed text escaping.
6. Prettified codebase.
7. Other changes.

We can do the first review stage for the draft PR. I still need to test on all platforms.

Videos

Flow.1.mp4

Updated.nav.mp4

[joekaufmanexpensify]

@rezkiy37 is there an ETA to have a PR in review here?

[rezkiy37]

@rezkiy37 is there an ETA to have a PR in review here?

Yes, there is - today. More context in Slack.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Onboarding fixes #40688

If no regressions arise, payment will be issued on 2024-05-03. 🎊

For reference, here are some details about the assignees on this issue:

• @barttom does not require payment (Contractor)
• @rezkiy37 does not require payment (Contractor)
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[rushatgabhane]

@joekaufmanexpensify could you please assign me this issue for C+ review #40688 (comment)

[joekaufmanexpensify]

Payment due later this week!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @barttom is from an agency-contributor and not due payment
• Reviewer: @rayane-djouah - $500 via Upwork.
• Contributor: @rezkiy37 is from an agency-contributor and not due payment

BugZero Checklist (@joekaufmanexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1770904809640124416/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[rayane-djouah]

• [@rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Regression test proposal

With the creation of a workspace (Track business expenses, Manage my team’s expenses)

1. Open the app with an entire new user.
2. Verify that the "What do you want to do today?" modal appears.
3. Verify that the background of the modal is translucent for web and desktop.
4. Select Track business expenses or Manage my team’s expenses purpose.
5. Click on "Continue".
6. Verify that the "Where do you work?" modal appears.
7. Enter any names.
8. Click on "Continue".
9. Verify that the "What’s your name?" modal appears.
10. Enter any name.
11. Click on "Continue".
12. Verify that the app redirects to the home page.
13. Open the Concierge chat.
14. Verify that the app has generated a welcome message and tasks in Concierge chat.
15. Verify that the app has created a workspace with the previously entered name.
16. Verify that the "Create a workspace" task is marked as complete.
17. Verify that attachment videos are replaced with videos, once the backend sends an update.

Without the creation of a workspace (others)

1. Open the app with an entire new user.
2. Verify that the "What do you want to do today?" modal appears.
3. Verify that the background of the modal is translucent for web and desktop.
4. Select any purpose other than (Track business expenses, Manage my team’s expenses).
5. Click on "Continue".
6. Verify that the "What’s your name?" modal appears.
7. Enter any names.
8. Click on "Continue".
9. Verify that the app redirects to the home page.
10. Open the Concierge chat.
11. Verify that the app has generated a welcome message and tasks in Concierge chat.
12. Verify that attachment videos are replaced with videos, once the backend sends an update.

• Do we agree 👍 or 👎

[joekaufmanexpensify]

@francoisl do we need to add adhoc regression tests here? i see a detailed set of manual testing instructions in the design doc, and thought we'd probably pass those all along to applause at once.

[joekaufmanexpensify]

still pending more discussion

[joekaufmanexpensify]

Hmm, I see two PRs linked to this issue (#39951 and #40688).

I think the former is actually the one we want to issue payment for here, and then the latter payment should be handled here (especially since they have separate C+).

Going to align on this in slack

[joekaufmanexpensify]

Discussing

[francoisl]

do we need to add adhoc regression tests here? i see a detailed set of manual testing instructions in the design doc, and thought we'd probably pass those all along to applause at once.

Yeah it would be great to add. The steps in the design doc were more manual test steps, to make sure everything's implemented as intended.
We're also going to start using the system DM soon for the intro tasks, so we'll need to make a few changes to the steps above. For now I'd recommend holding on adding the regression tests.

[joekaufmanexpensify]

Sounds good! I will hold for now.

[joekaufmanexpensify]

We landed on paying out only #39951 in this issue.

#40688 is going to be paid out in #40725 . As such, @rushatgabhane I am unassigning you here, since the payment for your PR will be handled in that other issue. LMK if you have any questions.

[joekaufmanexpensify]

That means only payment we need to make here is $500 to @rayane-djouah for C+ review via Upwork.

[joekaufmanexpensify]

OG job closed, so opened a new one: https://www.upwork.com/jobs/~019187a065e7cd3e15

[joekaufmanexpensify]

@rayane-djouah offer sent for $250!

[rayane-djouah]

@joekaufmanexpensify, Offer accepted. Thank you! I have one question: since this issue was created before the new payment structure, should it still maintain $500?

[joekaufmanexpensify]

Yes, good call! Payment here should be $500 since this opened before the base payment changed.

[joekaufmanexpensify]

@rayane-djouah $500 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set, thanks everyone!