[Awaiting C+ Steps] [Guided Setup Stage 2] Add support for read-only messages (Phase 2)

[francoisl]

Part of the "wave-collect – Build Stage 2 of Guided Setup" project

Main issue: https://github.com/Expensify/Expensify/issues/356685
Doc section: https://docs.google.com/document/d/10bhCv6XtzzqEZQ9tzxFwAz4lowgjOhsFqz13BMq6Iu4/edit#heading=h.9c9l6vfd8y0n
Project: https://github.com/orgs/Expensify/projects/129

Feature Description

Use the new permissions = ["read"] prop on report objects to hide the composer. When the system account ("Expensify persona") is the only other participant of the report, display a static message instead of the composer instead

cc @barttom

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b804c59943f9fb25
• Upwork Job ID: 1770905188139683840
• Last Price Increase: 2024-03-21

Issue Owner

Current Issue Owner: @hungvu193

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b804c59943f9fb25

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rojiphil (Internal)

[melvin-bot]

Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[barttom]

Hello! I'm Bartek from Callstack, an expert contributor group, and I would like to work on this issue.

[rojiphil]

@twisterdotcom Can you please grant me access to this document mentioned in OP? I have requested now. My email is rojiphil@gmail.com

[twisterdotcom]

Ah I see we can share design docs for C+: https://stackoverflowteams.com/c/expensify/questions/11623/11624#11624.

[twisterdotcom]

Just asking in Slack whether it's best to share with individuals or with all C+ via contributor_plus@expensify.com: https://expensify.slack.com/archives/C01SKUP7QR0/p1711544698772059

[twisterdotcom]

Okay shared only as a commenter rojiphil@gmail.com / @rojiphil.

[twisterdotcom]

How are we doing here @barttom?

[barttom]

@twisterdotcom Basically, it's finished, but we are not able to test it without manual code changes and currently, I'm working on #38771

We can test it when #38769 has been finished.
Then I can implement this in. the app and I'll send this one to review with #38774 - that will allow us to test this issue.

[twisterdotcom]

Nice! Thanks

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[twisterdotcom]

How is this PR going? We just held on #38769 right?

[rezkiy37]

How is this PR going? We just held on #38769 right?

I prepared the draft PR. Once #38769 is merged, I can start to test immediately.

[rezkiy37]

Guys, should we block those actions for read-only chats?

cc @francoisl @twisterdotcom @mountiny

[mountiny]

Yeah I feel like we should not allow creating threads there

[rezkiy37]

The issue is not on hold anymore. But the PR for this issue is on hold and waiting for #40678.

[rezkiy37]

Hey!
I just wanted to let you know about my vacation for next week. I will be back on 06.05.2024. Meanwhile, I asked @waterim to take over this issue.
See you soon!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Support read only messages #40010

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment (Needs manual offer from BZ)
• @barttom does not require payment (Contractor)
• @rezkiy37 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rojiphil] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[hungvu193]

@mountiny Since I reviewed the PR, can you assign me to this issue please? Thank you 😄

[twisterdotcom]

Hey, sorry just getting to this - apologies I was out last week. I only need to pay @rojiphil and @hungvu193 via Upwork, for $250 each right? Or did @rojiphil not review an associated PR, but @hungvu193 did?

[hungvu193]

Hey, sorry just getting to this - apologies I was out last week. I only need to pay @rojiphil and @hungvu193 via Upwork, for $250 each right? Or did @rojiphil not review an associated PR, but @hungvu193 did?

I think it's just me because I reviewed the PR.

[rojiphil]

Hey, sorry just getting to this - apologies I was out last week. I only need to pay @rojiphil and @hungvu193 via Upwork, for $250 each right? Or did @rojiphil not review an associated PR, but @hungvu193 did?

@twisterdotcom That's correct. No payment for me as I did not review the PR.

[twisterdotcom]

Payment Summary:

• @hungvu193 paid $250 here (C+)
• @barttom does not require payment (Contractor)
• @rezkiy37 does not require payment (Contractor)

[twisterdotcom]

@hungvu193 - want to propose the regression steps here?

[hungvu193]

@hungvu193 - want to propose the regression steps here?

This is new feature so I don't think we need regression test here

[twisterdotcom]

Why would we not create regression steps for a new feature though? It is part of the normal new feature checklist: #38773 (comment)

[hungvu193]

Why would we not create regression steps for a new feature though? It is part of the normal new feature checklist: #38773 (comment)

Sorry I missed it 🥲

[hungvu193]

Regression test:

1. Complete the onboarding flow.
2. Open the chat.
3. Verify that the composer is hidden.
4. Verify that a new footer component exists.
5. Open a task report.
6. Verify that the composer is hidden.
7. Verify that a new footer component exists.
8. Verify that you cannot complete or delete a task.

Do we 👍 or 👎 ?