[$500] Task - Chat is not scrolled to bottom when edit a task #38833

lanitochka17 · 2024-03-22T20:05:29Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

**Version Number:**1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/runs/view/20318&group_by=cases:section_id&group_order=asc&group_id=291935
Email or phone of affected tester (no customers): shussain+web@applausemail.com
Issue reported by: Applause - Internal Team

Action Performed:

Open an existing chat
Click the '+' > Assign Task
Give the task as Title, Description and Assignee > Confirm Task
Click on the created task in the chat
Change the name > Save
Verify there's an audit trail of the change in the chat thread
Make more changes to the task (you can change the title, description, assignee) > click Save
Verify that eventually the chat isn't fully scrolled to the bottom of last message (or audit trail change)

Expected Result:

Chat should always scroll to the bottom of the last message ( you should see the last message after making a change)

Actual Result:

After making multiple edits to a task, the chat thread isn't scrolled to the bottom.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6423531_1711133132795.2024-03-22_23-44-10.mp4

2024-03-26_12-57-52.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d64def74796adc96
Upwork Job ID: 1772488534557900800
Last Price Increase: 2024-03-26
Automatic offers:

fedirjh | Reviewer | 0
gijoe0295 | Contributor | 0

melvin-bot · 2024-03-22T20:05:41Z

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

lanitochka17 · 2024-03-22T20:06:06Z

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 · 2024-03-22T20:06:20Z

We think that this bug might be related to #vip-vsp

gijoe0295 · 2024-03-22T20:16:05Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat is not scrolled to bottom when edit a task

What is the root cause of that problem?

Whenever there's any new report action in the report, we should call the notifyNewAction:

App/src/libs/actions/Report.ts

Line 342 in d482a25

    
           function notifyNewAction(reportID: string, accountID?: number, reportActionID?: string) {

to trigger scrollToBottom:

App/src/pages/home/report/ReportActionsList.js

Line 298 in 82da6b5

    
           InteractionManager.runAfterInteractions(() => reportScrollManager.scrollToBottom());

That's what we've been doing for IOU requests (for eg here). But for edit task flow (editTask), we did not call it.

What changes do you think we should make in order to solve the problem?

Call Report.notifyNewAction(report.reportID, currentUserAccountID) after editing the task in editTask.

We should also do it for whatever actions create new report action/message in the chat. For example: editTaskAssignee, reopenTask, completeTask.

What alternative solutions did you explore? (Optional)

NA

gijoe0295 · 2024-03-23T07:15:27Z

That's not correct @bernhardoj. This is a new behavior not on production and has different RCA with #38855.

Christinadobrzyn · 2024-03-25T03:37:39Z

Hum, I'm not able to reproduce this, it looks like the chat is at the bottom and the cursor is in the chat field when making edits to an assigned task.

2024-03-25_11-36-13.mp4

Asking QA for some clarification on the expected result vs actual result - https://expensify.slack.com/archives/C9YU7BX5M/p1711337939301019

gijoe0295 · 2024-03-25T03:52:16Z

@Christinadobrzyn you need to scroll the task report up then make changes there. They expect that when there're new changes in that task report, it should scroll to bottom (just like regular chat report).

Christinadobrzyn · 2024-03-26T04:59:19Z

Ah okay, I think I'm able to reproduce, I updated the OP so it's clearer how to reproduce. I think this can be external and part of vip-vsb

melvin-bot · 2024-03-26T04:59:34Z

Job added to Upwork: https://www.upwork.com/jobs/~01d64def74796adc96

melvin-bot · 2024-03-26T04:59:38Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

nkdengineer · 2024-03-26T05:31:55Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

After making multiple edits to a task, the chat thread isn't scrolled to the bottom.

What is the root cause of that problem?

We don't call notifyNewAction after we edit the task.

App/src/libs/actions/Report.ts

Lines 344 to 345 in d8361ee

    
           function notifyNewAction(reportID: string, accountID?: number, reportActionID?: string) { 
        
               const actionSubscriber = newActionSubscribers.find((subscriber) => subscriber.reportID === reportID);

If it's currently a bug, it also happens when we edit a money request.

What changes do you think we should make in order to solve the problem?

After edit a task or edit a money request, we should call notifyNewAction to scroll to bottom of the report.

App/src/libs/actions/Task.ts

Line 299 in d8361ee

function completeTask(taskReport: OnyxEntry<OnyxTypes.Report>) {

App/src/libs/actions/Task.ts

Line 365 in d8361ee

function reopenTask(taskReport: OnyxEntry<OnyxTypes.Report>) {

App/src/libs/actions/Task.ts

Line 429 in d8361ee

    
           function editTask(report: OnyxTypes.Report, {title, description}: OnyxTypes.Task) {

App/src/libs/actions/Task.ts

Line 504 in d8361ee

function editTaskAssignee(

App/src/libs/actions/Task.ts

Line 795 in d8361ee

function deleteTask(report: OnyxEntry<OnyxTypes.Report>) {

App/src/libs/actions/IOU.ts

Line 2053 in d8361ee

function updateDistanceRequest(

App/src/libs/actions/IOU.ts

Line 2030 in d8361ee

function updateMoneyRequestDescription(

App/src/libs/actions/IOU.ts

Line 2014 in d8361ee

function updateMoneyRequestCategory(

App/src/libs/actions/IOU.ts

Line 1975 in d8361ee

function updateMoneyRequestTag(

App/src/libs/actions/IOU.ts

Line 1952 in d8361ee

function updateMoneyRequestMerchant(

App/src/libs/actions/IOU.ts

Line 1936 in d8361ee

function updateMoneyRequestBillable(

App/src/libs/actions/IOU.ts

Line 1913 in d8361ee

function updateMoneyRequestDate(

App/src/libs/actions/IOU.ts

Line 3551 in d8361ee

function updateMoneyRequestAmountAndCurrency(

App/src/libs/actions/IOU.ts

Line 5049 in d8361ee

function putOnHold(transactionID: string, comment: string, reportID: string) {

App/src/libs/actions/IOU.ts

Line 5102 in d8361ee

function unholdRequest(transactionID: string, reportID: string) {

What alternative solutions did you explore? (Optional)

NA

0018akhil · 2024-03-26T08:03:46Z

Contributor details
Your Expensify account email: 0018akhil@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/akhilachary

I'm on Windows OS,
the issue is only happening in the staging environment.

Below is the video comparing both staging and the new website.

Scrollbar.Problem.mp4

I found this third-party cookies warning in the staging website this might be causing the issue(scrolling).

melvin-bot · 2024-03-26T08:03:50Z

📣 @0018akhil! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

0018akhil · 2024-03-26T08:49:15Z

Contributor details
Your Expensify account email: 0018akhil@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/akhilachary

Try pointing staging.new.expensify.com(staging website) to new.expensify.com URL temporarily, third party cookies warning will disappear and test it (scrollbar problem).

If you use Cloudflair this can be done easily.

melvin-bot · 2024-03-26T08:49:17Z

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

fedirjh · 2024-03-27T00:33:31Z

If it's currently a bug, it also happens when we edit a money request.

@nkdengineer Can you replicate this bug with the money request editing flow? I tried, but couldn't reproduce it.

nkdengineer · 2024-03-27T06:12:49Z

@fedirjh The reason is here

App/src/pages/home/ReportScreen.tsx

Lines 436 to 440 in 9d9757f

    
           useEffect(() => { 
        
               if (!isFocused || prevIsFocused || !ReportUtils.isChatThread(report) || report.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN) { 
        
                   return; 
        
               } 
        
               Report.openReport(report.reportID);

The transaction thread report is a chat thread and If we don't add any comment in transaction thread report, the notification of this report is hidden. When we edit the money request, the report is unfocused and then it's focused again after we submit the edit. That makes this useEffect above is triggered when we edit the money request and then the chat scrolls to bottom.

I think it's another bug and we should add isSingleTransactionView check in this useEffect to prevent openReport is called.

To replicate this bug, we can send a message in this report and edit the money request again.

Screen.Recording.2024-03-27.at.13.12.19.mov

0018akhil · 2024-03-27T06:33:11Z

@nkdengineer
Is this issue happening only on the staging site?

Christinadobrzyn · 2024-03-28T05:02:02Z

@0018akhil This appears to be happening in production too at https://new.expensify.com/

2024-03-28_12-59-29.mp4

0018akhil · 2024-03-28T05:38:53Z

Hi @Christinadobrzyn . Okay

So your in Mac. Can you send me the screenshot of your console(any warnings).

Christinadobrzyn · 2024-03-28T06:37:00Z

I see this in the console when changing the task not sure if those are helpful

fedirjh · 2024-03-29T02:52:21Z

I think it's another bug and we should add isSingleTransactionView check in this useEffect to prevent openReport is called.

@nkdengineer Thanks for confirming this. I was not able to replicate the bug with the money request edit flow. Hence, I don't think we should extend the fix to cover that flow.

fedirjh · 2024-03-29T02:52:43Z

I think we should proceed with this proposal from @gijoe0295. the solution looks good to me.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2024-03-29T02:52:56Z

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

nkdengineer · 2024-03-29T03:01:30Z

I was not able to replicate the bug with the money request edit flow. Hence, I don't think we should extend the fix to cover that flow.

To replicate this bug, we can send a message in this report and edit the money request again.

@fedirjh As I mentioned above, we can replicate this bug on latest main or staging without any code change by sending a message in transaction thread report before we edit the money request. I think we should fix all of them in an issue to verify that this bug doesn't happen in the further.

gijoe0295 · 2024-03-29T03:13:26Z

Sorry for being late here.

We should also do it for whatever actions create new report action/message in the chat.

Whichever approach we proceed, they were already covered in my proposal. I think that finding these places are not difficult and not significant enough to count as a completely new proposal. It took more time to find the RCA than finding every places as the implementation is straightforward. Doing this would discourage contributors from investigating the issues and create precedence for tricks like extending former proposals to include "similar" cases. We have many jobs that finding all specific places to fix does not make a difference. We can always handle those in PR implementation.

Christinadobrzyn · 2024-04-02T07:36:22Z

Not overdue,

@madmax330 can you review the proposal here - #38833 (comment)

melvin-bot · 2024-04-02T08:00:18Z

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-04-02T08:00:27Z

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

gijoe0295 · 2024-04-19T18:16:23Z

@Christinadobrzyn I think we're good for payment here because PR has been on production for nearly 10 days.

Christinadobrzyn · 2024-04-22T05:16:11Z

Thanks @gijoe0295 - not sure why the payment auto-message didn't trigger for this.

Payouts due:

Contributor: $500 @gijoe0295 (paid in upwork - https://www.upwork.com/nx/wm/workroom/36856139/overview)
Contributor+: $500 @fedirjh (paid in upwork - https://www.upwork.com/nx/wm/workroom/37008381/overview)

Upwork job is here.

@fedirjh or @gijoe0295 do we need a regression test for this?

fedirjh · 2024-04-22T05:26:34Z

@Christinadobrzyn It seems like this bug was discovered using a regression test. Please review the OP for more information:

If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/runs/view/20318&group_by=cases:section_id&group_order=asc&group_id=291935

Christinadobrzyn · 2024-04-22T06:40:06Z

Ah thanks @fedirjh, if it was caught during a regression test then no payments should be made. I just requested a refund through Upwork for the payments sent earlier today. Let me know if I'm missing anything!

fedirjh · 2024-04-22T06:53:58Z

@Christinadobrzyn Sorry for the confusion. My above answer was related to this question :

do we need a regression test for this?

We don't need a regression test as we already have one listed in the OP.

if it was caught during a regression test, then no payments should be made

This is not the case for this issue. it is not caught during the regression period.

Christinadobrzyn · 2024-04-23T07:57:03Z

Oh thank you for clarifying! Okay, gotcha!

Please ignore my refund requests. Closing since we don't need a regression. Let me know if I'm missing anything.

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 22, 2024

melvin-bot bot assigned Christinadobrzyn Mar 22, 2024

This comment was marked as outdated.

Sign in to view

Christinadobrzyn added this to [#whatsnext] #vip-vsb Mar 26, 2024

Christinadobrzyn added the External Added to denote the issue can be worked on by a contributor label Mar 26, 2024

melvin-bot bot changed the title ~~Task - Chat is not scrolled to bottom when edit a task~~ [$500] Task - Chat is not scrolled to bottom when edit a task Mar 26, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 26, 2024

melvin-bot bot assigned fedirjh Mar 26, 2024

melvin-bot bot assigned madmax330 Mar 29, 2024

melvin-bot bot added the Overdue label Apr 1, 2024

melvin-bot bot removed the Overdue label Apr 2, 2024

madmax330 assigned gijoe0295 Apr 2, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 2, 2024

gijoe0295 mentioned this issue Apr 2, 2024

Fix: Task report does not scroll to bottom after editing #39390

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 2, 2024

kavimuru mentioned this issue Apr 8, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807

Closed

Christinadobrzyn added Daily KSv2 and removed Weekly KSv2 labels Apr 22, 2024

Christinadobrzyn closed this as completed Apr 23, 2024

[$500] Task - Chat is not scrolled to bottom when edit a task #38833

[$500] Task - Chat is not scrolled to bottom when edit a task #38833

Comments

lanitochka17 commented Mar 22, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Mar 22, 2024

lanitochka17 commented Mar 22, 2024

lanitochka17 commented Mar 22, 2024

gijoe0295 commented Mar 22, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

This comment was marked as outdated.

gijoe0295 commented Mar 23, 2024

Christinadobrzyn commented Mar 25, 2024 • edited Loading

gijoe0295 commented Mar 25, 2024 • edited Loading

Christinadobrzyn commented Mar 26, 2024 • edited Loading

melvin-bot bot commented Mar 26, 2024

melvin-bot bot commented Mar 26, 2024

nkdengineer commented Mar 26, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

0018akhil commented Mar 26, 2024 • edited Loading

melvin-bot bot commented Mar 26, 2024

0018akhil commented Mar 26, 2024 • edited Loading

melvin-bot bot commented Mar 26, 2024

fedirjh commented Mar 27, 2024

nkdengineer commented Mar 27, 2024

0018akhil commented Mar 27, 2024

Christinadobrzyn commented Mar 28, 2024 • edited Loading

0018akhil commented Mar 28, 2024 • edited Loading

Christinadobrzyn commented Mar 28, 2024

fedirjh commented Mar 29, 2024

fedirjh commented Mar 29, 2024

melvin-bot bot commented Mar 29, 2024

nkdengineer commented Mar 29, 2024 • edited Loading

gijoe0295 commented Mar 29, 2024 • edited Loading

Christinadobrzyn commented Apr 2, 2024 • edited Loading

melvin-bot bot commented Apr 2, 2024

melvin-bot bot commented Apr 2, 2024

gijoe0295 commented Apr 19, 2024

Christinadobrzyn commented Apr 22, 2024

fedirjh commented Apr 22, 2024

Christinadobrzyn commented Apr 22, 2024

fedirjh commented Apr 22, 2024

Christinadobrzyn commented Apr 23, 2024

lanitochka17 commented Mar 22, 2024 •

edited by melvin-bot bot

Loading

gijoe0295 commented Mar 22, 2024 •

edited

Loading

Christinadobrzyn commented Mar 25, 2024 •

edited

Loading

gijoe0295 commented Mar 25, 2024 •

edited

Loading

Christinadobrzyn commented Mar 26, 2024 •

edited

Loading

nkdengineer commented Mar 26, 2024 •

edited

Loading

0018akhil commented Mar 26, 2024 •

edited

Loading

0018akhil commented Mar 26, 2024 •

edited

Loading

Christinadobrzyn commented Mar 28, 2024 •

edited

Loading

0018akhil commented Mar 28, 2024 •

edited

Loading

nkdengineer commented Mar 29, 2024 •

edited

Loading

gijoe0295 commented Mar 29, 2024 •

edited

Loading

Christinadobrzyn commented Apr 2, 2024 •

edited

Loading