Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Chat - Chat is not scrolled to the new message on a newly created WS chat after whisper message #38855

Closed
1 of 6 tasks
lanitochka17 opened this issue Mar 23, 2024 · 64 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Create a new workspace as account A and invite account B
  2. As account B open the workspace chat of the newly created WS on step 1
  3. Note the whisper message and send a message after the whisper message

Expected Result:

The chat should scroll down to the new sent message

Actual Result:

Chat page does not scroll to the bottom to the new message sent after the whisper message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423703_1711139703006.Screen_Recording_20240322_232619_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0195afebb1a07596ef
  • Upwork Job ID: 1772292798302457856
  • Last Price Increase: 2024-04-09
  • Automatic offers:
    • ikevin127 | Contributor | 0
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 23, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 23, 2024

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

@robertjchen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@gijoe0295
Copy link
Contributor

I think same RCA as #38848.

@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@robertjchen robertjchen added External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 Overdue labels Mar 25, 2024
@melvin-bot melvin-bot bot changed the title Chat - Chat is not scrolled to the new message on a newly created WS chat after whisper message [$500] Chat - Chat is not scrolled to the new message on a newly created WS chat after whisper message Mar 25, 2024
Copy link

melvin-bot bot commented Mar 25, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0195afebb1a07596ef

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 25, 2024
Copy link

melvin-bot bot commented Mar 25, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Mar 25, 2024
@robertjchen
Copy link
Contributor

Yep, this can be handled as an External task 👍

@robertjchen robertjchen changed the title [$500] Chat - Chat is not scrolled to the new message on a newly created WS chat after whisper message [$250] Chat - Chat is not scrolled to the new message on a newly created WS chat after whisper message Mar 25, 2024
Copy link

melvin-bot bot commented Mar 25, 2024

Upwork job price has been updated to $250

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
Copy link

melvin-bot bot commented Apr 1, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@robertjchen robertjchen changed the title [$250] Chat - Chat is not scrolled to the new message on a newly created WS chat after whisper message [$500] Chat - Chat is not scrolled to the new message on a newly created WS chat after whisper message Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

Upwork job price has been updated to $500

@robertjchen
Copy link
Contributor

updated

@melvin-bot melvin-bot bot added the Overdue label May 9, 2024
@robertjchen
Copy link
Contributor

Awaiting proposals

@melvin-bot melvin-bot bot removed the Overdue label May 10, 2024
@tsa321
Copy link
Contributor

tsa321 commented May 13, 2024

Proposals

Cross posting my proposal from other issue, I think this issue has same RCA.

@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

@robertjchen, @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

@robertjchen
Copy link
Contributor

Looks like it may be resolved by #40724 (comment) 👍

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 14, 2024
Copy link

melvin-bot bot commented May 17, 2024

@robertjchen, @anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@robertjchen robertjchen added the Reviewing Has a PR in review label May 20, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 20, 2024
@robertjchen
Copy link
Contributor

Pending solution in #40724 (comment)

@robertjchen robertjchen added Weekly KSv2 and removed Daily KSv2 labels May 20, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

This issue has not been updated in over 15 days. @robertjchen, @anmurali eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@robertjchen
Copy link
Contributor

Nice, looks like the change was deployed there. Given that it's unreproducible here, I'll close this out in favor of the one there 👍 #40724 (comment)

@parasharrajat
Copy link
Member

I might be eligible for some compensation on this issue.

Reason:

  1. I helped review the first PR created for this. Even though it was reverted, I was requested to review it on Slack.

Reviewed PR: #40286

@anmurali @robertjchen

@mallenexpensify
Copy link
Contributor

@luacmartins and @mountiny. @parasharrajat has requested payment of 50% for this issue because they worked on the PR.

@luacmartins luacmartins requested review from parasharrajat

I'm going to pay later this week, assuming neither of you disagree.

@mallenexpensify mallenexpensify self-assigned this Jul 2, 2024
@mallenexpensify mallenexpensify added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 Reviewing Has a PR in review labels Jul 2, 2024
@parasharrajat
Copy link
Member

Payment requested as per #38855 (comment)

@JmillsExpensify
Copy link

$250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests