Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-05][$250] Add Fullstory lib #40784

Closed
danieldoglas opened this issue Apr 23, 2024 · 27 comments
Closed

[HOLD for payment 2024-06-05][$250] Add Fullstory lib #40784

danieldoglas opened this issue Apr 23, 2024 · 27 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Task

Comments

@danieldoglas
Copy link
Contributor

danieldoglas commented Apr 23, 2024

Parent tracking issue

Placeholder app issue so we can assign open source contributors/reviewers on Implementing Fullstory

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019a2954cbe99d41e6
  • Upwork Job ID: 1782752092104155136
  • Last Price Increase: 2024-04-23
Issue OwnerCurrent Issue Owner: @mallenexpensify
@danieldoglas danieldoglas added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 23, 2024
@danieldoglas danieldoglas self-assigned this Apr 23, 2024
Copy link

melvin-bot bot commented Apr 23, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@danieldoglas danieldoglas added Task and removed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 23, 2024
@LCOleksii
Copy link
Contributor

Support of the Fullstory was implemented by:

  • Adding integration of Fullstory React-Native plugin (IOS, Android)
  • Adding Fullstory's Annotate React plugin (Mobile, Web)

Separate library activation for Web, Desktop(Hybrid Web)
should be done by applying related GTM changes:
https://help.fullstory.com/hc/en-us/articles/360020828293-Google-Tag-Manager-GTM

Copy link

melvin-bot bot commented Apr 23, 2024

📣 @LCOleksii! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@danieldoglas danieldoglas changed the title Add Fullstory lib [$250] Add Fullstory lib Apr 23, 2024
Copy link

melvin-bot bot commented Apr 23, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@ishpaul777
Copy link
Contributor

👋 hello, i'll be reviewing the PR for this

@danieldoglas danieldoglas added the External Added to denote the issue can be worked on by a contributor label Apr 23, 2024
Copy link

melvin-bot bot commented Apr 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~019a2954cbe99d41e6

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 23, 2024
Copy link

melvin-bot bot commented Apr 23, 2024

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

@danieldoglas danieldoglas removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 23, 2024
@danieldoglas
Copy link
Contributor Author

Removing help wanted, this was already worked on.

@mananjadhav
Copy link
Collaborator

As per this message, uploading the crash log. Reverting PRs for this issue fixes this issue (App crash on video upload).

fullstory-video-crash.txt

Copy link

melvin-bot bot commented Apr 24, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 24, 2024
@danieldoglas
Copy link
Contributor Author

This was reverted @LCOleksii is working in a new branch again!

@ishpaul777
Copy link
Contributor

@LCOleksii Any updates? do we have a draft PR

@danieldoglas
Copy link
Contributor Author

@ishpaul777 assigned you to the new PR today!

@trjExpensify trjExpensify changed the title [$250] Add Fullstory lib [Fullstory] [$250] Add Fullstory lib May 21, 2024
@melvin-bot melvin-bot bot added the Overdue label May 21, 2024
@mallenexpensify
Copy link
Contributor

PR is actively being worked on (as of 2 hours ago)

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 29, 2024
@melvin-bot melvin-bot bot changed the title [Fullstory] [$250] Add Fullstory lib [HOLD for payment 2024-06-05] [Fullstory] [$250] Add Fullstory lib May 29, 2024
Copy link

melvin-bot bot commented May 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @LCOleksii requires payment (Needs manual offer from BZ)
  • @ishpaul777 requires payment (Needs manual offer from BZ)

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 30, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-05] [Fullstory] [$250] Add Fullstory lib [HOLD for payment 2024-06-06] [HOLD for payment 2024-06-05] [Fullstory] [$250] Add Fullstory lib May 30, 2024
Copy link

melvin-bot bot commented May 30, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

  • @LCOleksii requires payment (Needs manual offer from BZ)
  • @ishpaul777 requires payment (Needs manual offer from BZ)

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 4, 2024
@mallenexpensify mallenexpensify changed the title [HOLD for payment 2024-06-06] [HOLD for payment 2024-06-05] [Fullstory] [$250] Add Fullstory lib [HOLD for payment 2024-06-06][$250] Add Fullstory lib Jun 5, 2024
@mallenexpensify mallenexpensify changed the title [HOLD for payment 2024-06-06][$250] Add Fullstory lib [HOLD for payment 2024-06-05][$250] Add Fullstory lib Jun 5, 2024
@mallenexpensify
Copy link
Contributor

Payment due tomorrow

@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2024
@ishpaul777
Copy link
Contributor

@mallenexpensify I'll be paid in this issue #40809

Copy link

melvin-bot bot commented Jun 5, 2024

Payment Summary

Upwork Job

BugZero Checklist (@mallenexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1782752092104155136/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@mallenexpensify
Copy link
Contributor

Thanks @ishpaul777 , def a strange one with their being two parent issues for the PR.
@LCOleksii are you due payment here?

@danieldoglas
Copy link
Contributor Author

@LCOleksii is not due payment on this one @mallenexpensify !

@mallenexpensify
Copy link
Contributor

K, sounds like this can be close then. Thx all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Task
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants