-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Revert Fullstory lib changes #40894
Conversation
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
@mountiny @danieldoglas I am opening this up for review. I am having some issues with my Android build, so I'll test on the adhoc build. If we're able to fix it with Fullstory we can close this one. |
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also fixed #40910
[CP Staging] Revert Fullstory lib changes (cherry picked from commit f0c6589)
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.65-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀
|
Reverting the
Fullstory
integration fixes the app crash on video upload.Details
Fixed Issues
$ #40874
$ #40784
$ #40910
PROPOSAL: N/A
Tests
+
) buttonOffline tests
N/A
QA Steps
Same as Test steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android-revert-fullstory.mp4
Android: mWeb Chrome
mweb-chrome-revert-fullstory.mov
iOS: Native
ios-revert-fullstory.mov
iOS: mWeb Safari
mweb-safari-revert-fullstory.mov
MacOS: Chrome / Safari
web-revert-fullstory.mov
MacOS: Desktop
desktop-revert-fullstory.mov