Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-06] [HOLD for payment 2024-06-05] [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] iOS - Onboarding - App crashes during "Track business spend for taxes" onboarding flow #40910

Closed
1 of 6 tasks
lanitochka17 opened this issue Apr 24, 2024 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4509316
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open the app
  2. Enter a new email address ( new account)
  3. Go to your inbox and find the email with the magic code > Tap on the magic code link (please use the link)
  4. On the engagement modal > choose ''Track business spend for taxes''
  5. Enter both first and last names > Tap continue
  6. Enter business name > Tap continue

Expected Result:

App should not crash during onboarding flow

Actual Result:

App crashes during "Track business spend for taxes" onboarding flow

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460322_1713966767482.Track_business_spends_for_taxes_flow.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@deetergp FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

Production:

Bug6460322_1713966848588.PROD-not_repro-on.mp4

@mountiny
Copy link
Contributor

@rezkiy37 @filip-solecki @cdOut this might be related to the full story

@filip-solecki
Copy link
Contributor

Hi! I am Filip from SWM and I can take care of this issue!

@mountiny mountiny self-assigned this Apr 24, 2024
@mountiny
Copy link
Contributor

I have tested on this revert build #40894 and I could not repro

@mountiny
Copy link
Contributor

I was able to repro on staging and I was not able to repro on the adhoc build with the full story reverted
https://github.com/Expensify/App/assets/36083550/9de6c6b1-cb78-496b-aad1-3b4909d075f3

RPReplay_Final1713977624.MP4

@mountiny mountiny added the Reviewing Has a PR in review label Apr 24, 2024
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 24, 2024
@mountiny
Copy link
Contributor

CPing the full story revert

@kbecciv
Copy link

kbecciv commented Apr 24, 2024

QA team is unable to reproduce on the adhoc build

RPReplay_Final1713982780.MP4

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Apr 25, 2024
@melvin-bot melvin-bot bot changed the title iOS - Onboarding - App crashes during "Track business spend for taxes" onboarding flow [HOLD for payment 2024-05-02] iOS - Onboarding - App crashes during "Track business spend for taxes" onboarding flow Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-02. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 26, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-05-02] iOS - Onboarding - App crashes during "Track business spend for taxes" onboarding flow [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] iOS - Onboarding - App crashes during "Track business spend for taxes" onboarding flow Apr 26, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-03. 🎊

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 13, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 29, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] iOS - Onboarding - App crashes during "Track business spend for taxes" onboarding flow [HOLD for payment 2024-06-05] [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] iOS - Onboarding - App crashes during "Track business spend for taxes" onboarding flow May 29, 2024
Copy link

melvin-bot bot commented May 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 29, 2024
Copy link

melvin-bot bot commented May 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-05. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 30, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-05] [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] iOS - Onboarding - App crashes during "Track business spend for taxes" onboarding flow [HOLD for payment 2024-06-06] [HOLD for payment 2024-06-05] [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] iOS - Onboarding - App crashes during "Track business spend for taxes" onboarding flow May 30, 2024
Copy link

melvin-bot bot commented May 30, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-06. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants