[$250] User name appears twice in the search results

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: n/a
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): @tgolen
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tgolen
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714066931849749

Action Performed:

1. Open staging.new.expensify.com
2. Search for a user

Expected Result:

Only one result is showing

Actual Result:

Duplicate results are showing. And 2 different outcomes when clicking on both the results

• The second entry takes me to the not-found page (report ID 4509855578485378) happened on April 25
• Taking both to same chat

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01192f17cd0c3b2408
• Upwork Job ID: 1795199117097398272
• Last Price Increase: 2024-06-17

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[puneetlath]

Closing as this seems no longer reproducible.

[m-natarajan]

Issue reproducible
Issue reported by @puneetlath
Slack Conversation : https://expensify.slack.com/archives/C049HHMV9SM/p1716479684841619

[melvin-bot]

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01192f17cd0c3b2408

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[puneetlath]

Making external to see if someone can figure out why it's happening.

[samilabud]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User name appears twice in the search results

What is the root cause of that problem?

We are using the OptionListContextProvider to get the list options chats, but this PR did a fix for workspace list that affects the chatFinder because assumes that the missing ids was because there was a workspace missing, but in our case the available chat list pass to be part of the report list, so we going to have it inside our reports variable after selected the chat (in this case this will be added as a missingReportId because this report id was in the previous reports list).
I.E:

bug.missing.id.replication.mp4

What changes do you think we should make in order to solve the problem?

We should determinate if the OptionListContextProvider is being used by the ChatFinderPage, if so we don't need to use the Missing ReportId logic:

App/src/components/OptionListContextProvider.tsx

Lines 84 to 99 in 20852f8

	const missingReportIds = Object.keys(reports).filter((key) => prevReports && !(key in prevReports));
	setOptions((prevOptions) => {
	const newOptions = {
	...prevOptions,
	reports: prevOptions.reports.filter((report) => reports[`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`] !== null),
	};
	missingReportIds.forEach((missingReportId) => {
	const report = missingReportId ? reports[missingReportId] : null;
	if (!missingReportId || !report) {
	return;
	}
	const reportOption = OptionsListUtils.createOptionFromReport(report, personalDetails);
	newOptions.reports.push(reportOption);
	});
	return newOptions;

What alternative solutions did you explore?

Remove the Missing ReportId logic.

[melvin-bot]

@puneetlath @abdulrahuman5196 this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[puneetlath]

@abdulrahuman5196 thoughts on the proposal?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[puneetlath]

@abdulrahuman5196 bump!

[abdulrahuman5196]

@abdulrahuman5196 bump!
Sorry for the delay checked now.

@samilabud I am not sure on the proposal, since I am unable to repro the issue itself. Any way to consistently repro the issue?

[samilabud]

Any way to consistently repro the issue?

Yes, first search anything, then you should use the keyboard and navigate from the top to the bottom (with arrow up key), you should have at least one personal account in the bottom to reproduce it.

Any extra clarification I'm at your service👍🏼

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[puneetlath]

@abdulrahuman5196 any further thoughts?

[abdulrahuman5196]

@puneetlath I am unable to repro the issue. And seems not reproducible in the tests as well #41432 (comment)

Are you still reproducible? Is it only for specific accounts?

[puneetlath]

It seems to only happen sometimes for specific people. For example I have this right now. My theory is that one of these is an optimistic report that was created when I tried to chat them and for some reason didn't get cleaned up when I got re-routing to my existing report with this person. But I'm not exactly sure how to confirm that.

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@puneetlath, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[puneetlath]

@abdulrahuman5196 did that example help at all?

[abdulrahuman5196]

@puneetlath sorry but no. I am still unable to repro this issue.

[melvin-bot]

@puneetlath, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@puneetlath, @abdulrahuman5196 Still overdue 6 days?! Let's take care of this!

[puneetlath]

Ok, I'm no longer able to reproduce it either. Let's close for now.