fix workspace list does not show #40730

tienifr · 2024-04-22T21:29:54Z

Details

Fixed Issues

$ #40406
PROPOSAL: #40406 (comment)

Tests

Open app.
Create a new account
Go to your space
Create a manual track expense
Click on Categorize it
Click on Learn more and create a new workspace
Go to your space and click on Categorize it again
Verify the newly created workspace should show up

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open app.
Create a new account
Go to your space
Create a manual track expense
Click on Categorize it
Click on Learn more and create a new workspace
Go to your space and click on Categorize it again
Verify the newly created workspace should show up

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-23.at.04.48.52.mov

Android: mWeb Chrome

Screen.Recording.2024-04-23.at.04.43.19.mov

iOS: Native

Screen.Recording.2024-04-23.at.04.46.07.mov

iOS: mWeb Safari

Screen.Recording.2024-04-23.at.04.40.14.mov

MacOS: Chrome / Safari

output.mp4

MacOS: Desktop

Screen.Recording.2024-04-23.at.04.33.46.mov

melvin-bot · 2024-04-22T21:29:59Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-04-23T01:19:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

categorizeiOS.mp4

iOS: mWeb Safari

categorizeiOSSafari.mp4

MacOS: Chrome / Safari

categorizeChrome.mp4

MacOS: Desktop

categorizeDesktop.mp4

c3024 · 2024-04-23T02:25:55Z

@thienlnam

There is another bug found here. CreateWorkspace command does not return any response. So, only after clicking the categories page, OpenCategoriesPage returns the category list. So, NotFound page is shown briefly.

not-found.mov

This is similar to accessing the categories from the WorkspaceInitialPage
We show an activity indicator here

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 246 in 64695c8

const isLoading = !isOffline && policyCategories === undefined;

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 285 to 286 in 64695c8

    
           {isLoading && ( 
        
               <ActivityIndicator

when we open the categories page from WorkspaceInitialPage

We can use this same logic for showing a loading indicator in IOURequestStepCategory.

As this looks like an urgent issue, let us know if we'd like to fix this within the scope of this issue or as a follow-up because this has a separate RCA and this is also related to other IOU flows using category. If we fix this within this same issue please confirm if we can go with the above suggestion. Thanks.

cc: @tienifr

thienlnam · 2024-04-23T17:52:30Z

Thanks for finding that - let's also fix it in the scope of this issue. We've decided to push back launch to next week so we can take our time to fix things correctly

c3024 · 2024-04-24T06:08:37Z

@thienlnam

I thought of using a loading indicator whereas in this Slack discussion here optimistic categories are being added. The bug pointed out in my previous comment will be fixed after adding the optimistic categories in the issue related to the aforementioned Slack discussion.

I think we better fix only the actual bug of the issue i.e. not showing workspace list here to avoid any conflicts with the other issue.

thienlnam · 2024-04-24T16:28:54Z

Yeah that sounds good

c3024 · 2024-04-24T18:18:58Z

@thienlnam

I am not able to build Android locally. Could you run a build here?

github-actions · 2024-04-24T20:28:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40730/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40730/NewExpensify.dmg	https://40730.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2024-04-24T21:02:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-25T14:08:50Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T14:26:29Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-26T22:57:31Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix workspace list does not show

8f0fc1e

tienifr requested a review from a team as a code owner April 22, 2024 21:29

melvin-bot bot requested review from c3024 and removed request for a team April 22, 2024 21:29

tienifr mentioned this pull request Apr 22, 2024

[HOLD for payment 2024-05-06] [HOLD for payment 2024-05-03] CRITICAL: [Actionable Whispers] [$500] Workspace list doesn't show up after creating a workspace for categorize it #40406

Closed

6 tasks

This comment was marked as outdated.

Sign in to view

melvin-bot bot requested a review from thienlnam April 24, 2024 17:35

thienlnam added the Ready To Build label Apr 24, 2024

thienlnam approved these changes Apr 24, 2024

View reviewed changes

thienlnam merged commit 9a727de into Expensify:main Apr 24, 2024
19 checks passed

github-actions bot mentioned this pull request Apr 25, 2024

Deploy Checklist: New Expensify 2024-04-25 #40981

Closed

53 tasks

This was referenced May 28, 2024

[$250] User name appears twice in the search results #41432

Closed

[HOLD for payment 2024-06-24][$1000] Correct chat is not opening when typing someone's name and hit Enter in chat switcher #39631

Closed

jasperhuangg mentioned this pull request Jun 14, 2024

Search result duplication #43164

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix workspace list does not show #40730

fix workspace list does not show #40730

tienifr commented Apr 22, 2024 •

edited

Loading

melvin-bot bot commented Apr 22, 2024

c3024 commented Apr 23, 2024 •

edited

Loading

c3024 commented Apr 23, 2024 •

edited

Loading

thienlnam commented Apr 23, 2024

c3024 commented Apr 24, 2024

thienlnam commented Apr 24, 2024

This comment was marked as outdated.

c3024 commented Apr 24, 2024

github-actions bot commented Apr 24, 2024

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 26, 2024

fix workspace list does not show #40730

fix workspace list does not show #40730

Conversation

tienifr commented Apr 22, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 22, 2024

c3024 commented Apr 23, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 commented Apr 23, 2024 • edited Loading

thienlnam commented Apr 23, 2024

c3024 commented Apr 24, 2024

thienlnam commented Apr 24, 2024

This comment was marked as outdated.

c3024 commented Apr 24, 2024

github-actions bot commented Apr 24, 2024

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 26, 2024

tienifr commented Apr 22, 2024 •

edited

Loading

c3024 commented Apr 23, 2024 •

edited

Loading

c3024 commented Apr 23, 2024 •

edited

Loading