Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-17] [Details Revamp] Remove the Three Dot Menu on Affected Reports #42080

Closed
grgia opened this issue May 13, 2024 · 26 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@grgia
Copy link
Contributor

grgia commented May 13, 2024

https://docs.google.com/document/d/1-xSZdSZZIuIl0fPO7yypkKfcbWEsnNFAs50ptgL3Gnw/edit#bookmark=id.qn5rgvv8le7q

Issue OwnerCurrent Issue Owner: @adelekennedy
@grgia grgia added Daily KSv2 NewFeature Something to build that is a new item. labels May 13, 2024
@grgia grgia self-assigned this May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented May 13, 2024

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

@grgia grgia changed the title [Details Revamp] Remove the Three Dot Menu on Affected Reports [HOLD - Final PR][Details Revamp] Remove the Three Dot Menu on Affected Reports May 13, 2024
@melvin-bot melvin-bot bot added the Overdue label May 21, 2024
@adelekennedy
Copy link

still on hold

@melvin-bot melvin-bot bot removed the Overdue label May 21, 2024
@melvin-bot melvin-bot bot added the Overdue label May 29, 2024
@adelekennedy
Copy link

@grgia @dannymcclain I assume we're still holding here?

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2024
@dannymcclain
Copy link
Contributor

I think that's right. @grgia can confirm!

@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2024
@grgia
Copy link
Contributor Author

grgia commented Jun 12, 2024

@cdOut

@melvin-bot melvin-bot bot removed the Overdue label Jun 12, 2024
@cdOut
Copy link
Contributor

cdOut commented Jun 12, 2024

This is the final issue and will be on hold until we get this PR merged.

@adelekennedy
Copy link

Still waiting for the linked PR to be merged

@melvin-bot melvin-bot bot removed the Overdue label Jun 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
@trjExpensify trjExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jul 1, 2024
@trjExpensify
Copy link
Contributor

Can we remove the hold here?

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [Details Revamp] Remove the Three Dot Menu on Affected Reports [HOLD for payment 2024-07-17] [Details Revamp] Remove the Three Dot Menu on Affected Reports Jul 10, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 10, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] [Details Revamp] Remove the Three Dot Menu on Affected Reports [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Details Revamp] Remove the Three Dot Menu on Affected Reports Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 16, 2024
@adelekennedy adelekennedy changed the title [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Details Revamp] Remove the Three Dot Menu on Affected Reports [HOLD for payment 2024-07-17] [Details Revamp] Remove the Three Dot Menu on Affected Reports Jul 19, 2024
@adelekennedy
Copy link

adelekennedy commented Jul 19, 2024

Payouts due:

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 19, 2024
@adelekennedy
Copy link

@parasharrajat I think the only additional step is the checklist and then we can close this one out?

@melvin-bot melvin-bot bot removed the Overdue label Jul 22, 2024
@parasharrajat
Copy link
Member

Regression Test Steps

  1. Create a workspace
  2. Go into a room of said workspace and confirm that the three dot menu in the header is missing
  3. Create two expenses for the workspace
  4. Go into the report view containing both those expenses and confirm the three dot menu is missing
  5. Go into one of the expenses and confirm that the three dot menu is missing
  6. If you have an access to an account with a Concierge guide assigned, please check whether the button for Book a call works properly, since it has been removed from the three dot menu in that chat.

Do you agree 👍 or 👎 ?

@adelekennedy
Copy link

@grgia for your thoughts on the above but that makes sense to me!

@adelekennedy
Copy link

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 25, 2024
@parasharrajat
Copy link
Member

Payment requested as per #42080 (comment)

@JmillsExpensify
Copy link

$250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants