[HOLD for payment 2024-08-01] [Details revamp] [$250] Unable to unpin my SelfDM

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.8-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721253090263159

Action Performed:

1. Log into any account, though preferably new since we auto-pin your SelfDM
2. Tap on on the SelfDM header

Expected Result:

An option to unpin my selfDM

Actual Result:

Impossible to unpin your selfDM and no option

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.353.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018cb35860d3254ac5
• Upwork Job ID: 1813935056621759849
• Last Price Increase: 2024-07-18
• Automatic offers:
• eh2077 | Reviewer | 103182610

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to unpin my SelfDM

What is the root cause of that problem?

The issue's root cause is that the OptionRowLHN component does not use the PinButtion component.

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Lines 298 to 306 in 909f8ea

	<View
	style={styles.ml2}
	accessibilityLabel={translate('sidebarScreen.chatPinned')}
	>
	<Icon
	testID="Pin Icon"
	fill={theme.icon}
	src={Expensicons.Pin}
	/>

Therefore, the user has to right-click the OptionRowLHN and unpin or pin the report instead of the pin icon unpinning the report.

The pin icon is unclickable and unusable.

What changes do you think we should make in order to solve the problem?

Use the PinButtion component to ensure the pin icon can be used.

Hence, let's change the code in the OptionRowLHN component in these lines above to the one below.

<PinButton report={optionItem} isOption/>

Finally, we need to make the icon for the PinButton component consistent with the previous look.

Therefore, we should create a new prop called isOption defaulted to false to create two other simple logics to fill icon prop for the PinButton component to icon.fill and the styles for an OptionRowLHN component.

1. Change this fil logic to over here.

fill={report.isPinned && !isOption ? theme.heading : theme.icon}

2. Create a condition for the style over here.

style={!isOption ? styles.touchableButtonImage : undefined}

Screen.Recording.2024-07-18.at.06.53.14.mov

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no option to unpin self-DM other than from the LHN context menu.

What is the root cause of that problem?

We previously removed the three-dot menu that includes the option to pin/unpin and move it to the profile page or report details page. The pin/unpin option will be shown if the report exists.

App/src/pages/ProfilePage.tsx

Lines 170 to 174 in f392cd3

	const promotedActions = useMemo(() => {
	const result: PromotedAction[] = [];
	if (report) {
	result.push(PromotedActions.pin(report));
	}

However, for self-DM, the report doesn't exist.

App/src/pages/ProfilePage.tsx

Lines 87 to 96 in f392cd3

	const reportKey = useMemo(() => {
	const accountID = Number(route.params?.accountID ?? -1);
	const reportID = ReportUtils.getChatByParticipants(session?.accountID ? [accountID, session.accountID] : [], reports)?.reportID ?? '-1';
	if ((!!session && Number(session?.accountID) === accountID) || SessionActions.isAnonymousUser() || !reportID) {
	return `${ONYXKEYS.COLLECTION.REPORT}0` as const;
	}
	return `${ONYXKEYS.COLLECTION.REPORT}${reportID}` as const;
	}, [reports, route.params?.accountID, session]);
	const [report] = useOnyx(reportKey);

If the current user account ID is the same as the account ID that we are viewing, then we return report_0 as the report key.

What changes do you think we should make in order to solve the problem?

If we are viewing our own profile, then we need to return the self-DM report ID.

const accountID = Number(route.params?.accountID ?? -1);
const isCurrentUser = session?.accountID === accountID;

const reportKey = useMemo(() => {
    const reportID = isCurrentUser
        ? ReportUtils.findSelfDMReportID()
        : ReportUtils.getChatByParticipants(session?.accountID ? [accountID, session.accountID] : [], reports)?.reportID ?? '-1';

    if (SessionActions.isAnonymousUser() || !reportID) {
        return `${ONYXKEYS.COLLECTION.REPORT}0` as const;
    }
    return `${ONYXKEYS.COLLECTION.REPORT}${reportID}` as const;
}, [reports, accountID, isCurrentUser, session]);

We can show the Message button if needed too which will open the self-DM report.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018cb35860d3254ac5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[trjExpensify]

However, for self-DM, the report doesn't exist.

Isn't the self-DM a chatReport? 😕

[bernhardoj]

Oh, the "report" that I was mentioning is the "report" variable 😄, it's undefined for self-DM.

[trjExpensify]

Ah okay, that makes sense.

[eh2077]

@Tony-MK Thanks for your proposal. But I don't think we'll want to make the pin icon of LHN message as button - that's inconsistent to the current design - The pin/unpin options are available from RHP.

---

@bernhardoj 's proposal looks good to me.

I think including both Pin/Unpin and Message buttons makes sense. @trjExpensify What do you think?

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @eh2077

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show pin and message option for current user profile #45783

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @eh2077 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR:
• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eh2077] Determine if we should create a regression test for this bug.
• [@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[adelekennedy]

Payouts due:

• Contributor: $250 @bernhardoj (NewDot)
• Contributor+: $250 @eh2077 (Upwork)

Just the checklist left @eh2077

[bernhardoj]

Requested in ND

[JmillsExpensify]

$250 approved for @bernhardoj

[melvin-bot]

@nkuoch, @bernhardoj, @adelekennedy, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[adelekennedy]

bump @eh2077 for the checklist

[eh2077]

Checklist

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR: This issue was introduced by the change to remove the three-dot menu, see related issue [HOLD for payment 2024-07-17] [Details Revamp] Remove the Three Dot Menu on Affected Reports #42080
• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@eh2077] Determine if we should create a regression test for this bug. No, because this should be a stable feature and won't be changed often.

[eh2077]

@adelekennedy Just completed the checklist, thanks for the reminder!