[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Expensify chat - Incorrect LHN preview for Expensify chat

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.84-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Expensify chat

Expected Result:

Expensify chat preview in LHN should display "Welcome! Let's get you set up." or "Message Concierge for help with setup"

Actual Result:

Expensify chat preview in LHN displays "This is the beginning of your chat with Expensify"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6514462_1718473042888.expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016857ff3bf2660def
• Upwork Job ID: 1803535142361593535
• Last Price Increase: 2024-06-26
• Automatic offers:
• ZhenjaHorbach | Reviewer | 102959045
• suneox | Contributor | 102959046

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[JmillsExpensify]

Opening up to the community. This is a #vip-vsb initiative.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016857ff3bf2660def

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[suneox]

Proposal

Please re-state the problem that we are trying to solve in this issue.

inconsistent chat system message with LNH when lastMessageText is empty

What is the root cause of that problem?

We have a new implement show default system chat message from lines

App/src/components/ReportWelcomeText.tsx

Lines 146 to 150 in f24f4c3

	{isSystemChat && (
	<Text>
	<Text>{translate('reportActionsView.beginningOfChatHistorySystemDM')}</Text>
	</Text>
	)}

But when build side bar option we only have 2 condition show message when lastMessageText is empty from lines

App/src/libs/SidebarUtils.ts

Lines 386 to 392 in 7213c4b

	if (!lastMessageText) {
	// Here we get the beginning of chat history message and append the display name for each user, adding pronouns if there are any.
	// We also add a fullstop after the final name, the word "and" before the final name and commas between all previous names.
	lastMessageText = ReportUtils.isSelfDM(report)
	? Localize.translate(preferredLocale, 'reportActionsView.beginningOfChatHistorySelfDM')
	: Localize.translate(preferredLocale, 'reportActionsView.beginningOfChatHistory') +
	displayNamesWithTooltips

What changes do you think we should make in order to solve the problem?

We have to and more condition to show LHN preview message by isSystemChat

    lastMessageText = ReportUtils.isSelfDM(report)
        ? Localize.translate(preferredLocale, 'reportActionsView.beginningOfChatHistorySelfDM')
+       : ReportUtils.isSystemChat(report) ? Localize.translate(preferredLocale, 'reportActionsView.beginningOfChatHistorySystemDM')
        : Localize.translate(preferredLocale, 'reportActionsView.beginningOfChatHistory')

Before/After change

What alternative solutions did you explore? (Optional)

[ZhenjaHorbach]

Thank you @suneox

Your proposal makes sense to me
So I'm happy to go with this

The only thing I'm not sure is that we should use the ternary operator for several conditions
But these are technical details

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[suneox]

The only thing I'm not sure is that we should use the ternary operator for several conditions
But these are technical details

@ZhenjaHorbach ah this issue can check by eslint and update on PR

[melvin-bot]

@JmillsExpensify, @grgia, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[grgia]

@JmillsExpensify before I assign, what's the expected behavior here?

It seems like no chats have been sent in the example video chat. Do we want to use the Welcome Text as the LHN preview? Techically "This is the beginning of your chat .." is correct for these

[JmillsExpensify]

Yeah, I think we are actually going to standardize on the welcome text very soon. Isn't that what you are working on @danielrvidal?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@JmillsExpensify, @grgia, @ZhenjaHorbach Huh... This is 4 days overdue. Who can take care of this?

[grgia]

@danielrvidal bump on #43830 (comment)

[melvin-bot]

@JmillsExpensify, @grgia, @ZhenjaHorbach Still overdue 6 days?! Let's take care of this!

[suneox]

Hi @ZhenjaHorbach PR is ready for review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• set initial system chat message for LHN preview #44738

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Contributor)
• @ZhenjaHorbach requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@suneox / @ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
• [@suneox / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@suneox / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@suneox / @ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@suneox / @ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• set initial system chat message for LHN preview #44738

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Contributor)
• @ZhenjaHorbach requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@suneox / @ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
• [@suneox / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@suneox / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@suneox / @ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@suneox / @ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ZhenjaHorbach]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@suneox / @ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:

#41290

• [@suneox / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/41290/files#r1680686700

• [@suneox / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

NA

• [@suneox / @ZhenjaHorbach] Determine if we should create a regression test for this bug.

I'm not sure we need a regression test for this bug since it's a very minor issue.

• [@suneox / @ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

NA

[melvin-bot]

@JmillsExpensify, @suneox, @grgia, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ZhenjaHorbach]

Not overdue

@JmillsExpensify
Waiting for payment !
Can you help with that, please ?

[melvin-bot]

@JmillsExpensify, @suneox, @grgia, @ZhenjaHorbach Still overdue 6 days?! Let's take care of this!

[JmillsExpensify]

Payment summary:

Contributor: @suneox $250
Reviewer: @ZhenjaHorbach $250

[JmillsExpensify]

Both contributors paid via Upwork. Closing!