Allow system account chat to be listed in LHN, fix chat icons #41290

francoisl · 2024-04-30T03:01:33Z

Details

UI fixes for the system DM
Fixes the participants list, to make sure the title of the chat is just "Expensify" and the icon is only that of notifications@

Fixed Issues

$
PROPOSAL:

Tests / QA

Create a new account
When the onboarding modal opens, make sure that the report showing in the background is not the system DM
Choose any of the onboarding options
Find and open your system DM
Make sure it just shows the title as "Expensify", the text as "Welcome! Let's get you set up", without additional suggestions to create tasks and money requests
Make sure there is no "Join" button in the header

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-05-31.at.17.09.58.mov

MacOS: Desktop

trjExpensify · 2024-05-10T17:24:50Z

Popped a hold in the title as per here: https://expensify.slack.com/archives/C036QM0SLJK/p1715360388894099?thread_ts=1715336603.190319&cid=C036QM0SLJK

…account-cleanups2

…ify/App into francois-system-account-cleanups2

…account-cleanups2

melvin-bot · 2024-05-30T20:49:37Z

@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-05-31T14:29:13Z

src/pages/home/HeaderView.tsx


    // For 1:1 chat, we don't want to include currentUser as participants in order to not mark 1:1 chats as having multiple participants
    const participants = Object.keys(report?.participants ?? {})
        .map(Number)
-        .filter((accountID) => accountID !== session?.accountID || !isOneOnOneChat)
+        .filter((accountID) => accountID !== session?.accountID || (!isOneOnOneChat && !isSystemChat))


Shouldn't this be (!isOneOnOneChat || !isSystemChat)?

No, because !isOneOnOneChat will always be true for the systemChat, so we'd always end up including the current user in the participants list.

src/libs/SidebarUtils.ts

allroundexperts · 2024-05-31T14:37:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

N/A
The App crashes with error ReportActionUtils.getSortedReportActionsForDisplay is not defined

Android: mWeb Chrome

Screen.Recording.2024-05-31.at.8.44.07.PM.mov

iOS: Native

N/A

The App crashes with error ReportActionUtils.getSortedReportActionsForDisplay is not defined

iOS: mWeb Safari

Screen.Recording.2024-05-31.at.8.42.50.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-31.at.8.34.33.PM.mov

MacOS: Desktop

Screen.Recording.2024-05-31.at.8.40.33.PM.mov

allroundexperts · 2024-05-31T14:58:38Z

Is there something I must do for the system chat to appear? I created a new account and can only see the following:

Screen.Recording.2024-05-31.at.7.57.33.PM.mov

allroundexperts · 2024-05-31T15:36:27Z

Bug
System room name is missing in the RHN

allroundexperts · 2024-05-31T15:37:28Z

Also, do we need private notes here?

allroundexperts · 2024-05-31T15:41:50Z

BUG
Clicking on Expensify shows a not found error.

Screen.Recording.2024-05-31.at.8.41.07.PM.mov

NikkiWines · 2024-05-31T21:17:04Z

System room name is missing in the RHN
Clicking on Expensify shows a not found error.

Nice, thanks for catching those!

Also, do we need private notes here?

Hmm, I'm not sure, actually. @trjExpensify @francoisl, do you have thoughts about whether or not to include private notes in this chat?

francoisl · 2024-05-31T21:45:20Z

Also, do we need private notes here?

Hmm, I'm not sure, actually. @trjExpensify @francoisl, do you have thoughts about whether or not to include private notes in this chat?

I don't have a strong opinion on this, though I don't see a reason to hide them.

NikkiWines · 2024-05-31T22:45:03Z

Clicking on Expensify shows a not found error.

From this PR (#35385) it seems like we don't want to display the profile page for notifications@ so why don't we just update the report welcome text as follows?

NikkiWines · 2024-06-01T00:13:27Z

Updated!

Is there something I must do for the system chat to appear? I created a new account and can only see the following:

It's intentional that it doesn't show up in the LHN immediately but is findable by search

…account-cleanups2

allroundexperts

Working good now!

melvin-bot · 2024-06-01T18:26:47Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-06-01T18:26:50Z

🎯 @allroundexperts, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #42962.

techievivek

Looks good.

techievivek · 2024-06-03T14:01:27Z

do you have thoughts about whether or not to include private notes in this chat?

Yeah, we can skip for systems chats. This is meant mainly for chats with real users.

OSBotify · 2024-06-03T14:08:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-06T12:33:28Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ZhenjaHorbach · 2024-07-17T08:54:11Z

src/components/ReportWelcomeText.tsx

+                {isSystemChat && (
+                    <Text>
+                        <Text>{translate('reportActionsView.beginningOfChatHistorySystemDM')}</Text>
+                    </Text>
+                )}


This change caused this issue

We have implemented show default system chat message
But we din't add condition for system chat for sidebar

abdulrahuman5196 · 2024-09-14T19:53:46Z

This Pr caused issue where restricted expensify accounts where able to be added to group chat.
More information here #43841 (comment)

ahmedGaber93 · 2024-11-19T09:32:48Z

src/libs/OptionsListUtils.ts

-    const optionsToExclude: Option[] = [{login: CONST.EMAIL.NOTIFICATIONS}];
+    const optionsToExclude: Option[] = [];


Coming from here #49673, we decide to exclude CONST.EMAIL.NOTIFICATIONS again and it handled here #50937

Allow system account chat to be listed in LHN, fix chat icons

1cbeb47

francoisl mentioned this pull request Apr 30, 2024

Allow system account chat to be listed in LHN, fix chat icons #41127

Closed

51 tasks

Fix spanish copy, fix welcome title, hide Join button

feb523c

francoisl force-pushed the francois-system-account-cleanups2 branch from e1e223b to feb523c Compare April 30, 2024 21:13

don't exclude notifications@

087bae4

flodnv mentioned this pull request May 3, 2024

[Guided Setup Stage 2] Update HandleSpecialChatReportsOnMergeAccount to handle system DM #38770

Closed

4 tasks

francoisl and others added 2 commits May 3, 2024 12:14

Merge branch 'main' into francois-system-account-cleanups2

d5979e8

show system chat in LHN but don't focus on it when signing up

7f2c9db

NikkiWines self-assigned this May 7, 2024

Merge branch 'main' into francois-system-account-cleanups2

f92eed9

trjExpensify mentioned this pull request May 8, 2024

Feature/38774 expensify persona #41343

Merged

61 tasks

trjExpensify changed the title ~~Allow system account chat to be listed in LHN, fix chat icons~~ [Hold #392651] Allow system account chat to be listed in LHN, fix chat icons May 10, 2024

NikkiWines added 5 commits May 29, 2024 15:27

Merge branch 'main' of github.com:Expensify/App into francois-system-…

adaf3e7

…account-cleanups2

Merge branch 'francois-system-account-cleanups2' of github.com:Expens…

6c8f3c7

…ify/App into francois-system-account-cleanups2

lint/type/prettier

926d7af

fix showing participants for system dm

6158dd6

unify nomenclature

570851a

NikkiWines changed the title ~~[Hold #392651] Allow system account chat to be listed in LHN, fix chat icons~~ Allow system account chat to be listed in LHN, fix chat icons May 30, 2024

Merge branch 'main' of github.com:Expensify/App into francois-system-…

1648f61

…account-cleanups2

NikkiWines marked this pull request as ready for review May 30, 2024 20:49

NikkiWines requested a review from a team as a code owner May 30, 2024 20:49

melvin-bot bot removed the request for review from a team May 30, 2024 20:49

melvin-bot bot requested a review from techievivek May 30, 2024 20:49

trjExpensify requested a review from allroundexperts May 31, 2024 14:24

allroundexperts reviewed May 31, 2024

View reviewed changes

src/libs/SidebarUtils.ts Outdated Show resolved Hide resolved

fix report welcome message and details name

a02b8de

NikkiWines added 2 commits May 31, 2024 17:16

Merge branch 'main' of github.com:Expensify/App into francois-system-…

76fcf1e

…account-cleanups2

re-add dependency

a794af4

allroundexperts approved these changes Jun 1, 2024

View reviewed changes

melvin-bot bot requested a review from Gonals June 1, 2024 18:26

melvin-bot bot mentioned this pull request Jun 1, 2024

[HOLD for payment 2024-06-13] Payment issue for E/App PR#41290 #42962

Closed

techievivek approved these changes Jun 3, 2024

View reviewed changes

techievivek merged commit d7fd40a into main Jun 3, 2024
16 checks passed

techievivek deleted the francois-system-account-cleanups2 branch June 3, 2024 14:00

github-actions bot mentioned this pull request Jun 4, 2024

Deploy Checklist: New Expensify 2024-06-04 #43037

Closed

ShridharGoel mentioned this pull request Jun 4, 2024

[HOLD for payment 2024-06-20] Group chat - Member amount is 0 when creating group chat offline #43042

Closed

6 tasks

m-natarajan mentioned this pull request Jun 5, 2024

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] iOS - System chat - Chat with your setup specialist message not aligned and gets out of box #43115

Closed

6 tasks

bernhardoj mentioned this pull request Jun 18, 2024

[$250] Expensify personal - Not here page opens when opening Expensify profile from group member list #43841

Closed

6 tasks

bernhardoj mentioned this pull request Jul 3, 2024

"Expensify chat" is shown in contact list for "start chat" #44750

Closed

6 tasks

ZhenjaHorbach reviewed Jul 17, 2024

View reviewed changes

ZhenjaHorbach mentioned this pull request Jul 17, 2024

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Expensify chat - Incorrect LHN preview for Expensify chat #43830

Closed

6 tasks

ahmedGaber93 reviewed Nov 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow system account chat to be listed in LHN, fix chat icons #41290

Allow system account chat to be listed in LHN, fix chat icons #41290

francoisl commented Apr 30, 2024 •

edited by NikkiWines

Loading

trjExpensify commented May 10, 2024

melvin-bot bot commented May 30, 2024

allroundexperts May 31, 2024

NikkiWines May 31, 2024

allroundexperts commented May 31, 2024 •

edited

Loading

allroundexperts commented May 31, 2024

allroundexperts commented May 31, 2024 •

edited

Loading

allroundexperts commented May 31, 2024

allroundexperts commented May 31, 2024

NikkiWines commented May 31, 2024

francoisl commented May 31, 2024

NikkiWines commented May 31, 2024

NikkiWines commented Jun 1, 2024

allroundexperts left a comment

melvin-bot bot commented Jun 1, 2024

melvin-bot bot commented Jun 1, 2024

techievivek left a comment

techievivek commented Jun 3, 2024 •

edited

Loading

OSBotify commented Jun 3, 2024

OSBotify commented Jun 6, 2024

ZhenjaHorbach Jul 17, 2024

abdulrahuman5196 commented Sep 14, 2024

ahmedGaber93 Nov 19, 2024

		const optionsToExclude: Option[] = [{login: CONST.EMAIL.NOTIFICATIONS}];
		const optionsToExclude: Option[] = [];

Allow system account chat to be listed in LHN, fix chat icons #41290

Allow system account chat to be listed in LHN, fix chat icons #41290

Conversation

francoisl commented Apr 30, 2024 • edited by NikkiWines Loading

Details

Fixed Issues

Tests / QA

PR Author Checklist

Screenshots/Videos

trjExpensify commented May 10, 2024

melvin-bot bot commented May 30, 2024

allroundexperts May 31, 2024

Choose a reason for hiding this comment

NikkiWines May 31, 2024

Choose a reason for hiding this comment

allroundexperts commented May 31, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented May 31, 2024

allroundexperts commented May 31, 2024 • edited Loading

allroundexperts commented May 31, 2024

allroundexperts commented May 31, 2024

NikkiWines commented May 31, 2024

francoisl commented May 31, 2024

NikkiWines commented May 31, 2024

NikkiWines commented Jun 1, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jun 1, 2024

melvin-bot bot commented Jun 1, 2024

techievivek left a comment

Choose a reason for hiding this comment

techievivek commented Jun 3, 2024 • edited Loading

OSBotify commented Jun 3, 2024

OSBotify commented Jun 6, 2024

ZhenjaHorbach Jul 17, 2024

Choose a reason for hiding this comment

abdulrahuman5196 commented Sep 14, 2024

ahmedGaber93 Nov 19, 2024

Choose a reason for hiding this comment

francoisl commented Apr 30, 2024 •

edited by NikkiWines

Loading

allroundexperts commented May 31, 2024 •

edited

Loading

allroundexperts commented May 31, 2024 •

edited

Loading

techievivek commented Jun 3, 2024 •

edited

Loading