[HOLD for payment 2024-07-26] [$250] Features in Workspace LHN are not in the same order as in "More Features" #45549

yuwenmemon · 2024-07-17T01:10:19Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.5-12
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): All
Logs: N/A
Expensify/Expensify Issue URL:
Issue reported by: @zsgreenwald
Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1721165288016089

Action Performed:

Go to a workspace
Turn on all features in under "More features"
They should all appear in the LHN for the workspace
Observe that the order they are in does not match what's in "More features"

Expected Result:

The order of the items in the LHN should be in the same order as they are in "More features"

Actual Result:

The order of the items does not match the order in "More features"

Workaround:

Yes, this is a small polish bug.

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019d9f00389c515c84
Upwork Job ID: 1813380721244668134
Last Price Increase: 2024-07-17

Issue Owner

Current Issue Owner: @OfstadC

melvin-bot · 2024-07-17T01:10:28Z

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot · 2024-07-17T01:10:31Z

Job added to Upwork: https://www.upwork.com/jobs/~019d9f00389c515c84

melvin-bot · 2024-07-17T01:10:36Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

Krishna2323 · 2024-07-17T01:20:04Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Features in Workspace LHN are not in the same order as in "More Features"

What is the root cause of that problem?

Accounting field is placed before Report Fields

App/src/pages/workspace/WorkspaceInitialPage.tsx

Lines 287 to 305 in 39e0f95

    
           if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED]) { 
        
               protectedCollectPolicyMenuItems.push({ 
        
                   translationKey: 'workspace.common.accounting', 
        
                   icon: Expensicons.Sync, 
        
                   action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.POLICY_ACCOUNTING.getRoute(policyID)))), 
        
                   // brickRoadIndicator should be set when API will be ready 
        
                   brickRoadIndicator: undefined, 
        
                   routeName: SCREENS.WORKSPACE.ACCOUNTING.ROOT, 
        
               }); 
        
           } 
        
           if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_REPORT_FIELDS_ENABLED]) { 
        
               protectedCollectPolicyMenuItems.push({ 
        
                   translationKey: 'workspace.common.reportFields', 
        
                   icon: Expensicons.Pencil, 
        
                   action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_REPORT_FIELDS.getRoute(policyID)))), 
        
                   routeName: SCREENS.WORKSPACE.REPORT_FIELDS, 
        
               }); 
        
           }

What changes do you think we should make in order to solve the problem?

Place Accounting field is after Report Fields.

  
 if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_REPORT_FIELDS_ENABLED]) { 
     protectedCollectPolicyMenuItems.push({ 
         translationKey: 'workspace.common.reportFields', 
         icon: Expensicons.Pencil, 
         action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_REPORT_FIELDS.getRoute(policyID)))), 
         routeName: SCREENS.WORKSPACE.REPORT_FIELDS, 
     }); 
 } 

 if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED]) { 
     protectedCollectPolicyMenuItems.push({ 
         translationKey: 'workspace.common.accounting', 
         icon: Expensicons.Sync, 
         action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.POLICY_ACCOUNTING.getRoute(policyID)))), 
         // brickRoadIndicator should be set when API will be ready 
         brickRoadIndicator: undefined, 
         routeName: SCREENS.WORKSPACE.ACCOUNTING.ROOT, 
     }); 
 }

What alternative solutions did you explore? (Optional)

POC:

yuwenmemon · 2024-07-17T04:16:49Z

Thanks @Krishna2323 looks good.

melvin-bot · 2024-07-17T04:17:03Z

❌ There was an error making the offer to @Krishna2323 for the Contributor role. The BZ member will need to manually hire the contributor.

nkdengineer · 2024-07-17T04:38:14Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The order of the items does not match the order in "More features"

What is the root cause of that problem?

We push the accounting option before the report field option

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 287 in 10d04a8

if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED]) {

What changes do you think we should make in order to solve the problem?

To make the code cleaner, we can create a collectMenuItems that contains all feature items

const collectMenuItems: Record<PolicyFeatureName,WorkspaceMenuItem> = {
    [CONST.POLICY.MORE_FEATURES.ARE_DISTANCE_RATES_ENABLED]: {
        translationKey: 'workspace.common.distanceRates',
        icon: Expensicons.Car,
        action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_DISTANCE_RATES.getRoute(policyID)))),
        routeName: SCREENS.WORKSPACE.DISTANCE_RATES,
    },
    [CONST.POLICY.MORE_FEATURES.ARE_WORKFLOWS_ENABLED]: {
        translationKey: 'workspace.common.workflows',
        icon: Expensicons.Workflows,
        action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS.getRoute(policyID)))),
        routeName: SCREENS.WORKSPACE.WORKFLOWS,
        brickRoadIndicator: !isEmptyObject(policy?.errorFields?.reimburser ?? {}) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,
    },
    [CONST.POLICY.MORE_FEATURES.ARE_CATEGORIES_ENABLED]: {
        translationKey: 'workspace.common.categories',
        icon: Expensicons.Folder,
        action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_CATEGORIES.getRoute(policyID)))),
        brickRoadIndicator: hasPolicyCategoryError ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,
        routeName: SCREENS.WORKSPACE.CATEGORIES,
    },
    [CONST.POLICY.MORE_FEATURES.ARE_TAGS_ENABLED]: {
        translationKey: 'workspace.common.tags',
        icon: Expensicons.Tag,
        action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_TAGS.getRoute(policyID)))),
        routeName: SCREENS.WORKSPACE.TAGS,
    },
    [CONST.POLICY.MORE_FEATURES.ARE_TAXES_ENABLED]: {
        translationKey: 'workspace.common.taxes',
        icon: Expensicons.Coins,
        action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_TAXES.getRoute(policyID)))),
        routeName: SCREENS.WORKSPACE.TAXES,
        brickRoadIndicator: PolicyUtils.hasTaxRateError(policy) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,
    },
    [CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED]: {
        translationKey: 'workspace.common.accounting',
        icon: Expensicons.Sync,
        action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.POLICY_ACCOUNTING.getRoute(policyID)))),
        // brickRoadIndicator should be set when API will be ready
        brickRoadIndicator: undefined,
        routeName: SCREENS.WORKSPACE.ACCOUNTING.ROOT,
    },
    [CONST.POLICY.MORE_FEATURES.ARE_EXPENSIFY_CARDS_ENABLED]: {
        translationKey: 'workspace.common.expensifyCard',
        icon: Expensicons.CreditCard,
        action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policyID)))),
        routeName: SCREENS.WORKSPACE.EXPENSIFY_CARD,
    },
    [CONST.POLICY.MORE_FEATURES.ARE_REPORT_FIELDS_ENABLED]: {
        translationKey: 'workspace.common.reportFields',
        icon: Expensicons.Pencil,
        action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_REPORT_FIELDS.getRoute(policyID)))),
        routeName: SCREENS.WORKSPACE.REPORT_FIELDS,
    },
}

And then get protectedCollectPolicyMenuItems by getting the feature that is enabled in collectMenuItems. With this change, we can remove all if conditions that we used to push the feature item.

const protectedCollectPolicyMenuItems: WorkspaceMenuItem[] = (Object.keys(featureStates ?? {}) as PolicyFeatureName[]).filter((featureKey) => featureStates[featureKey]).map((featureKey) => {
    return collectMenuItems[featureKey];
});

After that, we only need to re-order the feature here

const policyFeatureStates = useMemo(
    () => ({
        [CONST.POLICY.MORE_FEATURES.ARE_DISTANCE_RATES_ENABLED]: policy?.areDistanceRatesEnabled,
        [CONST.POLICY.MORE_FEATURES.ARE_EXPENSIFY_CARDS_ENABLED]: policy?.areExpensifyCardsEnabled,
        [CONST.POLICY.MORE_FEATURES.ARE_WORKFLOWS_ENABLED]: policy?.areWorkflowsEnabled,
        [CONST.POLICY.MORE_FEATURES.ARE_CATEGORIES_ENABLED]: policy?.areCategoriesEnabled,
        [CONST.POLICY.MORE_FEATURES.ARE_TAGS_ENABLED]: policy?.areTagsEnabled,
        [CONST.POLICY.MORE_FEATURES.ARE_TAXES_ENABLED]: policy?.tax?.trackingEnabled,
        [CONST.POLICY.MORE_FEATURES.ARE_REPORT_FIELDS_ENABLED]: policy?.areReportFieldsEnabled,
        [CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED]: policy?.areConnectionsEnabled,
    }),
    [policy],
) as PolicyFeatureStates;

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 102 in 10d04a8

const policyFeatureStates = useMemo(

What alternative solutions did you explore? (Optional)

nkdengineer · 2024-07-17T04:40:15Z

@yuwenmemon Sorry for the late, can you please take a look at my proposal here? That can make the code cleaner and we only need to re-order in policyFeatureStates which is easier to keep track.

kaushiktd · 2024-07-17T05:00:05Z

@yuwenmemon I noticed that in my application currently "report field" feature not show as in you. Could you please guide me on how i get it

Krishna2323 · 2024-07-17T05:15:40Z

@yuwenmemon @sobitneupane, PR ready for review.

melvin-bot · 2024-07-19T19:26:57Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-07-19T19:27:02Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Features in Workspace LHN are not in the same order as in "More Features". #45555

If no regressions arise, payment will be issued on 2024-07-26. 🎊

For reference, here are some details about the assignees on this issue:

@sobitneupane requires payment through NewDot Manual Requests
@Krishna2323 requires payment (Needs manual offer from BZ)

melvin-bot · 2024-07-19T19:27:03Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

OfstadC · 2024-07-26T15:20:03Z

Adding @CortneyOfstad in since this needs a manual offer and i'm out today

CortneyOfstad · 2024-07-26T15:27:37Z

@sobitneupane please complete the checklist as soon as possible, so there is no delay in payment — thank you!

@Krishna2323 — I sent you an offer in Upwork, please let me know once you accept and I can get that paid ASAP. Thank you!

Krishna2323 · 2024-07-26T15:30:38Z

@CortneyOfstad accepted, thanks.

CortneyOfstad · 2024-07-26T15:57:39Z

Thanks @Krishna2323 – contract paid!

melvin-bot · 2024-07-26T18:02:49Z

Payment Summary

Upwork Job

Reviewer: @sobitneupane owed $250 via NewDot
ROLE: @Krishna2323 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@CortneyOfstad)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1813380721244668134/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

sobitneupane · 2024-07-29T10:01:54Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#43896 and #43943

[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#43896 (comment) and #43943 (comment)

[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not required.

[@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

sobitneupane · 2024-07-29T10:03:32Z

Regression Test Proposal:

Go to a workspace
Turn on all features in under "More features"
They should all appear in the LHN for the workspace
Verify that the order of the items in the LHN is in the same order as they are in "More features"

Do we agree 👍 or 👎

yuwenmemon · 2024-07-29T15:55:56Z

Looks great @sobitneupane

melvin-bot · 2024-07-29T18:25:43Z

@yuwenmemon, @CortneyOfstad, @OfstadC, @sobitneupane, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

OfstadC · 2024-07-30T12:01:04Z

Thanks @sobitneupane !

OfstadC · 2024-07-30T12:06:01Z

https://github.com/Expensify/Expensify/issues/416301

@CortneyOfstad can you please finish the payment while i'm OoO today

CortneyOfstad · 2024-07-31T13:34:05Z

Payment Summary

@Krishna2323 — paid $250 via Upwork
@sobitneupane — to be paid $250 via NewDot

JmillsExpensify · 2024-08-23T17:19:48Z

$250 approved for @sobitneupane

yuwenmemon added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor labels Jul 17, 2024

melvin-bot bot assigned OfstadC Jul 17, 2024

yuwenmemon assigned yuwenmemon and unassigned OfstadC Jul 17, 2024

melvin-bot bot changed the title ~~Features in Workspace LHN are not in the same order as in "More Features"~~ [$250] Features in Workspace LHN are not in the same order as in "More Features" Jul 17, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 17, 2024

melvin-bot bot assigned sobitneupane Jul 17, 2024

yuwenmemon assigned OfstadC Jul 17, 2024

yuwenmemon assigned Krishna2323 Jul 17, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 17, 2024

Krishna2323 mentioned this issue Jul 17, 2024

fix: Features in Workspace LHN are not in the same order as in "More Features". #45555

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 17, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 19, 2024

melvin-bot bot changed the title ~~[$250] Features in Workspace LHN are not in the same order as in "More Features"~~ [HOLD for payment 2024-07-26] [$250] Features in Workspace LHN are not in the same order as in "More Features" Jul 19, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Jul 19, 2024

OfstadC assigned CortneyOfstad Jul 26, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 26, 2024

melvin-bot bot added the Overdue label Jul 29, 2024

This was referenced Jul 29, 2024

Feature: Create the main WorkspaceReportFieldsPage page #43943

Merged

Integrate Report fields to the More features page #43896

Merged

melvin-bot bot removed the Overdue label Jul 30, 2024

CortneyOfstad closed this as completed Jul 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-07-26] [$250] Features in Workspace LHN are not in the same order as in "More Features" #45549

[HOLD for payment 2024-07-26] [$250] Features in Workspace LHN are not in the same order as in "More Features" #45549

yuwenmemon commented Jul 17, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 17, 2024

melvin-bot bot commented Jul 17, 2024

melvin-bot bot commented Jul 17, 2024

Krishna2323 commented Jul 17, 2024 •

edited

Loading

yuwenmemon commented Jul 17, 2024

melvin-bot bot commented Jul 17, 2024

nkdengineer commented Jul 17, 2024

nkdengineer commented Jul 17, 2024

kaushiktd commented Jul 17, 2024

Krishna2323 commented Jul 17, 2024

melvin-bot bot commented Jul 19, 2024

melvin-bot bot commented Jul 19, 2024

melvin-bot bot commented Jul 19, 2024

OfstadC commented Jul 26, 2024

CortneyOfstad commented Jul 26, 2024

Krishna2323 commented Jul 26, 2024

CortneyOfstad commented Jul 26, 2024

melvin-bot bot commented Jul 26, 2024

sobitneupane commented Jul 29, 2024

sobitneupane commented Jul 29, 2024

yuwenmemon commented Jul 29, 2024

melvin-bot bot commented Jul 29, 2024

OfstadC commented Jul 30, 2024

OfstadC commented Jul 30, 2024

CortneyOfstad commented Jul 31, 2024

JmillsExpensify commented Aug 23, 2024

[HOLD for payment 2024-07-26] [$250] Features in Workspace LHN are not in the same order as in "More Features" #45549

[HOLD for payment 2024-07-26] [$250] Features in Workspace LHN are not in the same order as in "More Features" #45549

Comments

yuwenmemon commented Jul 17, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jul 17, 2024

melvin-bot bot commented Jul 17, 2024

melvin-bot bot commented Jul 17, 2024

Krishna2323 commented Jul 17, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

yuwenmemon commented Jul 17, 2024

melvin-bot bot commented Jul 17, 2024

nkdengineer commented Jul 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

nkdengineer commented Jul 17, 2024

kaushiktd commented Jul 17, 2024

Krishna2323 commented Jul 17, 2024

melvin-bot bot commented Jul 19, 2024

melvin-bot bot commented Jul 19, 2024

melvin-bot bot commented Jul 19, 2024

OfstadC commented Jul 26, 2024

CortneyOfstad commented Jul 26, 2024

Krishna2323 commented Jul 26, 2024

CortneyOfstad commented Jul 26, 2024

melvin-bot bot commented Jul 26, 2024

Payment Summary

BugZero Checklist (@CortneyOfstad)

sobitneupane commented Jul 29, 2024

sobitneupane commented Jul 29, 2024

yuwenmemon commented Jul 29, 2024

melvin-bot bot commented Jul 29, 2024

OfstadC commented Jul 30, 2024

OfstadC commented Jul 30, 2024

CortneyOfstad commented Jul 31, 2024

Payment Summary

JmillsExpensify commented Aug 23, 2024

yuwenmemon commented Jul 17, 2024 •

edited by melvin-bot bot

Loading

Krishna2323 commented Jul 17, 2024 •

edited

Loading