Feature: Create the main WorkspaceReportFieldsPage page #43943

waterim · 2024-06-18T18:16:23Z

Details

Added new WorkspaceReportFieldsPage

Fixed Issues

$ #43677
PROPOSAL: N/A

Tests

NOTE:
We are not able to open ReportFields page from the more features at this moment

Also don't forget to remove/change featureName={CONST.POLICY.MORE_FEATURES.ARE_REPORTFIELDS_ENABLED} in <AccessOrNotFoundWrapper/> to existed feature enabled, because page will be not available for you as this feature also will be handled in another PR

Navigate to Settings -> Workspaces -> Select workspace
Update manually the url with '/reportFields' to look like this: settings/workspaces/5DB2701CE7E6A19A/reportFields
Observe an empty page for report fields with create button

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

None

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

melvin-bot · 2024-06-19T11:59:36Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

waterim · 2024-06-19T12:03:49Z

Waiting for translations, but its ready for a code review

shubham1206agra · 2024-06-21T08:21:44Z

@waterim Can you merge main?

…ields-main-page

waterim · 2024-06-21T11:35:02Z

@shubham1206agra Updated

shubham1206agra · 2024-06-21T14:17:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx

waterim · 2024-06-24T12:07:33Z

@mountiny updated!

mountiny

Thanks

src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx

mountiny

Thanks!

OSBotify · 2024-06-24T13:37:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-25T20:09:28Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.2-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kosmydel · 2024-07-02T14:40:53Z

src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx

+            <ScreenWrapper
+                includeSafeAreaPaddingBottom={false}
+                style={[styles.defaultModalContainer]}
+                testID={WorkspaceReportFieldsPage.displayName}
+                shouldShowOfflineIndicatorInWideScreen
+                offlineIndicatorStyle={styles.mtAuto}
+            >
+                <HeaderWithBackButton
+                    icon={Illustrations.Pencil}
+                    title={translate('workspace.common.reportFields')}
+                    shouldShowBackButton={isSmallScreenWidth}
+                >
+                    {!isSmallScreenWidth && getHeaderButtons()}
+                </HeaderWithBackButton>
+                {isSmallScreenWidth && <View style={[styles.pl5, styles.pr5]}>{getHeaderButtons()}</View>}


Why we didn't use the WorkspacePageWithSections component? It is used in almost every workspace-related page.

kosmydel · 2024-07-02T14:54:01Z

We've also forgotten to add the screen to the PolicyRoutes list:
| typeof SCREENS.WORKSPACE.REPORT_FIELDS

App/src/pages/workspace/withPolicy.tsx

Line 15 in 8140b01

type PolicyRoute = RouteProp<

OSBotify · 2024-07-03T19:38:42Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T10:57:05Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

sobitneupane · 2024-07-29T10:00:36Z

This PR along with #43896 is responsible for this minor bug.

report fields main page

b206430

waterim marked this pull request as ready for review June 19, 2024 11:59

waterim requested a review from a team as a code owner June 19, 2024 11:59

melvin-bot bot requested review from shubham1206agra and removed request for a team June 19, 2024 11:59

waterim added 4 commits June 19, 2024 14:15

changed icons

67563a1

fix UI

18999b8

fix selection

321b15b

tranlsations

526ba21

Merge remote-tracking branch 'upstream/main' into feat-43677-report-f…

959b774

…ields-main-page

shubham1206agra approved these changes Jun 21, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny June 21, 2024 14:19

mountiny assigned waterim Jun 24, 2024

mountiny requested changes Jun 24, 2024

View reviewed changes

src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx Outdated Show resolved Hide resolved

remove tag code

25fe2d2

mountiny previously approved these changes Jun 24, 2024

View reviewed changes

src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx Outdated Show resolved Hide resolved

updated CONST for report fields

505ea66

waterim dismissed mountiny’s stale review via 505ea66 June 24, 2024 12:10

mountiny approved these changes Jun 24, 2024

View reviewed changes

mountiny merged commit 5161249 into Expensify:main Jun 24, 2024
15 checks passed

github-actions bot mentioned this pull request Jun 25, 2024

Deploy Checklist: New Expensify 2024-06-25 #44406

Closed

92 tasks

kosmydel reviewed Jul 2, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Jul 3, 2024

[HOLD for payment 2024-07-10] [Report Fields] [External] Create the main WorkspaceReportFieldsPage page #43677

Closed

mollfpr mentioned this pull request Jul 5, 2024

fix: Report fields row is not grayed out when added/edited offline #44827

Closed

51 tasks

This was referenced Jul 29, 2024

Integrate Report fields to the More features page #43896

Merged

[HOLD for payment 2024-07-26] [$250] Features in Workspace LHN are not in the same order as in "More Features" #45549

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Create the main WorkspaceReportFieldsPage page #43943

Feature: Create the main WorkspaceReportFieldsPage page #43943

waterim commented Jun 18, 2024 •

edited

Loading

melvin-bot bot commented Jun 19, 2024

waterim commented Jun 19, 2024 •

edited

Loading

shubham1206agra commented Jun 21, 2024

waterim commented Jun 21, 2024

shubham1206agra commented Jun 21, 2024

waterim commented Jun 24, 2024

mountiny left a comment

mountiny left a comment

OSBotify commented Jun 24, 2024

OSBotify commented Jun 25, 2024

kosmydel Jul 2, 2024

kosmydel commented Jul 2, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 10, 2024

sobitneupane commented Jul 29, 2024

Feature: Create the main WorkspaceReportFieldsPage page #43943

Feature: Create the main WorkspaceReportFieldsPage page #43943

Conversation

waterim commented Jun 18, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 19, 2024

waterim commented Jun 19, 2024 • edited Loading

shubham1206agra commented Jun 21, 2024

waterim commented Jun 21, 2024

shubham1206agra commented Jun 21, 2024

Reviewer Checklist

Screenshots/Videos

waterim commented Jun 24, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 24, 2024

OSBotify commented Jun 25, 2024

kosmydel Jul 2, 2024

Choose a reason for hiding this comment

kosmydel commented Jul 2, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 10, 2024

sobitneupane commented Jul 29, 2024

waterim commented Jun 18, 2024 •

edited

Loading

waterim commented Jun 19, 2024 •

edited

Loading