[HOLD for payment 2024-10-29] [$250] LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #47874

IuliiaHerets · 2024-08-22T16:54:55Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): nathanmulugetatesting+1097@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

Navigate to Old Dot and sign up with a new account
Go to settings > Account and validate the account
Navigate to staging.new.expensify.com and sign in with the same account signed in on Old Dot
Create a workspace and name it as "Workspace 1" to make things easier to notice
Go to workspace editor and enable workflows
Go to workflows and enable delayed submission and set it to manual and enable approvals also
Create another workspace and name it as "Workspace 2"
Navigate to Workspace 1 chat and create a manual expense
Click on submit but do not click on approve
Navigate to Old dot and refresh the page
Go to reports and click on the expense created on ND
Click on detail and change the workspace from workspace 1 to workspace 2
Go to New dot and wait for a few seconds for the change to take effect
After the changes took effect (Workspace 1 will not have RBR on the LHN and instead workspace 2 will have RBR and the expense will be moved to it)
Go to workspace chat 2 and create a scan expense with a normal picture so that it will throw error after it is done scanning
Observe the LHN of workspace chat 1 on the LHN

Expected Result:

No RBR will be present on the workspace chat 1

Actual Result:

RBR is present on workspace chat 1 even if the scan expense which has an error is on the workspace chat 2. When opening the workspace chat 1 with RBR there is nothing inside the workspace chat.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6579370_1724341239931.bandicam_2024-08-22_18-11-28-203.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015a69a9ddbd29631a
Upwork Job ID: 1828511929613408564
Last Price Increase: 2024-09-03

Issue Owner

Current Issue Owner: @garrettmknight

melvin-bot · 2024-08-22T16:55:04Z

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets · 2024-08-22T16:55:32Z

We think that this bug might be related to #wave-collect - Release 1

IuliiaHerets · 2024-08-22T16:55:51Z

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

melvin-bot · 2024-08-27T18:26:36Z

@garrettmknight Eep! 4 days overdue now. Issues have feelings too...

melvin-bot · 2024-08-27T19:16:32Z

Job added to Upwork: https://www.upwork.com/jobs/~015a69a9ddbd29631a

garrettmknight · 2024-08-27T19:16:37Z

Reproduced, opening up. Not sure if this is BE or FE so starting with External.

melvin-bot · 2024-08-27T19:16:37Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

melvin-bot · 2024-09-02T18:28:59Z

@garrettmknight, @ntdiary Eep! 4 days overdue now. Issues have feelings too...

SIMalik · 2024-09-03T04:57:36Z

Proposal

Please re-state the problem that we are trying to solve in this issue.
The Left-Hand Navigation (LHN) - Red Brick Road (RBR) indicator is incorrectly appearing in a workspace chat due to an error originating in a different workspace.

What is the root cause of that problem?
At Step-9, during the SubmitReport response, the following REPORTPREVIEW action was received for iouReportID: "5726784747188717" in Workspace 77-1: Complete SubmitReport Response.

        {
            "key": "reportActions_2380165600597457",
            "onyxMethod": "merge",
            "value": {
                "5238883410418754601": {
                    "actionName": "REPORTPREVIEW",
                    "actorAccountID": 18253981,
                    "avatar": "https:\/\/[d2k5nsl2zxldvw.cloudfront.net](http://d2k5nsl2zxldvw.cloudfront.net/)\/images\/avatars\/default-avatar_14.png",
                    "childCommenterCount": 0,
                    "childLastActorAccountID": 18253981,
                    "childLastMoneyRequestComment": "",
                    "childLastReceiptTransactionIDs": "",
                    "childLastVisibleActionCreated": "",
                    "childMoneyRequestCount": 1,
                    "childOldestFourAccountIDs": "",
                    "childRecentReceiptTransactionIDs": [],
                    "childReportNotificationPreference": "hidden",
                    "childType": "expense",
                    "childVisibleActionCount": 0,
                    "created": "2024-09-02 05:16:26.449",
                    "lastModified": "2024-09-02 05:16:26.449",
                    "message": [
                        {
                            "html": "Workspace 77-1 owes Rs\u00a05.00",
                            "text": "Workspace 77-1 owes Rs\u00a05.00",
                            "type": "COMMENT",
                            "whisperedTo": []
                        }
                    ],
                    "originalMessage": {
                        "lastModified": "2024-09-02 05:16:26.449",
                        "linkedReportID": "5726784747188717"
                    },
                    "person": [
                        {
                            "style": "strong",
                            "text": "O77F O77L",
                            "type": "TEXT"
                        }
                    ],
                    "reportActionID": "5238883410418754601",
                    "shouldShow": true
                }

At Step-14, the reportActionID: "5238883410418754601" was marked as deleted in Workspace 77-1: [Complete OpenReport Response]

                    "message": [
                        {
                            "type": "COMMENT",
                            "html": "",
                            "text": "",
                            "isEdited": false,
                            "whisperedTo": [],
                            "isDeletedParentAction": false,
                            "deleted": "2024-09-02 05:40:23.154"
                        }
                    ],
                    "originalMessage": {
                        "deleted": "2024-09-02 05:40:23.154",
                        "lastModified": "2024-09-02 05:16:26.449",
                        "linkedReportID": "5726784747188717"
                    },

Simultaneously, the iouReport (ID: "5726784747188717") was shifted to Workspace 77-2 with a new reportActionID: 7661044324410620555. [Complete OpenReport Response]

However, the deleted reportActionID: "5238883410418754601" remains linked to Workspace 77-1. Now when Workspace77-1 try process it, it follows the following steps to find the errors

App/src/libs/OptionsListUtils.ts

Line 744 in 2c04129

result.allReportErrors = getAllReportErrors(report, reportActions);

App/src/libs/OptionsListUtils.ts

Line 492 in 2c04129

} else if (ReportUtils.hasSmartscanError(Object.values(reportActions ?? {}))) {

App/src/libs/ReportUtils.ts

Line 7067 in 2c04129

    
           const IOUReportID = ReportActionsUtils.getIOUReportIDFromReportActionPreview(action);

And at following line it has wrongly picked the linkedReportID: "5726784747188717" which is an ID of iouReport and has been shifted in second Workspace 77-2

App/src/libs/ReportActionsUtils.ts

Line 921 in 2c04129

    
           return isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW) ? getOriginalMessage(reportAction)?.linkedReportID ?? '-1' : '-1';

Due to this wrong IOUReportID 5726784747188717 of Workspace 77-2 following line return true and causing to show RBR

shouldShowRBRForMissingSmartscanFields(IOUReportID)

App/src/libs/ReportUtils.ts

Line 7068 in 2c04129

    
           const isReportPreviewError = ReportActionsUtils.isReportPreviewAction(action) && shouldShowRBRForMissingSmartscanFields(IOUReportID) && !isSettled(IOUReportID);

What changes do you think we should make in order to solve the problem?
Replace

App/src/libs/ReportUtils.ts

Lines 7062 to 7063 in 2c04129

    
           function hasSmartscanError(reportActions: ReportAction[]) { 
        
               return reportActions.some((action) => {

With

function hasSmartscanError(reportActions: ReportAction[]) {
    const nonDeletedReportActions = reportActions.filter(action => !ReportActionsUtils.isDeletedAction(action));

    return nonDeletedReportActions.some((action) => {

What alternative solutions did you explore?
If we expect getIOUReportIDFromReportActionPreview to always return a non-deleted reportAction ID, we should modify the function directly.

Replace

App/src/libs/ReportActionsUtils.ts

Lines 917 to 922 in 2c04129

    
           /** 
        
            * Get the iouReportID for a given report action. 
        
            */ 
        
           function getIOUReportIDFromReportActionPreview(reportAction: OnyxEntry<ReportAction>): string { 
        
               return isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW) ? getOriginalMessage(reportAction)?.linkedReportID ?? '-1' : '-1'; 
        
           }

With

 /**
  * Get the iouReportID for a given report action.
 */
function getIOUReportIDFromReportActionPreview(reportAction: OnyxEntry<ReportAction>): string {
    return isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW) && !isDeletedAction(reportAction)? getOriginalMessage(reportAction)?.linkedReportID ?? '-1' : '-1';
}

After Code Change:
Local:

melvin-bot · 2024-09-03T04:57:39Z

📣 @SIMalik! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

github-actions · 2024-09-03T04:57:51Z

@SIMalik Your proposal will be dismissed because you did not follow the proposal template.

melvin-bot · 2024-09-03T16:00:20Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

ntdiary · 2024-09-04T11:14:58Z

Under review. can provide an update in about 12 hours.

ntdiary · 2024-09-05T05:11:00Z

@SIMalik, curious how did you start analyzing from the code below? Which component in the OP called this createOption function?

App/src/libs/OptionsListUtils.ts

Line 744 in 2c04129

result.allReportErrors = getAllReportErrors(report, reportActions);

As for the solution, if we decide to modify hasSmartscanError, I would prefer to

function hasSmartscanError(reportActions: ReportAction[]) {
    return reportActions.some((action) => {
        if (!ReportActionsUtils.isDeletedAction(action)) {
            return false
        }

// or 
function hasSmartscanError(reportActions: ReportAction[]) {
    return reportActions.some((action) => {
        if (!ReportActionsUtils.shouldReportActionBeVisible(action, action.reportActionID)) {
            return false
        }

unlike when displaying the message list, we didn't filter out the invisible messages when collecting all errors for the report.

App/src/libs/OptionsListUtils.ts

Lines 467 to 469 in 2c04129

    
            * Get an object of error messages keyed by microtime by combining all error objects related to the report. 
        
            */ 
        
           function getAllReportErrors(report: OnyxEntry<Report>, reportActions: OnyxEntry<ReportActions>): OnyxCommon.Errors {

message list logic:

App/src/pages/home/report/ReportActionsList.tsx

Lines 190 to 200 in 2c04129

    
           const sortedVisibleReportActions = useMemo( 
        
               () => 
        
                   sortedReportActions.filter( 
        
                       (reportAction) => 
        
                           (isOffline || 
        
                               ReportActionsUtils.isDeletedParentAction(reportAction) || 
        
                               reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || 
        
                               reportAction.errors) && 
        
                           ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID), 
        
                   ), 
        
               [sortedReportActions, isOffline],

Additionally, these two RBRs should also not be displayed when switching to workspace 1

cc @garrettmknight

melvin-bot · 2024-09-05T18:00:04Z

@garrettmknight @ntdiary this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

SIMalik · 2024-09-05T20:29:01Z

@garrettmknight @ntdiary

@SIMalik, curious how did you start analyzing from the code below? Which component in the OP called this createOption function?

The getAllReportErrors function is called in multiple parts of the app. Specifically, when we click on a scanned expense that has or will have violations, it follows the following path to trigger the function.

App/src/hooks/useReportIDs.tsx

Lines 98 to 114 in 156b8b0

    
           const getOrderedReportIDs = useCallback( 
        
               (currentReportID?: string) => 
        
                   SidebarUtils.getOrderedReportIDs( 
        
                       currentReportID ?? null, 
        
                       chatReports, 
        
                       betas, 
        
                       policies, 
        
                       priorityMode, 
        
                       allReportActions, 
        
                       transactionViolations, 
        
                       activeWorkspaceID, 
        
                       policyMemberAccountIDs, 
        
                   ), 
        
               // we need reports draft in deps array for reloading of list when reportsDrafts will change 
        
               // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps 
        
               [chatReports, betas, policies, priorityMode, allReportActions, transactionViolations, activeWorkspaceID, policyMemberAccountIDs, reportsDrafts], 
        
           );

App/src/libs/SidebarUtils.ts

Line 108 in 156b8b0

    
           const allReportErrors = OptionsListUtils.getAllReportErrors(report, reportActions) ?? {};

App/src/libs/OptionsListUtils.ts

Line 492 in 2c04129

} else if (ReportUtils.hasSmartscanError(Object.values(reportActions ?? {}))) {

scanned_violation2.mp4

As for the solution, if we decide to modify hasSmartscanError, I would prefer to
function hasSmartscanError(reportActions: ReportAction[]) {
return reportActions.some((action) => {
if (!ReportActionsUtils.isDeletedAction(action)) {
return false
}
// or
function hasSmartscanError(reportActions: ReportAction[]) {
return reportActions.some((action) => {
if (!ReportActionsUtils.shouldReportActionBeVisible(action, action.reportActionID)) {
return false
}

Yes, we can modify the function

App/src/libs/ReportUtils.ts

Lines 7075 to 7080 in 156b8b0

    
           function hasSmartscanError(reportActions: ReportAction[]) { 
        
               return reportActions.some((action) => { 
        
                   if (!ReportActionsUtils.isSplitBillAction(action) && !ReportActionsUtils.isReportPreviewAction(action)) { 
        
                       return false; 
        
                   } 
        
                   const IOUReportID = ReportActionsUtils.getIOUReportIDFromReportActionPreview(action);

to:

function hasSmartscanError(reportActions: ReportAction[]) {
    return reportActions.some((action) => {
        if ((!ReportActionsUtils.isSplitBillAction(action) && !ReportActionsUtils.isReportPreviewAction(action)) || ReportActionsUtils.isDeletedAction(action)) {
            return false;
        }
        const IOUReportID = ReportActionsUtils.getIOUReportIDFromReportActionPreview(action);

Additionally, these two RBRs should also not be displayed when switching to workspace 1

The RBR for Workspace 1 is no longer displayed.
Left Bottom RBR:
This seems to be a separate issue, unrelated to the workspace. The RBR appears in other cases as well, as shown in the video. However, if you'd prefer to address it here, I can investigate further. Otherwise, we can raise a separate issue for it.

47874_RBR_Left_bottom.mp4

ntdiary · 2024-09-09T13:56:43Z

OK, I think we can move forward with @SIMalik's proposal. To summarize briefly, the cause of this issue is that we didn't filter out the deleted reportActions when showing a workspace's RBR.

App/src/libs/OptionsListUtils.ts

Lines 467 to 469 in 2c04129

    
            * Get an object of error messages keyed by microtime by combining all error objects related to the report. 
        
            */ 
        
           function getAllReportErrors(report: OnyxEntry<Report>, reportActions: OnyxEntry<ReportActions>): OnyxCommon.Errors {

So, we can fix this specific scan issue by applying the filter condition in hasSmartscanError, So far, I haven’t found any potential regressions this might cause:

function hasSmartscanError(reportActions: ReportAction[]) {
    return reportActions.some((action) => {
        if ((!ReportActionsUtils.isSplitBillAction(action) && !ReportActionsUtils.isReportPreviewAction(action)) || ReportActionsUtils.isDeletedAction(action)) {
            return false;
        }
        const IOUReportID = ReportActionsUtils.getIOUReportIDFromReportActionPreview(action);

Furthermore, if we don’t want to collect any errors related to deleted reportActions, we can also filter reportActions directly in getAllReportErrors. Or since getAllReportErrors is a common function, if we don’t want to affect other callers, we can pass already filtered reportActions when LHN calls getAllReportErrors. :)

🎀 👀 🎀 C+ reviewed

melvin-bot · 2024-10-07T18:52:26Z

This issue has not been updated in over 15 days. @garrettmknight, @ntdiary, @neil-marcellini, @SIMalik eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

ntdiary · 2024-10-08T07:48:09Z

Not overdue, PR is still under testing. :)

neil-marcellini · 2024-10-09T17:35:46Z

How's this going? When you do you think the PR will be ready?

ntdiary · 2024-10-10T15:53:31Z

How's this going? When you do you think the PR will be ready?

@neil-marcellini, @SIMalik is trying to setup the iOS native app, they have already completed the Android-mWeb & MacOS-Chrome screenshots, four other platforms is still missing. Optimistically, the testing could be completed by next week.

Or perhaps we could approve and merge the PR this week, as I've already tested it on all platforms. As for the other errors @SIMalik is encountering in their environment setup, I can help him work through them gradually so that they will feel more confident handling other issues in the future. 😄

melvin-bot · 2024-10-22T04:38:22Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-10-22T04:38:27Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

@ntdiary requires payment through NewDot Manual Requests
@SIMalik requires payment (Needs manual offer from BZ)

melvin-bot · 2024-10-22T04:38:28Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
[@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ntdiary] Determine if we should create a regression test for this bug.
[@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

SIMalik · 2024-10-26T05:06:09Z

Hi @neil-marcellini, @ntdiary

I hope this message finds you well. Please see the following details regarding the job offer on Upwork, which I have yet to receive. Could you kindly assist with any necessary actions to help move this forward?

#47874 (comment) melvin-bot:

Unable to store contributor details.

#47874 (comment) melvin-bot:

The BZ member will need to manually hire SIMalik for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

#47874 (comment)
SIMalik commented on Sep 11

Contributor details
Expensify account email: f18ba010@ibitpu.edu.pk
Upwork Profile Link: https://www.upwork.com/freelancers/~01511dd712b8a399be?viewMode=1

Thank you for your time and support in helping facilitate this process. Please let me know if you need further information from my end.

Best regards,
SIMalik

SIMalik · 2024-10-28T13:35:07Z

#47874 (comment) melvin-bot:

@SIMalik requires payment (Needs manual offer from BZ)

ntdiary · 2024-10-28T15:03:05Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period
If no regressions arise, payment will be issued on 2024-10-29. 🎊

@SIMalik, don't worry, I will fill the BugZero Checklist tomorrow, and BZ member may send you the offer after the regression period. :)

ntdiary · 2024-10-29T15:26:41Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@ntdiary] The PR that introduced the bug has been identified. Link to the PR: N/A

[@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A

[@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need

[@ntdiary] Determine if we should create a regression test for this bug. No need

[@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need

[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

This issue should be an edge case that was overlooked during the original feature development. After excluding the deleted messages, this issue should no longer recur, so I don't have strong feelings on regression test. If you have different thoughts, please feel free to let me know. :)

melvin-bot · 2024-10-29T18:06:20Z

Payment Summary

Upwork Job

Reviewer: @ntdiary owed $250 via NewDot
ROLE: @SIMalik paid $250 via Upwork (LINK)

BugZero Checklist (@garrettmknight)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1828511929613408564/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

garrettmknight · 2024-10-29T18:25:26Z

@SIMalik offer out to you in Upwork https://www.upwork.com/nx/wm/offer/104649625

garrettmknight · 2024-10-29T18:26:04Z

@ntdiary request when you're ready.

JmillsExpensify · 2024-10-30T16:29:54Z

$250 approved for @ntdiary

IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 22, 2024

melvin-bot bot assigned garrettmknight Aug 22, 2024

melvin-bot bot added the Overdue label Aug 26, 2024

garrettmknight added the External Added to denote the issue can be worked on by a contributor label Aug 27, 2024

melvin-bot bot changed the title ~~LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace~~ [$250] LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace Aug 27, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 27, 2024

melvin-bot bot assigned ntdiary Aug 27, 2024

melvin-bot bot removed the Overdue label Aug 27, 2024

garrettmknight added this to [#whatsnext] #wave-collect Aug 27, 2024

garrettmknight moved this to Polish in [#whatsnext] #wave-collect Aug 27, 2024

melvin-bot bot added the Overdue label Sep 2, 2024

melvin-bot bot removed the Overdue label Sep 4, 2024

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 14, 2024

melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Oct 7, 2024

neil-marcellini added Weekly KSv2 and removed Monthly KSv2 labels Oct 9, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 22, 2024

melvin-bot bot changed the title ~~[$250] LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace~~ [HOLD for payment 2024-10-29] [$250] LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace Oct 22, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Oct 22, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 28, 2024

garrettmknight closed this as completed Oct 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-10-29] [$250] LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #47874

[HOLD for payment 2024-10-29] [$250] LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #47874

IuliiaHerets commented Aug 22, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Aug 22, 2024

IuliiaHerets commented Aug 22, 2024

IuliiaHerets commented Aug 22, 2024

melvin-bot bot commented Aug 27, 2024

melvin-bot bot commented Aug 27, 2024

garrettmknight commented Aug 27, 2024 •

edited

Loading

melvin-bot bot commented Aug 27, 2024

melvin-bot bot commented Sep 2, 2024

SIMalik commented Sep 3, 2024

melvin-bot bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

melvin-bot bot commented Sep 3, 2024

ntdiary commented Sep 4, 2024 •

edited

Loading

ntdiary commented Sep 5, 2024

melvin-bot bot commented Sep 5, 2024

SIMalik commented Sep 5, 2024

ntdiary commented Sep 9, 2024

melvin-bot bot commented Oct 7, 2024

ntdiary commented Oct 8, 2024

neil-marcellini commented Oct 9, 2024

ntdiary commented Oct 10, 2024

melvin-bot bot commented Oct 22, 2024

melvin-bot bot commented Oct 22, 2024

melvin-bot bot commented Oct 22, 2024

SIMalik commented Oct 26, 2024

SIMalik commented Oct 28, 2024

ntdiary commented Oct 28, 2024

ntdiary commented Oct 29, 2024 •

edited by garrettmknight

Loading

melvin-bot bot commented Oct 29, 2024 •

edited by garrettmknight

Loading

garrettmknight commented Oct 29, 2024

garrettmknight commented Oct 29, 2024

JmillsExpensify commented Oct 30, 2024

[HOLD for payment 2024-10-29] [$250] LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #47874

[HOLD for payment 2024-10-29] [$250] LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #47874

Comments

IuliiaHerets commented Aug 22, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Aug 22, 2024

IuliiaHerets commented Aug 22, 2024

IuliiaHerets commented Aug 22, 2024

melvin-bot bot commented Aug 27, 2024

melvin-bot bot commented Aug 27, 2024

garrettmknight commented Aug 27, 2024 • edited Loading

melvin-bot bot commented Aug 27, 2024

melvin-bot bot commented Sep 2, 2024

SIMalik commented Sep 3, 2024

melvin-bot bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

melvin-bot bot commented Sep 3, 2024

ntdiary commented Sep 4, 2024 • edited Loading

ntdiary commented Sep 5, 2024

melvin-bot bot commented Sep 5, 2024

SIMalik commented Sep 5, 2024

ntdiary commented Sep 9, 2024

melvin-bot bot commented Oct 7, 2024

ntdiary commented Oct 8, 2024

neil-marcellini commented Oct 9, 2024

ntdiary commented Oct 10, 2024

melvin-bot bot commented Oct 22, 2024

melvin-bot bot commented Oct 22, 2024

melvin-bot bot commented Oct 22, 2024

SIMalik commented Oct 26, 2024

SIMalik commented Oct 28, 2024

ntdiary commented Oct 28, 2024

ntdiary commented Oct 29, 2024 • edited by garrettmknight Loading

melvin-bot bot commented Oct 29, 2024 • edited by garrettmknight Loading

Payment Summary

BugZero Checklist (@garrettmknight)

garrettmknight commented Oct 29, 2024

garrettmknight commented Oct 29, 2024

JmillsExpensify commented Oct 30, 2024

IuliiaHerets commented Aug 22, 2024 •

edited by melvin-bot bot

Loading

garrettmknight commented Aug 27, 2024 •

edited

Loading

ntdiary commented Sep 4, 2024 •

edited

Loading

ntdiary commented Oct 29, 2024 •

edited by garrettmknight

Loading

melvin-bot bot commented Oct 29, 2024 •

edited by garrettmknight

Loading