LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

SIMalik · 2024-09-14T09:30:33Z

Details

Fixed Issues

$ #47874
PROPOSAL: #47874 (comment)

Tests

Navigate to Old Dot and sign up with a new account
Go to settings > Account and validate the account
Navigate to staging.new.expensify.com and sign in with the same account signed in on Old Dot
Create a workspace and name it as "Workspace 1"
Go to workspace editor and enable workflows
Go to workflows and enable delayed submission and set it to manual and enable approvals also
Create another workspace and name it as "Workspace 2"
Navigate to Workspace 1 chat and create a manual expense
Click on submit but do not click on approve
Navigate to Old dot and refresh the page
Go to reports and click on the expense created on ND
Click on detail and change the workspace from workspace 1 to workspace 2
Go to New dot and wait for a few seconds for the change to take effect
After the changes took effect (Workspace 1 will not have GBR on the LHN and instead workspace 2 will have GBR and the expense will be moved to it)
Go to workspace chat 2 and create a scan expense with a normal picture so that it will throw error after it is done scanning
Observe the LHN of workspace chat 1 on the LHN
No RBR will be present on the workspace chat 1

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as Tests above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

47874-NoErrorShown-2.mp4

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…error occurring on another workspace Expensify#47874

melvin-bot · 2024-09-14T09:30:37Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-09-14T09:30:48Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

SIMalik · 2024-09-14T09:33:27Z

I have read the CLA Document and I hereby sign the CLA

SIMalik · 2024-09-14T09:33:50Z

recheck

ntdiary · 2024-09-17T15:08:04Z

@SIMalik, can you please upload the videos for all other platforms? We need to do this to ensure all platforms pass, and I will also upload my own tests for all platforms again when I fill the check list later. :)

SIMalik · 2024-09-17T15:27:06Z

Hi @ntdiary,

Thank you for reviewing my PR. I wanted to ask for some guidance on how to test the changes across all six platforms (Android Native, Android mWeb Chrome, iOS Native, iOS mWeb Safari, MacOS Chrome/Safari, and MacOS Desktop). Currently, I'm using Linux for development, and as this is my first PR, I'm not entirely sure how to test on all these platforms.

Could you please advise on the best approach for this? Any help or resources you can provide would be greatly appreciated.

Thank you!

ntdiary · 2024-09-18T14:13:49Z

https://github.com/Expensify/App/blob/main/contributingGuides/TESTING_MACOS_AND_IOS.md
Perhaps this document can help you. As for Android mWeb/native, you can use Android Studio and its emulator or your real device.
Additionally, we also have a guide to help set up the local environment https://github.com/Expensify/App?tab=readme-ov-file#local-development 😄

SIMalik · 2024-09-18T14:49:57Z

https://github.com/Expensify/App/blob/main/contributingGuides/TESTING_MACOS_AND_IOS.md Perhaps this document can help you. As for Android mWeb/native, you can use Android Studio and its emulator or your real device. Additionally, we also have a guide to help set up the local environment https://github.com/Expensify/App?tab=readme-ov-file#local-development 😄

@ntdiary Hi
Thank you for providing the resources. I’ve started working on setting up the environment and will let you know if I encounter any issues. Your assistance is much appreciated!

ntdiary · 2024-09-23T09:08:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

ntdiary · 2024-09-23T09:29:52Z

src/libs/OptionsListUtils.ts

@@ -471,7 +471,7 @@ function uniqFast(items: string[]): string[] {
 function getAllReportErrors(report: OnyxEntry<Report>, reportActions: OnyxEntry<ReportActions>): OnyxCommon.Errors {
    const reportErrors = report?.errors ?? {};
    const reportErrorFields = report?.errorFields ?? {};
-    const reportActionsArray = Object.values(reportActions ?? {});
+    const reportActionsArray = Object.values(reportActions ?? {}).filter(action => !ReportActionUtils.isDeletedAction(action));


Suggested change

const reportActionsArray = Object.values(reportActions ?? {}).filter(action => !ReportActionUtils.isDeletedAction(action));

const reportActionsArray = Object.values(reportActions ?? {}).filter((action) => !ReportActionUtils.isDeletedAction(action));

tiny lint issue. :)

@SIMalik, can you please fix this tiny issue? I will fill the check list soon. :)

ntdiary · 2024-09-23T15:28:50Z

Addtionally, @SIMalik, did you encounter any difficulties while setting up the environment? :)

Issue resolved: LHN - RBR appears on the wrong workspace chat for an …

061efbf

…error occurring on another workspace Expensify#47874

SIMalik requested a review from a team as a code owner September 14, 2024 09:30

melvin-bot bot requested a review from ntdiary September 14, 2024 09:30

melvin-bot bot removed the request for review from a team September 14, 2024 09:30

ntdiary suggested changes Sep 23, 2024

View reviewed changes

Tiny lint issue resolved

044f575

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

SIMalik commented Sep 14, 2024 •

edited

Loading

melvin-bot bot commented Sep 14, 2024

github-actions bot commented Sep 14, 2024 •

edited

Loading

SIMalik commented Sep 14, 2024

SIMalik commented Sep 14, 2024

ntdiary commented Sep 17, 2024

SIMalik commented Sep 17, 2024

ntdiary commented Sep 18, 2024

SIMalik commented Sep 18, 2024

ntdiary commented Sep 23, 2024 •

edited

Loading

ntdiary Sep 23, 2024

ntdiary Sep 23, 2024 •

edited

Loading

ntdiary commented Sep 23, 2024

	const reportActionsArray = Object.values(reportActions ?? {}).filter(action => !ReportActionUtils.isDeletedAction(action));
	const reportActionsArray = Object.values(reportActions ?? {}).filter((action) => !ReportActionUtils.isDeletedAction(action));

LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

Are you sure you want to change the base?

LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

Conversation

SIMalik commented Sep 14, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 14, 2024

github-actions bot commented Sep 14, 2024 • edited Loading

SIMalik commented Sep 14, 2024

SIMalik commented Sep 14, 2024

ntdiary commented Sep 17, 2024

SIMalik commented Sep 17, 2024

ntdiary commented Sep 18, 2024

SIMalik commented Sep 18, 2024

ntdiary commented Sep 23, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ntdiary Sep 23, 2024

Choose a reason for hiding this comment

ntdiary Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

ntdiary commented Sep 23, 2024

SIMalik commented Sep 14, 2024 •

edited

Loading

github-actions bot commented Sep 14, 2024 •

edited

Loading

ntdiary commented Sep 23, 2024 •

edited

Loading

ntdiary Sep 23, 2024 •

edited

Loading