LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

SIMalik · 2024-09-14T09:30:33Z

Details

Fixed Issues

$ #47874
PROPOSAL: #47874 (comment)

Tests

Navigate to Old Dot and sign up with a new account
Go to settings > Account and validate the account
Navigate to staging.new.expensify.com and sign in with the same account signed in on Old Dot
Create a workspace and name it as "Workspace 1"
Go to workspace editor and enable workflows
Go to workflows and enable delayed submission and set it to manual and enable approvals also
Create another workspace and name it as "Workspace 2"
Navigate to Workspace 1 chat and create a manual expense
Click on submit but do not click on approve
Navigate to Old dot and refresh the page
Go to reports and click on the expense created on ND
Click on detail and change the workspace from workspace 1 to workspace 2
Go to New dot and wait for a few seconds for the change to take effect
After the changes took effect (Workspace 1 will not have GBR on the LHN and instead workspace 2 will have GBR and the expense will be moved to it)
Go to workspace chat 2 and create a scan expense with a normal picture so that it will throw error after it is done scanning
Observe the LHN of workspace chat 1 on the LHN
No RBR will be present on the workspace chat 1

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as Tests above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

47874-NoErrorShown-2.mp4

Android: Native

Android: mWeb Chrome

Video

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…error occurring on another workspace Expensify#47874

melvin-bot · 2024-09-14T09:30:37Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-09-14T09:30:48Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

SIMalik · 2024-09-14T09:33:27Z

I have read the CLA Document and I hereby sign the CLA

SIMalik · 2024-09-14T09:33:50Z

recheck

ntdiary · 2024-09-17T15:08:04Z

@SIMalik, can you please upload the videos for all other platforms? We need to do this to ensure all platforms pass, and I will also upload my own tests for all platforms again when I fill the check list later. :)

SIMalik · 2024-09-17T15:27:06Z

Hi @ntdiary,

Thank you for reviewing my PR. I wanted to ask for some guidance on how to test the changes across all six platforms (Android Native, Android mWeb Chrome, iOS Native, iOS mWeb Safari, MacOS Chrome/Safari, and MacOS Desktop). Currently, I'm using Linux for development, and as this is my first PR, I'm not entirely sure how to test on all these platforms.

Could you please advise on the best approach for this? Any help or resources you can provide would be greatly appreciated.

Thank you!

ntdiary · 2024-09-18T14:13:49Z

https://github.com/Expensify/App/blob/main/contributingGuides/TESTING_MACOS_AND_IOS.md
Perhaps this document can help you. As for Android mWeb/native, you can use Android Studio and its emulator or your real device.
Additionally, we also have a guide to help set up the local environment https://github.com/Expensify/App?tab=readme-ov-file#local-development 😄

SIMalik · 2024-09-18T14:49:57Z

https://github.com/Expensify/App/blob/main/contributingGuides/TESTING_MACOS_AND_IOS.md Perhaps this document can help you. As for Android mWeb/native, you can use Android Studio and its emulator or your real device. Additionally, we also have a guide to help set up the local environment https://github.com/Expensify/App?tab=readme-ov-file#local-development 😄

@ntdiary Hi
Thank you for providing the resources. I’ve started working on setting up the environment and will let you know if I encounter any issues. Your assistance is much appreciated!

ntdiary · 2024-09-23T09:08:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

ntdiary · 2024-09-23T09:29:52Z

src/libs/OptionsListUtils.ts

@@ -471,7 +471,7 @@ function uniqFast(items: string[]): string[] {
 function getAllReportErrors(report: OnyxEntry<Report>, reportActions: OnyxEntry<ReportActions>): OnyxCommon.Errors {
    const reportErrors = report?.errors ?? {};
    const reportErrorFields = report?.errorFields ?? {};
-    const reportActionsArray = Object.values(reportActions ?? {});
+    const reportActionsArray = Object.values(reportActions ?? {}).filter(action => !ReportActionUtils.isDeletedAction(action));


Suggested change

const reportActionsArray = Object.values(reportActions ?? {}).filter(action => !ReportActionUtils.isDeletedAction(action));

const reportActionsArray = Object.values(reportActions ?? {}).filter((action) => !ReportActionUtils.isDeletedAction(action));

tiny lint issue. :)

@SIMalik, can you please fix this tiny issue? I will fill the check list soon. :)

ntdiary · 2024-09-23T15:28:50Z

Addtionally, @SIMalik, did you encounter any difficulties while setting up the environment? :)

SIMalik · 2024-09-23T17:36:33Z

@ntdiary
Working well on the web.
The Android build in Android Studio completes successfully, but after the "Build Successful" message, the app doesn't fully launch on the emulator and stops at that point. It appears to be an issue with loading Scripts.

ntdiary · 2024-09-24T13:51:50Z

@SIMalik, Have you run npx react-native start and adb reverse tcp:8081 tcp:8081?

SIMalik · 2024-09-25T14:41:12Z

@ntdiary
Yes, I have executed both npx react-native start and adb reverse tcp:8081 tcp:8081, but the issue persists. Additionally, the web is running correctly on localhost:9000, while attempting to use 8081 or 8082 results in a security error.

ntdiary · 2024-09-25T15:15:09Z

@SIMalik, can you please provide a clearer screenshot of the emulator error? I couldn't make out the error message on it. 😂 Also, if you can test the Android mWeb using localhost:9000 correctly, that would be fine. 8081 is generally used for native testing.

As for security error, it’s usually due to not having the correct local HTTPS setup.
https://github.com/Expensify/App?tab=readme-ov-file#testing-on-browsers-in-simulators-and-emulators

BTW, we have a time zone difference, so my responses may not be timely. :)

SIMalik · 2024-09-25T19:20:44Z

@ntdiary
The application is now running successfully on https://10.0.2.2:8082 within the Android emulator. I've also attached a video in the "Android: mWeb Chrome" section for your reference.

Could you please confirm if this meets the requirements?
video

ntdiary · 2024-09-26T07:02:49Z

@SIMalik, LGTM! And if the video is too large, you can also upload screenshots like I did. 😄

SIMalik · 2024-09-26T07:42:33Z

@SIMalik, LGTM! And if the video is too large, you can also upload screenshots like I did. 😄

@ntdiary Thanks.

ntdiary · 2024-09-27T09:56:01Z

@SIMalik, any updates for the other platforms? :)

SIMalik · 2024-09-27T12:49:28Z

@ntdiary
Yes, I am currently in the process of setting up macOS from scratch.

ntdiary · 2024-10-02T15:01:00Z

@ntdiary Yes, I am currently in the process of setting up macOS from scratch.

Hi, @SIMalik, have you encountered any new difficulties? :)

SIMalik · 2024-10-02T17:35:39Z

Hi @ntdiary,

I initially installed macOS 10.15 Catalina, but I encountered several unsupported command issues, which affected its performance. Realizing it was an outdated version, I decided to remove it.

Currently, I am in the process of installing macOS 15 Sequoia. Since this is my first time installing macOS, it’s taking some time, but I'm making progress and am not stuck.

Thank you for your understanding!

SIMalik · 2024-10-07T14:22:58Z

Hi @ntdiary

MacOS: Chrome / Safari

After Code change:

Before code change:

Working on other platforms.

neil-marcellini

Requesting changes to fix the failing tests

SIMalik · 2024-10-11T04:49:51Z

@neil-marcellini

You're absolutely right; I’m currently working on addressing the failing tests and will make the necessary adjustments.

ntdiary · 2024-10-11T14:15:34Z

App/tests/unit/DebugUtilsTest.ts

Lines 1310 to 1317 in abdfb72

    
           it('returns report action that contains errors', () => { 
        
               const MOCK_REPORT_ACTIONS: ReportActions = { 
        
                   // eslint-disable-next-line @typescript-eslint/naming-convention 
        
                   '0': { 
        
                       reportActionID: '0', 
        
                       actionName: CONST.REPORT.ACTIONS.TYPE.CREATED, 
        
                       created: '2024-08-08 18:40:44.171', 
        
                   },

The mock reportAction is missing the message field, and without it, we determine that this reportAction has been deleted and should be filtered out, which is exactly what's causing the unit test to fail. 😂

So we need to add the message field like this:

message: [{html: 'text', text: 'text', type: 'COMMENT'}]

As for the ESLint and performance errors, based on the logs, they don't seem related to this PR. Perhaps we can try running the tests again after merging the latest main code.

SIMalik · 2024-10-13T09:07:16Z

@ntdiary, @neil-marcellini

getRBRReportAction
  ✓ returns report action that contains errors (297 ms)
  ○ skipped returns undefined when report has no RBR
  ○ skipped returns parentReportAction if it is a transaction thread, the transaction is missing smart scan fields and the report is not settled
  Report has missing fields, isn't settled and it's owner is the current user
    Report is IOU
      ○ skipped returns correct report action which has missing fields
    Report is expense
      ○ skipped returns correct report action which has missing fields
  There is a report action with smart scan errors
    ○ skipped returns correct report action which is a report preview and has an error
    ○ skipped returns correct report action which is a split bill and has an error
    ○ skipped returns undefined if there's no report action is a report preview or a split bill

Test Suites: 1 passed, 1 total
Tests: 174 skipped, 1 passed, 175 total
Snapshots: 0 total
Time: 8.196 s
Ran all test suites matching /tests/unit/DebugUtilsTest.ts/i with tests matching "returns report action that contains errors".

ntdiary · 2024-10-15T14:40:32Z

Hi, @neil-marcellini, can you please rerun the tests? :)

neil-marcellini

Looks good thanks. The performance check is failing due to some weird merge conflict issue. I'm re-running it, but if it fails again we'll need to investigate more deeply.

neil-marcellini · 2024-10-15T19:06:03Z

@SIMalik I would try merging main into this PR. This merge is failing.

HEAD is now at a26cfb45889 Merge 38c543159587474035ee77f06f8b7b34f1202d6e into e4969b22e7dbb1f6a200cc587ced4ab665415c0e

SIMalik · 2024-10-15T20:18:18Z

@SIMalik I would try merging main into this PR. This merge is failing.
HEAD is now at a26cfb45889 Merge 38c543159587474035ee77f06f8b7b34f1202d6e into e4969b22e7dbb1f6a200cc587ced4ab665415c0e

Hi @neil-marcellini

I went ahead and merged the main branch into the feature branch (issue-47874). The merge completed successfully with no conflicts. I have also pushed the updated branch. The latest commit hash is 30f43f2, and the branch is now fully up to date with main.

Please let me know if there’s anything else I should address or if any further steps are needed on this.

Thanks,

neil-marcellini · 2024-10-16T16:56:14Z

@SIMalik looks like there are conflicts again

SIMalik · 2024-10-16T18:30:51Z

@neil-marcellini @ntdiary

Conflicts removed.

After code change:

Before code change:

SIMalik · 2024-10-17T13:24:33Z

@SIMalik, this message?
Don't worry, just click "OK" to ignore it. I see it every time I open the project in Xcode. :) Have there been any other fatal errors during compilation?

@ntdiary
macOS: 13.7
Xcode: 14.3.1
Swift: 5
I have facing following errors during build.

ntdiary · 2024-10-17T15:01:01Z

@SIMalik, It looks like a swiftUI compatibility prolem, would it be possible for you to upgrade to the new version?
I'm using macOS 14.3.1 / Xcode 15.3. Perhaps you can try upgrading Xcode to version 15.x and attempt to compile on the newer iOS 17.x.
BTW, you might also send me any questions about the build directly via the Expensify app (new.expensify.com) or the Slack, which would help keep this PR comments cleaner, my email is 2471314@gmail.com. :)

Here are the version compatibility requirements:
https://developer.apple.com/support/xcode/

Addtionally, @neil-marcellini, can you please run tests again when you have time? :)

neil-marcellini

Ok good to go!

neil-marcellini · 2024-10-17T16:50:25Z

The changed files check is failing but none of those files were changed in this PR, so they should be handled elsewhere.

melvin-bot · 2024-10-17T16:50:40Z

@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-10-17T17:00:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-18T19:04:18Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.51-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

SIMalik · 2024-10-19T02:52:35Z

@neil-marcellini @ntdiary

After deployment on staging

github-actions · 2024-10-22T04:37:34Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

github-actions · 2024-10-22T17:19:58Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Issue resolved: LHN - RBR appears on the wrong workspace chat for an …

061efbf

…error occurring on another workspace Expensify#47874

SIMalik requested a review from a team as a code owner September 14, 2024 09:30

melvin-bot bot requested a review from ntdiary September 14, 2024 09:30

melvin-bot bot removed the request for review from a team September 14, 2024 09:30

ntdiary suggested changes Sep 23, 2024

View reviewed changes

Tiny lint issue resolved

044f575

SIMalik closed this Sep 24, 2024

SIMalik reopened this Sep 25, 2024

neil-marcellini requested changes Oct 10, 2024

View reviewed changes

Fix test - returns report action that contains errors

38c5431

neil-marcellini previously approved these changes Oct 15, 2024

View reviewed changes

Merge branch 'main' into issue-47874

30f43f2

Fix: Resolved merge conflict caused by function move to a different file

fbfd29e

SIMalik dismissed neil-marcellini’s stale review via fbfd29e October 16, 2024 16:57

Typo

5d001f6

neil-marcellini approved these changes Oct 17, 2024

View reviewed changes

neil-marcellini merged commit 50482b1 into Expensify:main Oct 17, 2024
15 of 16 checks passed

melvin-bot bot added the Emergency label Oct 17, 2024

neil-marcellini removed the Emergency label Oct 17, 2024

github-actions bot mentioned this pull request Oct 18, 2024

Deploy Checklist: New Expensify 2024-10-18 #51106

Closed

59 tasks

melvin-bot bot mentioned this pull request Oct 22, 2024

[HOLD for payment 2024-10-29] [$250] LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #47874

Closed

6 tasks

	const reportActionsArray = Object.values(reportActions ?? {}).filter(action => !ReportActionUtils.isDeletedAction(action));
	const reportActionsArray = Object.values(reportActions ?? {}).filter((action) => !ReportActionUtils.isDeletedAction(action));

LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

Conversation

SIMalik commented Sep 14, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 14, 2024

github-actions bot commented Sep 14, 2024 • edited Loading

SIMalik commented Sep 14, 2024

SIMalik commented Sep 14, 2024

ntdiary commented Sep 17, 2024

SIMalik commented Sep 17, 2024

ntdiary commented Sep 18, 2024

SIMalik commented Sep 18, 2024

ntdiary commented Sep 23, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ntdiary Sep 23, 2024

Choose a reason for hiding this comment

ntdiary Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

ntdiary commented Sep 23, 2024

SIMalik commented Sep 23, 2024

ntdiary commented Sep 24, 2024

SIMalik commented Sep 25, 2024 • edited Loading

ntdiary commented Sep 25, 2024 • edited Loading

SIMalik commented Sep 25, 2024

ntdiary commented Sep 26, 2024

SIMalik commented Sep 26, 2024 • edited Loading

ntdiary commented Sep 27, 2024

SIMalik commented Sep 27, 2024

ntdiary commented Oct 2, 2024

SIMalik commented Oct 2, 2024

SIMalik commented Oct 7, 2024

neil-marcellini left a comment

Choose a reason for hiding this comment

SIMalik commented Oct 11, 2024

ntdiary commented Oct 11, 2024 • edited Loading

SIMalik commented Oct 13, 2024

ntdiary commented Oct 15, 2024

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini commented Oct 15, 2024

SIMalik commented Oct 15, 2024

neil-marcellini commented Oct 16, 2024

SIMalik commented Oct 16, 2024

SIMalik commented Oct 17, 2024

ntdiary commented Oct 17, 2024 • edited Loading

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini commented Oct 17, 2024

melvin-bot bot commented Oct 17, 2024

OSBotify commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

SIMalik commented Oct 19, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

SIMalik commented Sep 14, 2024 •

edited

Loading

github-actions bot commented Sep 14, 2024 •

edited

Loading

ntdiary commented Sep 23, 2024 •

edited

Loading

ntdiary Sep 23, 2024 •

edited

Loading

SIMalik commented Sep 25, 2024 •

edited

Loading

ntdiary commented Sep 25, 2024 •

edited

Loading

SIMalik commented Sep 26, 2024 •

edited

Loading

ntdiary commented Oct 11, 2024 •

edited

Loading

ntdiary commented Oct 17, 2024 •

edited

Loading