Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

Merged
merged 7 commits into from
Oct 17, 2024
Merged

LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
061efbf
Issue resolved: LHN - RBR appears on the wrong workspace chat for an …
SIMalik Sep 14, 2024
044f575
Tiny lint issue resolved
SIMalik Sep 23, 2024
fc04b59
Resolved merge conflicts
SIMalik Oct 8, 2024
38c5431
Fix test - returns report action that contains errors
SIMalik Oct 13, 2024
30f43f2
Merge branch 'main' into issue-47874
SIMalik Oct 15, 2024
fbfd29e
Fix: Resolved merge conflict caused by function move to a different file
SIMalik Oct 16, 2024
5d001f6
Typo
SIMalik Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6284,7 +6284,7 @@ type ReportErrorsAndReportActionThatRequiresAttention = {
};

function getAllReportActionsErrorsAndReportActionThatRequiresAttention(report: OnyxEntry<Report>, reportActions: OnyxEntry<ReportActions>): ReportErrorsAndReportActionThatRequiresAttention {
const reportActionsArray = Object.values(reportActions ?? {});
const reportActionsArray = Object.values(reportActions ?? {}).filter((action) => !ReportActionsUtils.isDeletedAction(action));
const reportActionErrors: ErrorFields = {};
let reportAction: OnyxEntry<ReportAction>;

Expand Down
1 change: 1 addition & 0 deletions tests/unit/DebugUtilsTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,6 +1450,7 @@ describe('DebugUtils', () => {
errors: {
randomError: 'Random error',
},
message: [{html: 'text', text: 'text', type: 'COMMENT'}],
},
// eslint-disable-next-line @typescript-eslint/naming-convention
'2': {
Expand Down
Loading