[Hold for payment 2024-10-07][$250] Workspace – Workspace name/avatar not updated on another device if workspace chat is open

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.30-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4936874
Email or phone of affected tester (no customers): ponikarchuks+3@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Go to Account settings > Workspaces
4. Create a new Workspace
5. Log in as the same user on another device
6. On another device open Workspace chat created on step 4
7. On main device change Workspace avatar and name
8. Observe the Workspace chat header on another device

Expected Result:

Workspace name/avatar updated on another device workspace chat header

Actual Result:

Workspace name/avatar not updated on another device workspace chat header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6595144_1725613214496.WS_Avatar_name.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833620003356682080
• Upwork Job ID: 1833620003356682080
• Last Price Increase: 2024-09-17
• Automatic offers:
• rojiphil | Reviewer | 104007817

Issue Owner

Current Issue Owner: @neil-marcellini

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS name & avatar isn't updated dynamically.

What is the root cause of that problem?

The name of the workspace comes from the policy object, but we pass undefined to the policy param of getReportName.

App/src/pages/home/HeaderView.tsx

Line 81 in 7ebfaa0

const title = ReportUtils.getReportName(reportHeaderData, undefined, parentReportAction, personalDetails, invoiceReceiverPolicy);

react-complier automatically memoized the result, so it won't be re-calculated when the policy data is changed.

For the workspace avatar, we get the avatar from the report policyAvatar and fallback to the policy avatarURL.

App/src/libs/ReportUtils.ts

Line 1952 in 7ebfaa0

const policyAvatarURL = report?.policyAvatar || allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.avatarURL;

However, the Pusher only updates the policy.avatarURL, but doesn't send the updated policyAvatar. But if we look at the LHN, the avatar is updated, that's because we use caching for the avatar. The announce room of the workspace doesn't have policyAvatar, so it will use the updated policy.avatarURL and save it to the cache. When the LHN tries to get the avatar, the cache is available, so it shows the updated avatar.

But this doesn't happen with the header or the report welcome text avatar because the same reason as above, that is we don't pass the policy to the function.

App/src/pages/home/HeaderView.tsx

Line 128 in 7ebfaa0

const icons = ReportUtils.getIcons(reportHeaderData, personalDetails, null, '', -1, undefined, invoiceReceiverPolicy);

App/src/pages/home/report/ReportActionItemCreated.tsx

Line 50 in 7ebfaa0

let icons = ReportUtils.getIcons(report, personalDetails, null, '', -1, undefined, invoiceReceiverPolicy);

What changes do you think we should make in order to solve the problem?

We need to pass policy to both getIcons and getReportName.

App/src/pages/home/HeaderView.tsx

Line 81 in 7ebfaa0

const title = ReportUtils.getReportName(reportHeaderData, undefined, parentReportAction, personalDetails, invoiceReceiverPolicy);

App/src/pages/home/HeaderView.tsx

Line 128 in 7ebfaa0

const icons = ReportUtils.getIcons(reportHeaderData, personalDetails, null, '', -1, undefined, invoiceReceiverPolicy);

App/src/pages/home/report/ReportActionItemCreated.tsx

Line 50 in 7ebfaa0

let icons = ReportUtils.getIcons(report, personalDetails, null, '', -1, undefined, invoiceReceiverPolicy);

optionally, I think we should prioritize the policy avatarURL instead of the report.policyAvatar.

App/src/libs/ReportUtils.ts

Line 1952 in 7ebfaa0

const policyAvatarURL = report?.policyAvatar || allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.avatarURL;

[OfstadC]

Looking at this today

[OfstadC]

I'm not able to reproduce. Mine took a few seconds but updated on it's own - I tried it on both sides of the chat. Once updating the name and image. Once with just the image. Both updated.

[kavimuru]

Still reproducible by the tester.

bandicam.2024-09-10.20-34-51-842.2.mp4

[OfstadC]

Thanks @kavimuru !

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021833620003356682080

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[rojiphil]

@bernhardoj proposal LGTM as updation of workspace name and avatar requires policy in getIcons and getReportName. Regarding the optional suggestion, let us not change the existing order of report policyAvatar and policy avatarURL unless there is a concrete need to do this.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@rojiphil, @OfstadC, @neil-marcellini Eep! 4 days overdue now. Issues have feelings too...

[OfstadC]

Friendly bump @neil-marcellini 😃 . Thank you!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[neil-marcellini]

@bernhardoj proposal LGTM as updation of workspace name and avatar requires policy in getIcons and getReportName. Regarding the optional suggestion, let us not change the existing order of report policyAvatar and policy avatarURL unless there is a concrete need to do this. 🎀👀🎀 C+ reviewed

I agree, hiring 🚀

[melvin-bot]

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[OfstadC]

Any update here @bernhardoj @rojiphil? 😃

[bernhardoj]

PR is ready

cc: @rojiphil

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[OfstadC]

Deployed to production yesterday. Will issue payment on 2024-10-07.

@rojiphil can you propose regression testing if needed? Thank you!

[rojiphil]

• [@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
• [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
• [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist is good enough to capture such issues.
• [@rojiphil] Determine if we should create a regression test for this bug. : Yes. We can
• [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Steps:
Prerequisite: Login using the same account in two devices: Device 1 and Device 2. Also, ensure that Device 1 and Device 2 receives pusher updates so that the UI get’s updated automatically.

1. Device 1: Navigate to a Workspace Chat
2. Device 2 : Navigate to Account Settings -> Workspace -> Profile
3. Device 2 : Change the workspace avatar and name.
4. Device 1: Verify that the Workspace Chat header and Item Created action reflects the updated workspace avatar. Also verify that the updated workspace name is reflected in header.

[rojiphil]

can you propose regression testing if needed? Thank you!

@OfstadC I have completed the BZ checklist which includes the regression test. Thanks.

[OfstadC]

Just a note for myself for Monday's payment - @bernhardoj is paid via New Expensify & @rojiphil is issued payment in Upwork

[OfstadC]

@rojiphil It looks like you haven't accepted the offer yet. Could you please accept this offer so I can issue payment in Upwork? 😃

[OfstadC]

Payment Summary

• @rojiphil Paid $250 via Upwork
• @bernhardoj due $250 via manual New Expensify request

[rojiphil]

It looks like you haven't accepted the offer yet. Could you please accept this offer so I can issue payment in Upwork? 😃

@OfstadC Accepted Offer. Thanks.

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj