Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paid meow] Workspace - Duplicate expense preview avatar after workspace is deleted #49927

Closed
6 tasks done
lanitochka17 opened this issue Sep 30, 2024 · 19 comments
Closed
6 tasks done
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace
  3. Submit an expense
  4. Delete the workspace
  5. Go to the workspace chat (now archived)

Expected Result:

The expense preview avatar will remain the same after the workspace is deleted

Actual Result:

The expense preview avatar changes after the workspace is deleted
It changes to stacked avatars with both avatars from the workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6619463_1727626718511.bandicam_2024-09-30_00-15-25-899.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @OfstadC
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Sep 30, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mjasikowski mjasikowski added Weekly KSv2 Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 Weekly KSv2 labels Sep 30, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

Current assignee @mjasikowski is eligible for the DeployBlockerCash assigner, not assigning anyone new.

@github-actions github-actions bot removed the Weekly KSv2 label Sep 30, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mjasikowski
Copy link
Contributor

Possibly related: #49403

@mjasikowski
Copy link
Contributor

Reverting #49403 did not fix the issue, looking further

@mjasikowski
Copy link
Contributor

Pinpointed the offending PR using git bisect: #49172

@mjasikowski
Copy link
Contributor

@grgia would you be able to take a look at this and see if this can be easily fixed or reverted?

@mjasikowski mjasikowski assigned grgia and unassigned mjasikowski Sep 30, 2024
@grgia
Copy link
Contributor

grgia commented Sep 30, 2024

It's late for me let's revert #49172 for now

@jasperhuangg
Copy link
Contributor

We reverted the problematic PR #49945. Gonna remove the label but keep this open so @grgia can fix this in a followup.

Copy link

melvin-bot bot commented Sep 30, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 30, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@mjasikowski mjasikowski self-assigned this Oct 1, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 7, 2024
@parasharrajat
Copy link
Member

This was solved long back. I was C+ on the revert PR. Can we please assign someone from BZ to make the payment?

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

This issue has not been updated in over 15 days. @mjasikowski, @grgia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mjasikowski
Copy link
Contributor

This was solved long back. I was C+ on the revert PR. Can we please assign someone from BZ to make the payment?

@Expensify/bug-zero pinging you here

@twisterdotcom twisterdotcom added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 4, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Nov 4, 2024
@mallenexpensify mallenexpensify added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Nov 5, 2024
@mallenexpensify mallenexpensify changed the title Workspace - Duplicate expense preview avatar after workspace is deleted [Pay meow] Workspace - Duplicate expense preview avatar after workspace is deleted Nov 5, 2024
@parasharrajat
Copy link
Member

[Pay meow]

😹

@OfstadC
Copy link
Contributor

OfstadC commented Nov 5, 2024

Sorry friends! Looking now

@OfstadC
Copy link
Contributor

OfstadC commented Nov 5, 2024

Payment Summary

If i'm missing anyone, please let me know!

@OfstadC OfstadC changed the title [Pay meow] Workspace - Duplicate expense preview avatar after workspace is deleted [Paid meow] Workspace - Duplicate expense preview avatar after workspace is deleted Nov 5, 2024
@OfstadC OfstadC closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants