[HOLD for payment 2024-11-13] [HOLD for payment 2024-10-30] A newly added card under the Members section does not appear in the Assigned Cards section.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.46-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1728308001803959

Action Performed:

1. Navigate to Settings > Workspaces > Select any workspace that has Expensify Cards enabled and where you have permissions to add a card.
2. Go to Members > Select any member > New Card.
3. Fill in the card details and complete the issue card flow.
4. Check the Assigned Cards section under the member's details.

Expected Result:

The card should be added to the Assigned Cards section immediately.

Actual Result:

The card does not appear until you navigate away to Workspaces and then return to the Member details page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

BUG-card-does-not-update-on-member.mov

Recording.637.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

@koko57 We need to add the card optimistically to the cards_ collection to show there, I believe you already working on that elsewhere, if so, can you comment so I can assign you? thanks!

[koko57]

yes, I can work on that with #50248 and #50467 - they are related so I will fix them all in one PR

[stephanieelliott]

@koko57 can you link the PR when you have it?

[koko57]

@stephanieelliott yes! I'm still working on it. Sorry for not posting updates here, I left some in these two other issues I mentioned. We also had a discussion yesterday on how to solve this problem on Slack

[koko57]

it looks like it's rather the same root cause as #50467, here we don't have the info for which type of card it happened. If for both it could be due to some error - the error handling is applied here: #50644

cc @mountiny

[koko57]

I'll be ooo Monday - Tuesday (14-15 Oct) if there will be some changes required to my PR and you'd like to merge it asap - please ping Callstack team, someone might be able to take it over. Thanks!

[mountiny]

Thanks, yeah I think we are nicely streamlining the process now

[stephanieelliott]

Hey @koko57 any update on this one?

[DylanDylann]

the PR is merged and deployed to staging

[koko57]

yes, it's merged and can be retested. Sorry for no update!

[mountiny]

Asked for a retest here

[m-natarajan]

Still able to reproduce, card not appears even after refresh

bandicam.2024-10-23.16-22-08-725.mp4

[koko57]

this one is definitely strange, maybe some other changes broke it in the meantime, I will look at this tomorrow

[koko57]

When I was issuing a card for myself I could not reproduce. The cards were added properly. But when I invited a new member any card that I've added haven't appeared in the list.

It's because we're using a wrong(?) Onyx key for querying cards

and that's why we don't get the newly created card - observe that for the cards_ collection we have a new card.

I need to look at why we use this key, why it only stores the current user's (not an invitee's) card and if the key is used for company cards.

[koko57]

@mountiny - this was an intentional change, Vicky left a comment why it was necessary. Now I need to figure out a solution, maybe query for both cards_ and cardList? And then filter out the ones already in the cards_ object?

[VickyStash]

I've answered about the reason of cards_ -> cardList_ update here: #49928 (comment)

But does the cardList_ key store only current user cards?
If so, to show all user related cards from different feeds we need to:

1. Do multiple calls to get cards for every feed
2. Have an API call to get all of the cards for all of the feeds

[koko57]

But can't we query cards_ for expensify cards and feeds separately? If I understand it correctly cardList contains Expensify Cards and Feeds?

[koko57]

And the question is why the cards for another member doesn't appear in the cardList? Is it because for the current user (admin) only there is an additional logic on the backend that adds any card (Expensify or 3rd party) to the cardList object?

[VickyStash]

But can't we query cards_ for expensify cards and feeds separately? If I understand it correctly cardList contains Expensify Cards and Feeds?

The thing is that cardList_ key populated by OpenApp command. So it has the data right away.
To populate cards_ key we need to do API calls to get the data.
It can be 6+ calls, for example, if we need to get Expensify cards + 5 feeds cards.

[koko57]

I see that when I'm issuing a card for myself I get the cardList object in OnyxData - which I don't get when creating a card for another member

[mountiny]

Ok yeah i was wondering if thsi is the issue. The two onyx keys hold different values

cardList is all your cards those that you as the currently assigned user own

cards_ collection is only for the domain admins where you can see all the cards on particular feed.

So i think what we need to do is update the member details page to look at cardList if its your own page (the signed in user) and the cards_ if not.

[koko57]

PR opened for review #50441

[DylanDylann]

Asking for the next step

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @koko57 is from an agency-contributor and not due payment
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: N/A (agency)
• Contributor+: @DylanDylann $250 via Upwork - PAID

Upwork job is here: https://www.upwork.com/jobs/~021851906318833506897

[DylanDylann]

@stephanieelliott Done

[stephanieelliott]

All paid!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: show the cards assigned to members #51467

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)
• @jayeshmangwani requires payment through NewDot Manual Requests

[melvin-bot]

@DylanDylann @stephanieelliott The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]