fix: show the cards assigned to members #51467

koko57 · 2024-10-25T13:08:11Z

Details

Fixed Issues

$ #50441
PROPOSAL: -

Tests

PREREQUISITES: a workspace with Expensify Card enabled

Got to Workspace -> Members page
Open your details
Issue a card from Members page
Observe that after issuing a card it appears in the Cards section
Do the same (steps 2-4) for a different member
Verify that cards are showing on the members page in the Cards section

Verify that no errors appear in the JS console

Offline tests

QA Steps

PREREQUISITES: a workspace with Expensify Card enabled

Got to Workspace -> Members page
Open your details
Issue a card from Members page
Observe that after issuing a card it appears in the Cards section
Do the same (steps 2-4) for a different member
Verify that cards are showing on the members page in the Cards section

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-25T13:55:14Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-10-28T07:04:04Z

@koko57 Failed test

koko57 · 2024-10-28T07:07:47Z

@DylanDylann perf test for ReportScreen 🤔 I will look into this, but my changes shouldn't cause this problem

DylanDylann · 2024-10-28T07:15:57Z

@koko57

but my changes shouldn't cause this problem

Please merge the latest main

koko57 · 2024-10-28T08:09:08Z

@DylanDylann done

koko57 · 2024-10-29T10:41:04Z

@DylanDylann friendly bump 🙏🏻

DylanDylann · 2024-10-29T10:42:00Z

I will try to complete my reviewing for these issues on Wed

DylanDylann · 2024-10-30T14:28:33Z

src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

+            return true;
+        });
+
+        return Object.values(uniqueObjects ?? {}).filter((card) => card.accountID === accountID && workspaceAccountID.toString() === card.fundID);


Card doesn't display on the member detail page, because fundID isn't exist on expensifyCards

Screen.Recording.2024-10-30.at.21.26.42.mov

@koko57 Do you know why we add workspaceAccountID.toString() === card.fundID condition before?

cc

not sure, I just left this condition as it was

ECards should have fundID too 🤔

ref: #49928 (comment)

DylanDylann · 2024-10-31T05:09:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-31.at.12.25.53.mov

Android: mWeb Chrome

Screen.Recording.2024-10-31.at.12.19.44.mov

iOS: Native

Screen.Recording.2024-10-31.at.12.25.09.mov

iOS: mWeb Safari

Screen.Recording.2024-10-31.at.12.19.16.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-31.at.12.09.30.mov

MacOS: Desktop

Screen.Recording.2024-10-31.at.12.21.02.mov

DylanDylann · 2024-10-31T05:27:36Z

Just a note

If you log out and log in again, we can't see cards on the member detail page immediately. We need to go to Expensify Card and click on detail card first, then we can see cards on the member detail page

Because cards_ only be loaded when we execute OpenCardDetailsPage API

Screen.Recording.2024-10-31.at.12.21.02.mov

mountiny

Thanks

OSBotify · 2024-10-31T13:43:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-04T14:38:43Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-06T00:02:16Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.57-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

koko57 added 2 commits October 25, 2024 20:02

fix: show the cards assigned to members

67afa3d

fix: make it work for any card feed

aa0fd79

koko57 marked this pull request as ready for review October 25, 2024 13:55

koko57 requested a review from a team as a code owner October 25, 2024 13:55

melvin-bot bot requested review from DylanDylann and removed request for a team October 25, 2024 13:55

fix: rename one variable and leave a descriptive comment on filtering

743ced2

Merge branch 'main' into fix/50441-cards-not-shown-for-member

e9c9535

Merge branch 'main' into fix/50441-cards-not-shown-for-member

6a010d2

DylanDylann reviewed Oct 30, 2024

View reviewed changes

DylanDylann mentioned this pull request Oct 30, 2024

[NoQA] [3rd Party Feeds] Workspace feeds clean up #49928

Merged

50 tasks

Merge branch 'main' into fix/50441-cards-not-shown-for-member

02da13c

mountiny assigned koko57 Oct 30, 2024

DylanDylann approved these changes Oct 31, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny October 31, 2024 05:27

mountiny approved these changes Oct 31, 2024

View reviewed changes

mountiny merged commit 9400244 into Expensify:main Oct 31, 2024
19 checks passed

github-actions bot mentioned this pull request Nov 4, 2024

Deploy Checklist: New Expensify 2024-11-04 #51953

Closed

63 tasks

melvin-bot bot mentioned this pull request Nov 6, 2024

[HOLD for payment 2024-11-13] [HOLD for payment 2024-10-30] A newly added card under the Members section does not appear in the Assigned Cards section. #50441

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: show the cards assigned to members #51467

fix: show the cards assigned to members #51467

koko57 commented Oct 25, 2024 •

edited

Loading

melvin-bot bot commented Oct 25, 2024

DylanDylann commented Oct 28, 2024

koko57 commented Oct 28, 2024

DylanDylann commented Oct 28, 2024

koko57 commented Oct 28, 2024

koko57 commented Oct 29, 2024

DylanDylann commented Oct 29, 2024

DylanDylann Oct 30, 2024

koko57 Oct 30, 2024

mountiny Oct 30, 2024

DylanDylann Oct 31, 2024

DylanDylann commented Oct 31, 2024 •

edited

Loading

DylanDylann commented Oct 31, 2024 •

edited

Loading

mountiny left a comment

OSBotify commented Oct 31, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 6, 2024

fix: show the cards assigned to members #51467

fix: show the cards assigned to members #51467

Conversation

koko57 commented Oct 25, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 25, 2024

DylanDylann commented Oct 28, 2024

koko57 commented Oct 28, 2024

DylanDylann commented Oct 28, 2024

koko57 commented Oct 28, 2024

koko57 commented Oct 29, 2024

DylanDylann commented Oct 29, 2024

DylanDylann Oct 30, 2024

Choose a reason for hiding this comment

koko57 Oct 30, 2024

Choose a reason for hiding this comment

mountiny Oct 30, 2024

Choose a reason for hiding this comment

DylanDylann Oct 31, 2024

Choose a reason for hiding this comment

DylanDylann commented Oct 31, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Oct 31, 2024 • edited Loading

Just a note

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 31, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 6, 2024

koko57 commented Oct 25, 2024 •

edited

Loading

DylanDylann commented Oct 31, 2024 •

edited

Loading

DylanDylann commented Oct 31, 2024 •

edited

Loading