Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [UX Reliability] Chat loading even if it was opened before #50484

Open
2 of 6 tasks
mountiny opened this issue Oct 8, 2024 · 27 comments
Open
2 of 6 tasks

[$250] [UX Reliability] Chat loading even if it was opened before #50484

mountiny opened this issue Oct 8, 2024 · 27 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@mountiny
Copy link
Contributor

mountiny commented Oct 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.46
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: Discussed in here https://expensify.slack.com/archives/C05LX9D6E07/p1728414645672739?thread_ts=1727304948.791309&cid=C05LX9D6E07

Action Performed:

Break down in numbered steps

On iOS app

  1. Open the app
  2. Open some chat report
  3. Verify the messages loaded correctly
  4. Force quit the app
  5. Open the App again
  6. Open the same chat

Expected Result:

Describe what you think should've happened

The report action should be cached locally in Onyx already so even if we are making another OpenReport call, we should not be showing a skeleton

Actual Result:

Describe what actually happened

A skeleton is shown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

screen-20241007-115935.mp4
Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021843774456282966290
  • Upwork Job ID: 1843774456282966290
  • Last Price Increase: 2024-10-08
  • Automatic offers:
    • rayane-djouah | Reviewer | 104337904
Issue OwnerCurrent Issue Owner: @rayane-djouah
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers External Added to denote the issue can be worked on by a contributor labels Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @puneetlath (AutoAssignerNewDotQuality)

Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Oct 8, 2024
@melvin-bot melvin-bot bot changed the title [UX Reliability] Chat loading even if it was opened before [$250] [UX Reliability] Chat loading even if it was opened before Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021843774456282966290

@melvin-bot melvin-bot bot added Help Wanted Apply this label when an issue is open to proposals by contributors and removed Weekly KSv2 labels Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

@mallenexpensify
Copy link
Contributor

@mountiny @puneetlath , should the External and Help Wanted labels be removed since Puneet's assigned? Based on this SO it sounds like it. Let me know if I can help, it takes ~30 seconds for the app to load on iOS for me

@mountiny
Copy link
Contributor Author

mountiny commented Oct 8, 2024

Give support to the agency engineer who is working on the #newdot-quality bug. Giving support looks like: explaining how the code should work, retrieving data only available on the back-end, helping them with testing, reviewing their changes and keeping the urgency up.

I think it can be external; it's never been a problem to get contributors to fix it. But for what it's worth, I have asked here for expert contributor volunteers, so that sounds like it's in line with what the SO says, too.

Let me know if I can help, it takes ~30 seconds for the app to load on iOS for me

I am not sure if this is exactly the same bug @mallenexpensify Lets talk in slack

@mallenexpensify
Copy link
Contributor

I am not sure if this is exactly the same bug

I agree, I think my bug is different (similar problems with slow load)

@kacper-mikolajczak
Copy link
Contributor

Hi @mountiny I would like to investigate the issue!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 9, 2024
Copy link

melvin-bot bot commented Oct 9, 2024

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@mallenexpensify
Copy link
Contributor

Posted Android logs here https://expensify.slack.com/archives/C05LX9D6E07/p1728677097096519?thread_ts=1728425143.883699&cid=C05LX9D6E07

@mountiny for the ~30 second load time on iOS, what do you think the next best step is there? I can post in #expensify-bugs or another room with deets and logs

@melvin-bot melvin-bot bot added the Overdue label Oct 11, 2024
@rayane-djouah
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Oct 12, 2024
@mountiny
Copy link
Contributor Author

@mallenexpensify In the long load case; I would maybe post in fast-API to see if there are some active efforts now that should speed up the OpenApp. I feel like it's quite slow for you, even compared with Jason and others, which I am not sure why is the case. Do you use the focus mode? Well I would bring the discussion there as it was 17s api time

@kacper-mikolajczak
Copy link
Contributor

@mountiny how does long load case correlates to current issue?

Is redundant loading of a chat happens only when long load issue exists?

@mountiny
Copy link
Contributor Author

It does not correlate, its a different issue, it will be moved somewhere else

@mallenexpensify
Copy link
Contributor

I'll stop buggin y'all about my unrelated slowness, posted in #stability

@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
@rayane-djouah
Copy link
Contributor

Not overdue, @kacper-mikolajczak is working on this

Copy link

melvin-bot bot commented Oct 18, 2024

@puneetlath, @mallenexpensify, @kacper-mikolajczak, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2024
@rayane-djouah
Copy link
Contributor

@kacper-mikolajczak could you please share an update? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Oct 18, 2024
@puneetlath
Copy link
Contributor

@mallenexpensify I believe @kacper-mikolajczak is no longer working on our project, so we'll need to get someone else.

@mallenexpensify
Copy link
Contributor

Posted in the callstack room https://expensify.slack.com/archives/C03UK30EA1Z/p1729298823156999

@muttmuure
Copy link
Contributor

Dupe of #49964

@kirillzyusko has pushed a fix that we are testing. We can reopen if you think this issue is different or unfixed by Kiryl's PR

@rinej
Copy link
Contributor

rinej commented Oct 21, 2024

@muttmuure I was about to take it over from Kacper, please let me know if we will need to reopen it

@mallenexpensify
Copy link
Contributor

Please take this over @rinej @muttmuure said they're still seeing this issue

@rinej
Copy link
Contributor

rinej commented Oct 28, 2024

@muttmuure do we have some more details on when this issue occurs?
Does this happen with only one particular report, or with any of them?

I tried reproducing it on iOS, and it seems to work fine. I don't have access to the thread above, so I can't check the details.

@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2024
@rayane-djouah
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Oct 28, 2024
@rayane-djouah
Copy link
Contributor

@muttmuure Friendly bump to address this comment

@muttmuure
Copy link
Contributor

@rinej the steps to reproduce are to:

  1. Open a chat, which should store the chat history in your cache
  2. Kill the app and from another account, send a message to the chat from step 1
  3. [Optional] wait some time - it's not clear if there is another command flushing the cache
  4. Reopen the app and the chat from step 1

See that the most recent message is displayed and the rest of the chat history shows a skeleton loader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: CRITICAL
Development

No branches or pull requests

7 participants