[HOLD for payment 2021-12-06] Unread messages - Unread messages count includes deleted messages

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with 2 accounts side by side
2. Tag a comment as unread and mark the count of unread comments
3. Delete some comments from the sender's account
4. Refresh the page
5. Mark the same comment as you did in step 2. Observe the count is still the same even though the messages on screen are less

Expected Result:

If the comment was deleted it should not be included in the unread messages count.

Actual Result:

Comment that was deleted is included in the message count.

Workaround:

Not sure (🤔)

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.98-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

New.Expensify.-.Google.Chrome.2021-09-13.19-10-44.mp4

Expensify/Expensify Issue URL:

Issue reported by: @kidroca
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1631549737202800

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[robertjchen]

Looks like a perfect task for a contributor to tackle!

[mallenexpensify]

Job posted https://www.upwork.com/jobs/~01143b9e85d8cc1924

[MelvinBot]

Triggered auto assignment to @puneetlath (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

Doubled to $500

[kadiealexander]

Please refer to this post for updated information on the n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.

[mallenexpensify]

@parasharrajat is hired! Assigned to him

[mallenexpensify]

n6-hold is lifted, label removed!

[parasharrajat]

PR would be up by next week.

[mallenexpensify]

@parasharrajat Can you provide an update on when we can expect the PR? Thanks

[parasharrajat]

I have started on it. It would be ready soon. I was busy last week.

[parasharrajat]

I would like to ask how the Mark as unread functionality works.
e.g. I marked the five latest messages as unread.

Now this includes messages from the Other user as well. What should be the unread message count?

[mallenexpensify]

@parasharrajat in the screenshot are you a different user? ie. are there 3 users in a group chat?
Regardless.. I have a feeling we're going to want to raise the question in #expensify-open-source to gain consensus.

[parasharrajat]

Awaiting review....

[mallenexpensify]

@puneetlath can you review the PR please #6248

[puneetlath]

@mallenexpensify this has been merged. Can we please make sure to add $500 when paying this? $250 for the offsite hold bonus and $250 for the increase in scope in the PR. Thanks!

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.16-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove deleted messages from the unread message count #6248

If no regressions arise, payment will be issued on 2021-12-06. 🎊

[parasharrajat]

Ping for

@mallenexpensify

For Reference

#5237 (comment)

[mallenexpensify]

@parasharrajat in the future, can you want til one day after the 'hold for payment' date before commenting? It's because I want to see if the 'overdue' label is properly being added to the issue after a week, that's the main trigger for a CM knowing an issue should be paid.

I've paid this in Upwork, job was $500 and added $250 for increased scope and $250 for company offsite hold bonus. (If payment looks weird, I issued the bonus after cancelling the contract, was checking/testing something)

[mallenexpensify]

Issue reported by: @kidroca

@kidroca I'm assuming this issue was reported as part of your hourly work, let me know if not

[kidroca]

@mallenexpensify
Actually not.
I reported it here: https://expensify.slack.com/archives/C01GTK53T8Q/p1631549737202800

This particular bug I've discovered here - #5106 (comment)
(a ticket outside the hourly contract), and I took the time to report it

But when I report "Bugs: " in Slack I don't add the time spent in my hourly contract

• if it gets approved I get a better pay from the reward program
• if it doesn't that's fine as well

[mallenexpensify]

@kidroca makes sense. Glad I asked/checked. Please approve the offer and confirm then I'll pay
https://www.upwork.com/jobs/~01b4a7ec47523bb3db

[mallenexpensify]

Paid @kidroca for reporting, thanks!