Remove deleted messages from the unread message count

[parasharrajat]

Details

Fixed Issues

$ #5237

Tests | QA Steps

1. Open the App on the web with account A.
2. Send a few messages. Count the number.
3. Delete some of the recently sent messages. Count the remaining number.
4. Log out, log in with account B for the same Chat.
5. Count should be correct for unread messages.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

output_file.mp4

Mobile Web

Desktop

iOS

Android

[parasharrajat]

Awaiting review....

[puneetlath]

@parasharrajat a couple interesting things I noticed while testing this:

1. When you mark a chat as unread, the unread count is immediately updated in the tab bar. However, when you delete a comment, the unread count in the tab bar in the current tab isn't updated. It is correct if you open in a new tab, but it doesn't update the existing tab. Why is that?
2. When you open the app in the new tab, the tab bar shows the proper unread count, but the "new" line that indicates the point at which the messages are unread from isn't shown. Do you want to raise a new issue for this.

[parasharrajat]

When you mark a chat as unread, the unread count is immediately updated in the tab bar. However, when you delete a comment, the unread count in the tab bar in the current tab isn't updated. It is correct if you open in a new tab, but it doesn't update the existing tab. Why is that?

I think because we manually set the count. And don't do that when a message is deleted. Do you want me to look into that as well in this PR?

When you open the app in the new tab, the tab bar shows the proper unread count, but the "new" line that indicates the point at which the messages are unread from isn't shown. Do you want to raise a new issue for this?

I noticed this too. The new line indicator is broken again and it is not predictable. Sometimes shows and somtimes not. I was about to raise this as well after review.

[puneetlath]

Do you want me to look into that as well in this PR?

Yes, I think we should do that as well. We can increase the payment by $250 to account for the increase in scope. cc @mallenexpensify

I was about to raise this as well after review.

Great!

[puneetlath]

The code generally looks good to me. I'll give it another review after that update. Thanks!

[parasharrajat]

Sure, Let me fix that.

[parasharrajat]

@puneetlath I have fixed it. Please review.

[puneetlath]

@parasharrajat I left you two minor comments, otherwise it looks good to me. Let me know what you think and then I'm happy to merge.

[parasharrajat]

@puneetlath Updated those. Thanks for pointing it out.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @puneetlath in version: 1.1.15-18 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅