Chat - After switching account from Spanish to English the app still shows in Spanish and no option to change language for gmail accounts

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with an account which is Spanish (expensifail domain account)
3. Log out from account
4. Log in with an account which is English (Expensifail or gmail account)
5. Go to Settings
6. Check the language of the app

Expected Result:

After switch accounts from Spanish to English, all Setting in English language displayed

Actual Result:

After switch accounts from Spanish to English, all Setting in Spanish language displayed. For public domain accounts there is no option to switch the language.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.99-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5238828_Screen_Recording_20210915-194557_New_Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

I can reproduce this on production, so I don't think it needs to be a deploy blocker? Going to test again with different accounts to make sure.

[francoisl]

I can reproduce in production, so I'm going to remove the deploy blocker label and we can make this a regular issue to fix.

[bondydaa]

thanks for taking a look Franc, tossing to the pool

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Christinadobrzyn]

I think this needed to be paused in favour of focusing on N6 projects. Added N6 hold the label. adding a weekly label to work on this in a week.

Update: talking this over with Kadie, I think I can create the job in Upwork just no PR deployment until after N6.

[Christinadobrzyn]

Hey @bondydaa can I have your opinion if this GH should remain separate from this?

#5113

I also saw this was deployed, do you think it might be causing this issue?

#4507

[isagoico]

Issue reproducible during KI retests.

[parasharrajat]

#5019 is a PR and that was already merged.

I have a proposal #5286 (comment) and #5286 (comment)

[kadiealexander]

Please refer to this post for updated information on the n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.

[Christinadobrzyn]

On hold for n6

[mvtglobally]

Issue reproducible during KI retests.

[mvtglobally]

Issue reproducible during KI retests.

[parasharrajat]

Proposal
#5286 (comment)

[marcaaron]

Solution looks good 👍

[Christinadobrzyn]

Hired @parasharrajat for this! 🎉

This job will include a $250 bonus for the n6 hold.

[mvtglobally]

Issue reproducible during KI retests.

[marcaaron]

Any updates here?

[parasharrajat]

PR is updated.

[mvtglobally]

Issue reproducible during KI retests.

[Christinadobrzyn]

not overdue - still working on the PR

[marcaaron]

What is the status of this issue? It seems like we are working on it in parallel, but I'm not sure. Should it be closed?

Going OOO for the next week so going to unassign myself for now.

[marcaaron]

@nickmurray47 do you know if this is at all different from this issue #6133?

[nickmurray47]

I think they are one and the same. The bug was that we were calling setLocale(), which sets the NVP and onyx key instead of just Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, value). Testing from my PR fixed this bug so I think we should be good once it gets deployed.

[parasharrajat]

Ok. Thanks for letting us know @nickmurray47. I think we are good to close the PR then. @Christinadobrzyn Please suggest further action for this issue.

[Christinadobrzyn]

I think they are one and the same. The bug was that we were calling setLocale(), which sets the NVP and onyx key instead of just Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, value). Testing from my PR fixed this bug so I think we should be good once it gets deployed.

@nickmurray47 or @marcaaron - to clarify the next steps for this issue - can you confirm this Upwork job should be closed prior to the PR going to production and @parasharrajat paid out?

[Christinadobrzyn]

Confirmed with @nickmurray47 to close this job.

Paid @parasharrajat $250 for the proposal and the promised $250 bonus for the offsite hold and closing the job/this post.