-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember preferred locale on signup/login #5019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MonilBhavsar, LGTM 👍
All yours @Luke9389 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one lil thing
Updated |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @roryabraham in version: 1.0.96-0 🚀
|
Upon login or Signup, get the
NVP_PREFERRED_LOCALE
. If it's not default(en) and changed, update the NVP and set that in Onyx, else set previously selected locale fetched from NVP in OnyxDetails
$ #4999
Tests/QA Steps
Tested On
Screenshots
Web
Screen.Recording.2021-09-02.at.11.01.03.PM.mov
Mobile Web
Desktop
Screen.Recording.2021-09-02.at.11.57.41.PM.mov
iOS
Simulator.Screen.Recording.-.iPhone.12.-.2021-09-02.at.23.23.09.mp4
Android
Screen.Recording.2021-09-02.at.11.49.46.PM.mov