Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember preferred locale on signup/login #5019

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Conversation

MonilBhavsar
Copy link
Contributor

@MonilBhavsar MonilBhavsar commented Sep 2, 2021

Upon login or Signup, get the NVP_PREFERRED_LOCALE. If it's not default(en) and changed, update the NVP and set that in Onyx, else set previously selected locale fetched from NVP in Onyx

Details

$ #4999

Tests/QA Steps

  1. From the login page select Espanyol and login
  2. Make sure language is changed inside the app
  3. From a new device or incognito window login into the app without changing anything(the login page by default will be in English)
  4. Verify language inside the app is still Espanyol.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2021-09-02.at.11.01.03.PM.mov

Mobile Web

Desktop

Screen.Recording.2021-09-02.at.11.57.41.PM.mov

iOS

Simulator.Screen.Recording.-.iPhone.12.-.2021-09-02.at.23.23.09.mp4

Android

Screen.Recording.2021-09-02.at.11.49.46.PM.mov

@MonilBhavsar MonilBhavsar self-assigned this Sep 2, 2021
@MonilBhavsar MonilBhavsar marked this pull request as ready for review September 2, 2021 18:33
@MonilBhavsar MonilBhavsar requested a review from a team as a code owner September 2, 2021 18:33
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team September 2, 2021 18:33
roryabraham
roryabraham previously approved these changes Sep 2, 2021
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MonilBhavsar, LGTM 👍

@roryabraham
Copy link
Contributor

All yours @Luke9389

Copy link
Contributor

@Luke9389 Luke9389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one lil thing

src/libs/Navigation/AppNavigator/AuthScreens.js Outdated Show resolved Hide resolved
@MonilBhavsar
Copy link
Contributor Author

Updated

@Luke9389 Luke9389 merged commit f8c6120 into main Sep 9, 2021
@Luke9389 Luke9389 deleted the monil-updateLocale branch September 9, 2021 19:32
@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2021

🚀 Deployed to staging by @Luke9389 in version: 1.0.95-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.96-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants