Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual issues when scrolling - Reported by: @parasharrajat #6425

Closed
isagoico opened this issue Nov 23, 2021 · 17 comments
Closed

Visual issues when scrolling - Reported by: @parasharrajat #6425

isagoico opened this issue Nov 23, 2021 · 17 comments
Assignees
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Hourly KSv2

Comments

@isagoico
Copy link

isagoico commented Nov 23, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to a conversation that has a long history.
  2. Scroll upwards and downward in a conversation quickly

Expected Result:

There should not be any visual issues.

Actual Result:

There are several visual issues shown:

  • Messages are not loading consistently
  • Messages are loading from bottom to top (should be the other way)
  • Blank page is also seen in the conversation

Workaround:

No need, visual issue.

Platform:

Where is this issue Confirmed?

  • Web

Version Number: 1.1.16-2

Reproducible in staging?: Yes
Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

chat.refresh.mp4

image

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversations:

View all open jobs on GitHub

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Nov 23, 2021
@MelvinBot
Copy link

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Nov 23, 2021
@cead22 cead22 removed their assignment Nov 23, 2021
@MelvinBot
Copy link

Triggered auto assignment to @jasperhuangg (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.

@parasharrajat
Copy link
Member

cc: @thienlnam

@isagoico isagoico changed the title Visual issues when scrolling - Reported by: @ Visual issues when scrolling - Reported by: @parasharrajat Nov 23, 2021
@botify botify closed this as completed Nov 23, 2021
@alex-mechler
Copy link
Contributor

Not sure why this was closed, its not on staging yet

@alex-mechler alex-mechler reopened this Nov 23, 2021
@alex-mechler
Copy link
Contributor

@isagoico the fix was CP'd to staging. Can you have this retested?

@isagoico
Copy link
Author

Retest for this was a pass! 🎉 Checking it off.

@parasharrajat
Copy link
Member

Am I eligible for reporting bonus here 😅 ?

@alex-mechler
Copy link
Contributor

Yup! Let me get someone assigned to take care of that!

@alex-mechler alex-mechler added the External Added to denote the issue can be worked on by a contributor label Nov 24, 2021
@MelvinBot
Copy link

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@alex-mechler
Copy link
Contributor

@michaelhaxhiu can you get @parasharrajat paid for reporting this issue? Thanks!

@michaelhaxhiu
Copy link
Contributor

Hm, the External label typically is applied before the job is posted and completed. Did Rajat propose and fix the issue? Or did he report it, and it was fixed internally?

A little confused where is the upwork link for this job?

@alex-mechler
Copy link
Contributor

Rajat reported the issue, and since it was a deployblocker I fixed it in the interest of speed. He is only due the reporting bonus

@michaelhaxhiu
Copy link
Contributor

since it was a deployblocker I fixed it in the interest of speed.

Ah!! Deployblockercash - missed that label, thanks for the context 🙇 . These often move swifty and totally makes sense. Rajat is to be compensated $250 then?

@michaelhaxhiu
Copy link
Contributor

@alex-mechler
Copy link
Contributor

Rajat is to be compensated $250 then?

Yup, as long as the reporting bonus is still $250!

@michaelhaxhiu
Copy link
Contributor

Paid, all done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Hourly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants