Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #6268 from azimgd/fix-inverted-list" #6441

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

alex-mechler
Copy link
Contributor

@alex-mechler alex-mechler commented Nov 23, 2021

This reverts commit 8d5a3ad, reversing
changes made to 339bb67.

cc @azimgd @thienlnam

Details

Fixes two deploy blockers caused by this pr #6268 by reverting the pr

Fixed Issues

$ #6425
$ #6436

Tests

  1. Open a new chat
  2. Send a message
  3. Verify the message appears at the bottom of the screen instead of the top
  4. Send a lot of messages
  5. Verify there are no visual issues when scrolling. Scrolling will be inverted.

QA Steps

  1. Open a new chat
  2. Send a message
  3. Verify the message appears at the bottom of the screen instead of the top
  4. Send a lot of messages
  5. Verify there are no visual issues when scrolling. Scrolling will be inverted.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

image

This reverts commit 8d5a3ad, reversing
changes made to 339bb67.
@alex-mechler alex-mechler requested a review from a team as a code owner November 23, 2021 19:53
@alex-mechler alex-mechler self-assigned this Nov 23, 2021
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team November 23, 2021 19:54
@thienlnam thienlnam merged commit f14c401 into main Nov 23, 2021
@thienlnam thienlnam deleted the amechler-revert-inverted-list branch November 23, 2021 20:48
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

github-actions bot pushed a commit that referenced this pull request Nov 23, 2021
@chiragsalian
Copy link
Contributor

Manually CP-d to staging.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @chiragsalian in version: 1.1.16-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @thienlnam in version: 1.1.16-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants