Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat messages are fixed top instead of bottom - Reported by: @PrashantMangukiya #6436

Closed
isagoico opened this issue Nov 23, 2021 · 13 comments
Closed
Assignees
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Hourly KSv2 Reviewing Has a PR in review

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Start a new conversation with a user
  2. Send a message

Expected Result:

Message should be displayed on the bottom of the conversation viewer.

Actual Result:

Message is displayed on top of the conversation viewer.

Workaround:

No need, visual issue.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.16-2

Reproducible in staging?: Yes
Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

Expensify/Expensify Issue URL:

Issue reported by: @PrashantMangukiya
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1637300247327600

View all open jobs on GitHub

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Nov 23, 2021
@MelvinBot
Copy link

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@isagoico
Copy link
Author

Non coder hunch here: Maybe this has the same source as #6415 (since both are fixing content to the top 🤔)

@parasharrajat
Copy link
Member

Very close @isagoico. Just that it is a side-effect of a PR which caused #6425

@alex-mechler
Copy link
Contributor

Yup, @parasharrajat your hunch is right. Reverting that locally fixed the issue. #6268 is the offending PR. cc @thienlnam @azimgd

@alex-mechler
Copy link
Contributor

Hmm, not sure why botify closed this, fix is not on staging yet

@alex-mechler alex-mechler reopened this Nov 23, 2021
@alex-mechler
Copy link
Contributor

@isagoico the fix was CP'd to staging. Can you have this retested?

@alex-mechler alex-mechler added the Reviewing Has a PR in review label Nov 24, 2021
@isagoico
Copy link
Author

Retest for this was a pass 🎉

@alex-mechler alex-mechler added the External Added to denote the issue can be worked on by a contributor label Nov 24, 2021
@MelvinBot
Copy link

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot MelvinBot added the Daily KSv2 label Nov 24, 2021
@alex-mechler
Copy link
Contributor

@trjExpensify can you get @PrashantMangukiya paid for reporting this issue? Thanks!

@trjExpensify
Copy link
Contributor

@PrashantMangukiya Offer sent 👍

@PrashantMangukiya
Copy link
Contributor

Offer Accepted.

@trjExpensify
Copy link
Contributor

Awesome, paid! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

8 participants