-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inverted list by applying forked version of react-native-web #6268
Conversation
outdated PR: #5561 |
@thienlnam ready to be merged ? |
Could you address the comment here ? #3381 (comment) |
The change would be moving the commands you have currently in your |
Done @thienlnam |
I think you need to add execute permissions to the file https://stackoverflow.com/questions/42154912/permission-denied-for-build-sh-file |
@thienlnam try now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, tests well for me locally - shipping it and 🤞 we don't cause regressions
Running tests |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @thienlnam in version: 1.1.15-18 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
|
🚀 Deployed to staging by @thienlnam in version: 1.1.16-11 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀
|
I used a patched version of react-native-web with fixes for copying text into the buffer in reversed order;
React native change: Expensify/react-native-web@bb711d2
Details
I have removed flatlist inversion (by inverted=true prop) which used [transform: translate] css hack and instead adding flatlist array items in reverse order [unshift instead of push]; It also reverses ScrollView event response received from browser [e.nativeEvent.configOffset *= -1];
Fixed Issues
#3381
Tests
npm install
which will patch react-native-web packagenpm run web
QA Steps
Tested On
Screenshots
Web
Screen.Recording.2021-08-09.at.01.16.16.mov
Mobile Web
Desktop
iOS
Android