[HOLD for payment 2022-05-26] [$500] On Request/send money, The contact preview is clickable and Cursor is set to pointer over it - reported by @Tushu17

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Chat > Select Actions
2. Send/Request money from chat Actions
3. Enter amount > Next

Expected Result:

Contact preview shouldn't be clickable as it doesn't perform any functions.

Actual Result:

Contact preview is clickable and showing cursor as a pointer

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.40-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-rec.1.1.mp4

2.New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1645806249670219

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @Justicea83 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[K4tsuki]

@mvtglobally, the reporter is @Tushu17.

[rushatgabhane]

This will be fixed here - #7702 (comment)
Issue can be closed once 7702 is merged

[MelvinBot]

@Justicea83 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rushatgabhane]

pr on hold

[Justicea83]

this issue is being worked on in another PR

[MelvinBot]

@Justicea83 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[rushatgabhane]

PR is on hold (because low priority)

[Justicea83]

Waiting for PR to be merged

[MelvinBot]

@Justicea83 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Justicea83]

Being worked on in another PR

[MelvinBot]

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[flodnv]

@Justicea83 @rushatgabhane Then let's assign @roryabraham who is working on the PR.

[rushatgabhane]

@roryabraham my issue with isIOUAttachedToExistingChatReport is that the variable name implies that it should be true for 1:1 chats. But it's actually false, which could lead to confusion.

How about isSplitInitiatedFromGroupOrRoom?

[Santhosh-Sellavel]

But it's actually false, which could lead to confusion.

@rushatgabhane
It should be false only when IOU flow is initiated from the FAB ➕ button, have you checked how it becomes false?

Also, we are not just renaming here actually, we should make changes to pass value correctly. Earlier we were passing true if it was from the group chat.

[mallenexpensify]

Doubled price to $500
https://www.upwork.com/jobs/~0188dac8c590e2d011

[rushatgabhane]

we are not just renaming here actually, we should make changes to pass value correctly

Ohhh okay. I'm not a fan of that idea, why not just rename? Won't it be easier while achieving the same thing?
isGroupSplit -> isSplitInitiatedFromGroupOrRoom

So it'll look like this canModifyParticipants = hasMultipleParticipants && isSplitInitiatedFromGroupOrRoom

[Santhosh-Sellavel]

But I think this (#8034 (comment)) is a simple & much cleaner solution.

I'll leave it to @roryabraham to make the final call.

[roryabraham]

I'm honestly fine with either. I think the two solutions are similar enough that it doesn't really matter. As long as we don't have both isGroupSplit and hasMultipleParticipants, then I'm 👍 for either plan.

I think I might prefer isIOUAttachedToExistingChat because I worry about setting an example for variable names like isXInitiatedFromY – I could see how that would encourage bad patterns where a function takes a flag and behaves differently based on where it's called from, which makes functions harder to reason about

[rushatgabhane]

@Santhosh-Sellavel feel free to fix this issue. (I don't have the bandwidth)

[Santhosh-Sellavel]

@roryabraham
I can't pick this one until Friday. So I'll raise PR on Friday. If that's okay please removeHelp Wanted Label, or let's leave it open to the pool. Thanks!

[roryabraham]

This doesn't seem very urgent, so Friday is fine imo.

[Santhosh-Sellavel]

@roryabraham Draft is already up, need to update PR Details.
I will update within 1 or 2 days. Sorry for the delay.

[Santhosh-Sellavel]

PR is Up now.

[mallenexpensify]

Looks like the PR is awaiting @roryabraham 's review
#8760

[mallenexpensify]

PR is being worked on
#8760

[mallenexpensify]

PR is on stagin

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.63-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• IOU Contact Preview clickable cursor issue fixed #8760

If no regressions arise, payment will be issued on 2022-05-26. 🎊

[Santhosh-Sellavel]

Doubled price to $500 https://www.upwork.com/jobs/~0188dac8c590e2d011

@mallenexpensify This job is no longer available can you set up a job for me!

[mallenexpensify]

Hired you @Santhosh-Sellavel , please accept.
https://www.upwork.com/jobs/~0131d47defbb078996

@Tushu17 , can you please apply too? (note... the price might show $500, you're due $250 for reporting, I'm partially testing the ability to pay less than the job price)

[Santhosh-Sellavel]

Thanks @mallenexpensify!

[Tushu17]

@mallenexpensify Okay, Applied. Thanks

[mallenexpensify]

Paid @Santhosh-Sellavel $500 for the fix
Hired @Tushu17 for $250 for reporting the issue, please let me know when you've accepted the offer

[Tushu17]

@mallenexpensify Okay, Offer accepted. Thank you.

[mallenexpensify]

Oh... just seeing payment isn't due til May 26th. Since I already paid @Santhosh-Sellavel for the fix, going to pay out @Tushu17 and close this. Comment on the issue if it needs to be reopened, no comments on the PR for five days so we're likely good.