Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU Contact Preview clickable cursor issue fixed #8760

Merged
merged 5 commits into from
May 18, 2022

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Apr 23, 2022

Details

This PR is more specific, I tested everything works well on all platforms.

Fixed Issues

$ #8034

Tests

  1. Open any group chat, by pressing ➕ icon in the chat composer.
  2. Click SplitBill and enter some amount process until the confirmation page.
  3. On the confirmation page you should be able to
    - hover on the participant and verify the selection pointer is shown
    - check/uncheck participant's selection
  4. Click SplitBill and enter some amount process until the confirmation page.
  5. On the confirmation page, you should be able to
    - hover on the participant and verify the disabled cursor pointer is shown
    - not able to deselect participants
  6. Perform Send Money, Request Money from FAB, or any 1:1 chat. On the confirmation page,
    - hover on the participant and verify the disabled cursor pointer is shown
  • Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • Any functional components have the displayName property
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose and it is
  • If a new CSS style is added I verified that:
    • A similar style doesn’t already exist
    • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • Any functional components have the displayName property
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn’t already exist
    • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

  1. Open a group chat not including concierge or chronos.
  2. Press ➕ icon in the chat composer.
  3. Click Split Bill.
  4. Enter an amount and click Next
  5. Hover over your name or login. Verify that the cursor is disabled and that you can't deselect yourself.
  6. Hover over any other participant. Verify that you see a pointer cursor, and that you can select/deselect participants.
  7. Close out of the Split Bill modal.
  8. Press on the big green ➕ on the home screen.
  9. Select Split Bill.
  10. Enter an amount, then click Next.
  11. Select multiple participants, then click Next.
  12. Hover over all of the participants. Verify that all options are disabled and cannot be selected or deselcted.
  13. Close out the Split Bill Modal.
  14. Open a 1:1 DM with any user other than concierge or chronos.
  15. Press ➕ icon in the chat composer.
  16. Click request money.
  17. Enter an amount and click Next
  18. Hover over the other participant. Verify that the cursor is disabled and that you can't deselect them.
  19. Close out the Request Money modal.
  20. Open a 1:1 DM with any user other than concierge or chronos.
  21. Press ➕ icon in the chat composer.
  22. Click send money.
  23. Enter an amount and click Next
  24. Hover over the other participant. Verify that the cursor is disabled and that you can't deselect them.
  25. Close out the send money modal.
  26. Press the big green ➕ on the home screen.
  27. Select Request Money
  28. Enter an amount and click Next
  29. Choose a recipient and click Next
  30. Hover over the other participant. Verify that the cursor is disabled and that you can't deselect them.
  31. Close out the request money modal.
  32. Press on the big green ➕ on the home screen.
  33. Select Send money
  34. Enter an amount and click Next
  35. Choose a recipient and click Next
  36. Hover over the other participant. Verify that the cursor is disabled and that you can't deselect them.
  37. Close out the send money modal.

@Expensify/applauseleads – please update the existing TR regression tests that cover Split bill, Request money, and Send money to include the steps here. i.e:

  • "Hover over yourself, verify that the cursor is disabled. Verify that you can't deselect yourself."

  • "Hover over the other participants. If you are requesting money from or sending money to a single user, they should be disabled on hover/unselectable. If you are splitting a bill, they should be disabled/unselectable only if you initiated the split bill from an existing group chat."

  • Verify that no errors appear in the JS console

Screenshots

Added attachments for only desktop & web.

Desktop

Desktop_RequestSendFromFAB.mov
Desktop_RequestSendFromChat.mov
Desktop_FromFAB.mov
Desktop_FromGroup.mov

Web

Web_fromFAB.mov
Web_fromChat.mov
Web_Split_Both.mov

@Santhosh-Sellavel
Copy link
Collaborator Author

Pulled changes from Main.

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well 👍

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Santhosh-Sellavel, I was updating your QA steps to make them more thorough, then I found one edge case that isn't quite right:

  1. Open any group chat not including concierge or chronos.
  2. Press on the ➕ icon in the message composer.
  3. Enter an amount and press Next.
  4. Hover over your own information. The cursor should appear as disabled (currently is a pointer, even though you can't deselect yourself)💥

@Santhosh-Sellavel
Copy link
Collaborator Author

That seems a new case to me, but I am sure it's well within the scope of this issue. I'll try to fix it by Monday or let's open it to contributors thanks!

@Santhosh-Sellavel
Copy link
Collaborator Author

Santhosh-Sellavel commented May 10, 2022

Can we add isDisabled in here for sections themselves

sections.push({
title: this.props.translate('iOUConfirmationList.whoPaid'),
data: [formattedMyPersonalDetails],
shouldShow: true,
indexOffset: 0,
}, {

And use it here

forceTextUnreadStyle={this.props.forceTextUnreadStyle}
isDisabled={this.props.isDisabled}
/>

as

isDisabled={this.props.isDisabled || section.isDisabled}

@Santhosh-Sellavel
Copy link
Collaborator Author

@roryabraham Here is my solution for the edge case #8760 (comment).

Let me know your comments.

@Santhosh-Sellavel
Copy link
Collaborator Author

bump @roryabraham

@Santhosh-Sellavel
Copy link
Collaborator Author

Sorry @Santhosh-Sellavel, I was updating your QA steps to make them more thorough, then I found one edge case that isn't quite right:

  1. Open any group chat not including concierge or chronos.
  2. Press on the ➕ icon in the message composer.
  3. Enter an amount and press Next.
  4. Hover over your own information. The cursor should appear as disabled (currently is a pointer, even though you can't deselect yourself)💥

Pushed the changes proposed here #8760 (comment)

Screen.Recording.2022-05-16.at.12.21.06.AM.mov

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that adjustment, @Santhosh-Sellavel

@roryabraham roryabraham merged commit 24294f2 into Expensify:main May 18, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.63-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.63-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.63-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants