Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of setNativeProps #10934

Closed
wants to merge 35 commits into from
Closed
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
8666d97
composer - move setNativeProps to state
rushatgabhane Sep 8, 2022
ecabcfc
reportEdit - remove setNativeProps
rushatgabhane Sep 8, 2022
1295ebb
SigninPageForm - remove setNativeProps
rushatgabhane Sep 8, 2022
27020f5
TextInput - replace setNativeProps with setAttribute
rushatgabhane Sep 8, 2022
72bbc0b
Revert "SigninPageForm - remove setNativeProps"
rushatgabhane Sep 8, 2022
ddfabdf
SignInPageForm - replace setNativeProps with setAttribute
rushatgabhane Sep 8, 2022
12fa935
TextInputLabel - replace setNativeProps with setAttribute
rushatgabhane Sep 8, 2022
e45288e
BaseOptionsSelector - move setNativeProps to state
rushatgabhane Sep 8, 2022
e2b07d2
Form - move inputValues to state to remove setNativeProps
rushatgabhane Sep 8, 2022
1cce3d5
InvertedFlatList - remove setNativeProps, pass style as a prop instead.
rushatgabhane Sep 8, 2022
4c90e34
Make Picker controlled only and remove setNativeProps
rushatgabhane Sep 8, 2022
1bfc4e2
fix picker state
rushatgabhane Sep 8, 2022
a0ff498
Merge remote-tracking branch 'origin/fix-storybook' into remove-setNa…
rushatgabhane Sep 10, 2022
8528c0d
Merge remote-tracking branch 'origin/fix-storybook' into remove-setNa…
rushatgabhane Sep 10, 2022
deeaef9
Merge remote-tracking branch 'origin/fix-storybook' into remove-setNa…
rushatgabhane Sep 10, 2022
b77ab39
Revert "Make Picker controlled only and remove setNativeProps"
rushatgabhane Sep 10, 2022
3298fa7
Revert "fix picker state"
rushatgabhane Sep 10, 2022
28fdeac
fix stale Form values validation
rushatgabhane Sep 10, 2022
38fd5ad
remove setNativeProps from Picker
rushatgabhane Sep 10, 2022
e23f51c
remove unnecessary value from profile page
rushatgabhane Sep 10, 2022
103e340
remove setNativeProps from reportSettingsPage
rushatgabhane Sep 10, 2022
1192191
fix eslint errors
rushatgabhane Sep 10, 2022
237d0dd
fix eslint errors
rushatgabhane Sep 10, 2022
7dd836f
fix setAttribute
rushatgabhane Sep 10, 2022
0644e1d
make picker work with Form
rushatgabhane Sep 11, 2022
e0fb68b
fix lint errors
rushatgabhane Sep 11, 2022
a8b8e7b
pass value to Form inputs
rushatgabhane Sep 11, 2022
97ebb65
Merge branch 'Expensify:main' into remove-setNativeProps
rushatgabhane Sep 13, 2022
5f1ecfe
cleaner styleee
rushatgabhane Sep 13, 2022
b4d3bdd
Merge branch 'Expensify:main' into remove-setNativeProps
rushatgabhane Sep 14, 2022
74cb3cb
init value in state
rushatgabhane Sep 15, 2022
cbf0415
fix picker ref
rushatgabhane Sep 15, 2022
358a77f
rm unnecessary picker prop
rushatgabhane Sep 15, 2022
aaab06b
profile page - use value prop for pickers
rushatgabhane Sep 15, 2022
2122178
Merge branch 'Expensify:main' into remove-setNativeProps
rushatgabhane Sep 15, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .storybook/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,7 @@ module.exports = {
'./public',
'../assets/css',
],
core: {
builder: 'webpack5',
},
};
Loading