Use push notification ID instead of accountID #13844

iwiznia · 2022-12-27T18:14:25Z

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/247195
$ #15466

Tests

Verify that no errors appear in the JS console
In web, check you can log in correctly

Offline tests

None

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2022-12-27T18:14:31Z

Looks like you modified deprecatedAPI.js! To be clear, you should not be adding any code to this file.

Instead, all new API commands should use API.js, and follow our guidelines for writing new API commands.

Unsure if your change is okay? Drop a note in #expensify-open-source!

AndrewGable · 2022-12-28T21:35:04Z

src/Expensify.js

@@ -70,6 +73,7 @@ const defaultProps = {
        authToken: null,
        accountID: null,
    },
+    private_pushNotificationID: null,


I think we should drop the private_ prefix here

Suggested change

private_pushNotificationID: null,

pushNotificationID: null,

Isn't it better to keep the same name as the onyx key and the same name as the NVP in the DB?
Why change it?

I looked at some examples, e.g. NVP_BLOCKED_FROM_CONCIERGE and it seems we drop the private_ prefix.

Do you agree that's better? Because to me, keeping the same name everywhere sounds better than changing it slightly in some places.

Yes, I agree it's better without the prefix

johnmlee101

LGTM AFAICT

AndrewGable

Looks good - I will test & add screenshots once this is off draft 👍 (Actually maybe the C+ assigned will?)

iwiznia · 2023-01-05T18:53:58Z

It's draft only because we are waiting on the release to be tested.... I don't plan to add changes (unless you find bugs 😄 ).
If it works better for you, I can make it not draft and add a HOLD.

Julesssss · 2023-01-09T16:51:09Z

I'm going to move this to [HOLD] as a notification project PR is blocked by this one, and it makes the reasoning clearer.

melvin-bot · 2023-01-09T16:51:50Z

@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss · 2023-01-09T16:52:27Z

It's draft only because we are waiting on the release to be tested

@iwiznia is this still true? I can't find where this is being discussed.

Julesssss · 2023-01-09T16:53:10Z

src/ONYXKEYS.js

@@ -76,6 +76,8 @@ export default {
    // Contains the users's block expiration (if they have one)
    NVP_BLOCKED_FROM_CONCIERGE: 'private_blockedFromConcierge',

+    NVP_PRIVATE_PUSH_NOTIFICATION_ID: 'private_pushNotificationID',


NAB: It isn't clear this ID is coming from Airship. Maybe a comment could help clarify.

Still NAB, but bumping this comment

Sorry, missed this. It is not coming from airship.

Could we add a comment to explain where it is coming from?

iwiznia · 2023-01-09T18:56:20Z

@iwiznia is this still true? I can't find where this is being discussed.

I think so... @AndrewGable how are we doing with the release?

iwiznia · 2023-02-10T15:32:18Z

Updated and retested

arosiclair · 2023-02-13T15:52:35Z

src/libs/actions/Session/index.js

-        if (previousAccountID === accountID) {
+    key: ONYXKEYS.NVP_PRIVATE_PUSH_NOTIFICATION_ID,
+    callback: (notificationID) => {
+        if (previousNotificationID === notificationID) {


You can get rid of this if check and previousNotificationID since it's only the notificationID changing in this Onyx key.

Ah true! Changed

Julesssss · 2023-02-20T17:51:25Z

Pesky conflicts. Ping us for a review when it's ready

iwiznia · 2023-02-22T14:40:22Z

Solved conflicts

rushatgabhane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

1.mp4

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

2ios.mp4

Android

rushatgabhane · 2023-02-22T19:10:43Z

@iwiznia i should be seeing a notification id nvp in onyx, right?

I'm pointing to staging server
Did a logout and login

rushatgabhane · 2023-02-22T19:20:26Z

@iwiznia my bad, it's stored as private_pushNotificationID and not nvp_private_push_notification_id

rushatgabhane

LGTM! 🎉

OSBotify · 2023-02-22T19:57:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-02-22T23:50:18Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.2.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-02-27T22:04:59Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.76-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-02-27T23:18:55Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.76-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-02-27T23:42:10Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.76-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Use push notification ID instead of accountID

0ed9485

iwiznia self-assigned this Dec 27, 2022

Merge branch 'main' into ionatan_pushnotificationID

7b25678

arosiclair self-requested a review December 27, 2022 20:01

arosiclair previously approved these changes Dec 27, 2022

View reviewed changes

iwiznia requested a review from AndrewGable December 27, 2022 22:51

Fix lint

8c3487d

iwiznia dismissed arosiclair’s stale review via 8c3487d December 28, 2022 21:12

AndrewGable reviewed Dec 28, 2022

View reviewed changes

Remove private prefix

3c1b67e

arosiclair previously approved these changes Jan 2, 2023

View reviewed changes

iwiznia requested review from AndrewGable and johnmlee101 January 4, 2023 19:08

johnmlee101 previously approved these changes Jan 4, 2023

View reviewed changes

AndrewGable previously approved these changes Jan 5, 2023

View reviewed changes

arosiclair mentioned this pull request Jan 5, 2023

Subscribe and unsubscribe push notifications on sign-in and sign-out #13845

Merged

53 tasks

Julesssss marked this pull request as ready for review January 9, 2023 16:51

Julesssss requested a review from a team as a code owner January 9, 2023 16:51

Julesssss changed the title ~~Use push notification ID instead of accountID~~ [HOLD] Use push notification ID instead of accountID Jan 9, 2023

melvin-bot bot requested review from techievivek and removed request for a team January 9, 2023 16:51

Julesssss reviewed Jan 9, 2023

View reviewed changes

Merge from main

f84dd97

iwiznia dismissed AndrewGable’s stale review via f84dd97 January 31, 2023 18:43

Move pusher subscribe to session

86915c4

iwiznia dismissed johnmlee101’s stale review via 86915c4 February 10, 2023 15:06

Styles and tests

8754d8a

arosiclair reviewed Feb 13, 2023

View reviewed changes

iwiznia added 2 commits February 13, 2023 17:57

Remove unneded if

c793dd8

Fix tests

30f921a

iwiznia requested a review from arosiclair February 14, 2023 13:01

arosiclair previously approved these changes Feb 15, 2023

View reviewed changes

Merge from main

f315dec

iwiznia dismissed arosiclair’s stale review via f315dec February 22, 2023 14:39

iwiznia added 2 commits February 22, 2023 14:00

Fix tests

e8cc86f

Add comment

0d7b8f2

Julesssss approved these changes Feb 22, 2023

View reviewed changes

iwiznia changed the title ~~[HOLD] Use push notification ID instead of accountID~~ Use push notification ID instead of accountID Feb 22, 2023

rushatgabhane reviewed Feb 22, 2023

View reviewed changes

rushatgabhane approved these changes Feb 22, 2023

View reviewed changes

iwiznia merged commit 1b0b16f into main Feb 22, 2023

iwiznia deleted the ionatan_pushnotificationID branch February 22, 2023 19:53

OSBotify mentioned this pull request Feb 22, 2023

Deploy Checklist: New Expensify 2023-02-22 #15389

Closed

28 tasks

mountiny mentioned this pull request Feb 24, 2023

[HOLD for payment 2023-03-06] Payment issue for E/App PR#13844 #15466

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use push notification ID instead of accountID #13844

Use push notification ID instead of accountID #13844

iwiznia commented Dec 27, 2022 •

edited by mountiny

Loading

melvin-bot bot commented Dec 27, 2022

AndrewGable Dec 28, 2022

iwiznia Dec 28, 2022

AndrewGable Dec 28, 2022

iwiznia Dec 28, 2022

AndrewGable Dec 28, 2022

iwiznia Dec 29, 2022

johnmlee101 left a comment

AndrewGable left a comment •

edited

Loading

iwiznia commented Jan 5, 2023

Julesssss commented Jan 9, 2023

melvin-bot bot commented Jan 9, 2023

Julesssss commented Jan 9, 2023

Julesssss Jan 9, 2023

Julesssss Feb 1, 2023

iwiznia Feb 1, 2023

Julesssss Feb 22, 2023

iwiznia Feb 22, 2023

iwiznia commented Jan 9, 2023

iwiznia commented Feb 10, 2023

arosiclair Feb 13, 2023

iwiznia Feb 13, 2023

Julesssss commented Feb 20, 2023

iwiznia commented Feb 22, 2023

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Feb 22, 2023 •

edited

Loading

rushatgabhane commented Feb 22, 2023 •

edited

Loading

rushatgabhane left a comment

OSBotify commented Feb 22, 2023

OSBotify commented Feb 22, 2023

OSBotify commented Feb 27, 2023

OSBotify commented Feb 27, 2023

OSBotify commented Feb 27, 2023

Use push notification ID instead of accountID #13844

Use push notification ID instead of accountID #13844

Conversation

iwiznia commented Dec 27, 2022 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 27, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnmlee101 left a comment

Choose a reason for hiding this comment

AndrewGable left a comment • edited Loading

Choose a reason for hiding this comment

iwiznia commented Jan 5, 2023

Julesssss commented Jan 9, 2023

melvin-bot bot commented Jan 9, 2023

Julesssss commented Jan 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iwiznia commented Jan 9, 2023

iwiznia commented Feb 10, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Julesssss commented Feb 20, 2023

iwiznia commented Feb 22, 2023

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

rushatgabhane commented Feb 22, 2023 • edited Loading

rushatgabhane commented Feb 22, 2023 • edited Loading

rushatgabhane left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 22, 2023

OSBotify commented Feb 22, 2023

OSBotify commented Feb 27, 2023

OSBotify commented Feb 27, 2023

OSBotify commented Feb 27, 2023

iwiznia commented Dec 27, 2022 •

edited by mountiny

Loading

AndrewGable left a comment •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Feb 22, 2023 •

edited

Loading

rushatgabhane commented Feb 22, 2023 •

edited

Loading