Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show the main composer when a message in editing is deleted #17221

Merged
merged 3 commits into from
Apr 12, 2023
Merged

show the main composer when a message in editing is deleted #17221

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aefe58f
show the main composer when a message in editing is deleted
bernhardoj Apr 10, 2023
28863af
apply lint suggestion
bernhardoj Apr 10, 2023
030437d
update comment
bernhardoj Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/pages/home/report/ReportActionItemMessageEdit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,17 @@ class ReportActionItemMessageEdit extends React.Component {
};
}

componentWillUnmount() {
// Skip if this is not the focused message so the other edit composer stays focused.
if (!this.state.isFocused) {
return;
}

// Show the main composer when the focused message is deleted from another client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernhardoj Could you add an explanation of why we only do it in the focused message and what the problem we trying to solve with that code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

// to prevent the main composer stays hidden until we swtich to another chat.
toggleReportActionComposeView(true, this.props.isSmallScreenWidth);
}

/**
* Update Selection on change cursor position.
*
Expand Down