-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Emoji Picker #1991
Add Emoji Picker #1991
Conversation
@shawnborton I actually progressed further than expected and it's just about done (at least the basic picker stuff). |
Also want to make sure @michelle-thompson as eyes on this as I think she worked on the Design Doc? |
Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks for making those fixes. LGTM 👍
@marcaaron Up to you for the merge! |
mWeb/iOS - There are empty spaces in emoji picker.Expected resultShould be no spaces in emoji picker. Selected picture should inset in the field. Actual resultBlank spaces are displayed in the emoji picker. Action performed
PlatformIssue only reproducible on iOS mWeb. mWeb iOS ✔️ Build 1.0.24-0 Notes/images/videos |
iPad - Emoji modal stuck in top corner if keyboard expandedExpected resultEmoji modal should open properly Actual resultEmoji modal stuck in top corner if keyboard expanded Action performed
PlatformIssue only reproducible on iPad iPad / iOS ✔️ Build 1.0.24-0 Notes/images/videos emoji.picker.mp4 |
This one is super weird, some of the emojis are also being repeated, my first thought is that it's a bug with react-native-web rendering a flatlist but that doesn't make a ton of sense because it works on non-mobile web |
This one is interesting, it's because the keyboard is open when we set the position, but then the keyboard goes away which puts it in the wrong spot. I think it's because it's using desktop functionality since the width is so big, but I'm not sure that we want the mobile version since it's huge? |
Oh this is extra weird because there's a search bar!? Does the index.native file not include mobile web? I guess that makes sense, but still weird |
Okay I figured out the problem with mobile web, that emojis is a combination of different emojis in unicode and apparently mobile safari hasn't updated to work with them. I'll just remove them for now. |
🚀 [Deployed](https://github.com/Expensify/Expensify.cash
|
Which deploy blockers remain unresolved here? It looks like @stitesExpensify had PRs for the two comments here that should have been included in today's staging version, so I'm wondering if this should be checked off in the deploy checklist |
@isagoico, can you please retest these deploy blockers during today's QA cycle and post and update with the results (and hopefully check them off the deploy checklist if they're no longer reproducible) |
#1991 (comment) and #1991 (comment) were not reproducible 🎉 checking the PR off the list |
🚀 Deployed to production in version: 1.0.39-5🚀
|
Following these instructions: Heads up @stitesExpensify @roryabraham @deetergp This PR caused a bug here: #10356 |
CC: @roryabraham since I'm using the modal you made
Details
This is a MVP for the emoji picker, it is just a basic picker that works on all platforms without features such as skin tone and a category jumper
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/143023
Tests/QA
Tested On
Screenshots
2021-03-29_13-01-39.mp4