Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emojis that are not implemented on mobile safari, and update header indices #2468

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

stitesExpensify
Copy link
Contributor

@stitesExpensify stitesExpensify commented Apr 19, 2021

Details

Some emojis are actually created by stringing multiple different emojis together and the browser figuring out that they make a different emoji. The emojis removed in this PR are not supported on all platforms so it's best to just get rid of them.

Fixed Issues

Fixes #1991 (comment)

Tests/QA

  1. Log in on iOS mobile web
  2. Choose a conversation
  3. Open the emoji picker
  4. Scroll down and make sure you don't see any weird spaces in the chat
  5. Make sure that the headers are sticking properly (as opposed to emojis sticking where the header should be)

Tested On

  • Mobile Web

Mobile Web

2021-04-19_14-55-13

@stitesExpensify stitesExpensify requested a review from a team as a code owner April 19, 2021 20:55
@stitesExpensify stitesExpensify self-assigned this Apr 19, 2021
@MelvinBot MelvinBot requested review from nkuoch and removed request for a team April 19, 2021 20:56
@stitesExpensify stitesExpensify requested review from a team and removed request for nkuoch April 20, 2021 19:23
@MelvinBot MelvinBot requested review from alex-mechler and removed request for a team April 20, 2021 19:23
@alex-mechler alex-mechler merged commit de24540 into main Apr 20, 2021
@alex-mechler alex-mechler deleted the stites-removeBrokenEmojis branch April 20, 2021 23:15
@OSBotify
Copy link
Contributor

🚀 Deployed to staging 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants