-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Release pending versions before submitting a new version for review #21366
Conversation
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@@ -243,6 +243,25 @@ platform :ios do | |||
|
|||
desc "Move app to App Store Review" | |||
lane :production do | |||
# Login to Spaceship |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next | ||
else | ||
# If there's an app that's Pending Developer Release, release it before continuing with the new version | ||
pendingReviewVersion = app.get_pending_release_app_store_version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure this code is doing what the P/S suggests in the linked issue? This is releasing a version if it's awaiting developer release (which we have automatic releases turned on, so not really sure this should ever happen) while the P/S in the linked issue says we should remove the version if it's pending Apple's review? |
Yes, you're right. I figured it's just as easy to release as to reject and more inline with our intended process.
Yet, it does happen: https://github.com/Expensify/App/actions/runs/5180754033 |
Reviewer Checklist
Screenshots/VideosWebN/A - GitHub Actions Mobile Web - ChromeN/A - GitHub Actions Mobile Web - SafariN/A - GitHub Actions DesktopN/A - GitHub Actions iOSN/A - GitHub Actions AndroidN/A - GitHub Actions |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.35-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀
|
FYI reverted here because I'm not sure how to fix and this will prevent errors when Francois attempts to deploy later today |
Also, minor point but I think we forgot to verify this change once it was merged. |
Details
This PR will check if there is a
Pending Developer Release
iOS app version in the production iOS deploy Fastlane lane. If there is a pending release version, we release it before submitting the new version for review.This is a known issue with Fastlane. I considered using https://github.com/andrew54068/fastlane-plugin-taiwan_number_one to resolve this because it was created for this exact use case, but in the end I decide the ruby code was simple enough and that plugin obscure enough that we can just do it manually in our Fastfile.
Fixed Issues
$ #20196
Tests
The only way to test this will be to run a production iOS deploy. That will tell us whether we at least don't have a regression here. I'm not sure how to test that it actually fixed the issue, so we'll just have to monitor.
Offline tests
None.
QA Steps
None
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android