Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA] Revert "Release pending versions before submitting a new version for review" #22541

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss requested a review from a team as a code owner July 10, 2023 08:18
@Julesssss Julesssss self-assigned this Jul 10, 2023
@melvin-bot melvin-bot bot requested review from aldo-expensify and removed request for a team July 10, 2023 08:19
@Expensify Expensify deleted a comment from melvin-bot bot Jul 10, 2023
@Julesssss
Copy link
Contributor Author

No checklist required, we're just reverting a CI flow addition that is causing ios App releases to fail

@MariaHCD MariaHCD merged commit b9f1d47 into main Jul 10, 2023
@MariaHCD MariaHCD deleted the revert-21366-Rory-ReleasePendingIOSApps branch July 10, 2023 08:27
@melvin-bot melvin-bot bot added the Emergency label Jul 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 10, 2023

@MariaHCD looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Julesssss
Copy link
Contributor Author

Cherry-picking this one as the checklist is already locked. This will prevent errors for Francois later today.

OSBotify pushed a commit that referenced this pull request Jul 10, 2023
…dingIOSApps

Revert "Release pending versions before submitting a new version for review"

(cherry picked from commit b9f1d47)
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.38-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Julesssss Julesssss changed the title Revert "Release pending versions before submitting a new version for review" [NO QA] Revert "Release pending versions before submitting a new version for review" Jul 10, 2023
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants