Refactor login form into a single component #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
tylerkaraszewski
and removed request for
a team
tylerkaraszewski
previously approved these changes
Apr 13, 2021
marcaaron
requested changes
Apr 13, 2021
marcaaron
reviewed
Apr 14, 2021
marcaaron
requested changes
Apr 14, 2021
66 tasks
|
🚀 Deployed to staging 🚀
|
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
This was referenced Feb 17, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Before, the
LoginFormcomponent had narrow and wide counterparts (sub-components), which made the logic confusing.In lieu of the changes in #2196, we can now refactor this into a single component without these counterparts and clean up the code.
Fixed Issues
Expensify/Expensify#157816
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android