Fix popovers after regression

[roryabraham]

cc @npsedhain @tgolen

Details

Fixing a regression caused by this PR

Fixed Issues

Fixes #2420

Tests / QA Steps (Web/Desktop)

1. Hit the global create FAB, and verify that the CreateMenu appears in the correct position in the sidebar. It should fade in from the left and fade out to the left.
2. Hit the + icon in the ReportActionCompose. Verify that the CreateMenu appears in the correct position above the compose input. It should fade in from the bottom and fade out to the bottom.
3. Go to Settings -> Profile -> Edit Photo. Verify that the CreateMenu appears in the correct position above the "Edit Photo" button. It should fade in from the right and fade out to the right.
4. Right click on a message, and verify that the ReportActionContextMenu appears as it should in the location where the user clicks.
5. Open the emoji picker, make sure it looks normal (it shouldn't have any noticeable animation when it opens and closes).

Tests / QA Steps (mWeb/iOS/Android)

1. Hit the following buttons, and verify that the CreateMenu appears as a bottom-docked modal:
   1. Global create FAB
   2. + in the ReportActionCompose
   3. Settings -> Profile -> Edit Photo
   4. Long-press a message.
   5. The emoji picker

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Menu	Web	Mobile Web	Desktop	iOS	Android
Global Create
ReportActionCompose
Edit Photo
ReportActionContextMenu
Emoji Picker

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[roryabraham]

WIP while I gather screenshots

[roryabraham]

recheck

[roryabraham]

Hmmm CLA is being weird ... commenting "recheck" did restart the CLA action which passed here, but for some reason it didn't update the PR. When I manually retried the check from the PR, it failed just like the first time due to the problem fixed in this PR

[roryabraham]

Retested after merging main (and added the new EmojiPickerMenu popover), and verified that this still fixes the popover issues.

[npsedhain]

hey @roryabraham, thanks so much for this, also I am sorry I didn't see this yesterday, it was late in the night this part of the world. Let me know if there is anything I can do.

[Beamanator]

Looks like you may be missing some screenshots for the emoji picker in android & desktop? I took these to help:

Desktop:

Android:

[roryabraham]

Thanks for testing and gathering those screenshots @Beamanator !

[Beamanator]

Love it - #LGTM 👍

[roryabraham]

@madmax330 I'm going to go ahead and merge this since it resolves a deploy blocker.

[isagoico]

Attachment button in iOS is not working as expected, keyboard opens instead of modal

Expected Result:

Popup " Add attachment" opens

Actual Result:

Popup flashes for a moment and keypad opens to enter the text

Action Performed:

1. Launch the app and login
2. Tap any chat from LHN
3. Tap + to attach a photo

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS ✔️
Android
Desktop App
Mobile Web

**Version Number:**1.0.24-.

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

attachment.mp4

[Beamanator]

I reproduced on your branch - I often forget to test with keyboard enabled, so great catch @isagoico 👍

[Beamanator]

I believe this is the problem - https://github.com/Expensify/Expensify.cash/blob/main/src/pages/home/report/ReportActionCompose.js#L294, but supposedly that was added to fix some modal 2 modal transition in another PR

[roryabraham]

Thanks for looking into this @Beamanator. I will fiddle around and try to fix it. This is why it's always better to test with a physical device...

[roryabraham]

Fix is here ... @isagoico are you sure this isn't present on production? I do not think this PR caused the bug/regression described.

[OSBotify]

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[isagoico]

@roryabraham Sorry that I missed this before. I just verified with a tester that this is not reproducible in prod.

[roryabraham]

Just confirmed on iOS v1.0.29-0 that this deploy blocker is solved.