-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keyboard bug when opening attachment modal #2460
Conversation
HOLD: not sure why yet but this seems to cause an app-crashing failure on android only. |
Okay, fixed and retested on iOS and Android. |
Okay, just tested on web, desktop, and mWeb and I think we are good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it 👍 and tests went quite well! LGTM
🚀 Deployed to staging 🚀
|
mWeb - Chat - Unable to add attachment on mweb SafariExpected Result:Able to add attachment on mweb Safari Actual Result:Unable to add attachment on mweb Safari Action Performed:
Build version : 1.0.27-0 Notes/Images/Videos |
Chat - Focus not regained in text input field after closing AttachmentPickerExpected Result:verify that the text input regains focus. Actual Result:Cursor focus not regained in text input field Action Performed:
Build version : 1.0.27-0 Notes/Images/Videos Bug5030758_Focus.mp4 |
Did this ever work? I'm just now realizing that there isn't really such a thing as a file picker on iOS like there is on macOS/chrome. I think mWeb needs an interface more like iOS has where one can choose between the camera, image picker, or document picker. In short I don't think this is a regression, but should be treated as a new feature with its own issue. |
This happened because the |
Okay, apparently this did work, so it is a real regression. I will continue to look into it |
Got the fix for this regression here. |
@isagoico Please retest the deploy blocker from this comment during tomorrow's QA. Should be fixed on |
#2460 (comment) was not reproducible 🎉 #2460 (comment) this is still reproducible |
See this comment ... the second "deploy blocker" listed on this PR was a miscommunication of expectations. I can confirm that it's working as expected so I'm removing the deploy blocker label. |
🚀 Deployed to production in version: 1.0.39-5🚀
|
Fixed Issues
Fixes #2424 (comment)
Tests / QA Steps (iOS/Android)
+
, verify that the create menu opens.+
, and selectAdd Attachment
CreateMenu
modal closes and is replaced by theAttachmentPickerMenu
Tests / QA Steps (web/desktop/mWeb)
Just perform regression testing of the report action compose and attachment modals.
Tested On
Screenshots
Web
n/a
Mobile Web
n/a
Desktop
n/a
iOS
keyboardFocusIOS.mov
Android
keyboardFocusAndroid.mov